aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/hid/hid-core.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 9f92f629d448..8617aa97a9c8 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -940,13 +940,8 @@ static void hid_output_field(struct hid_field *field, __u8 *data)
940 unsigned count = field->report_count; 940 unsigned count = field->report_count;
941 unsigned offset = field->report_offset; 941 unsigned offset = field->report_offset;
942 unsigned size = field->report_size; 942 unsigned size = field->report_size;
943 unsigned bitsused = offset + count * size;
944 unsigned n; 943 unsigned n;
945 944
946 /* make sure the unused bits in the last byte are zeros */
947 if (count > 0 && size > 0 && (bitsused % 8) != 0)
948 data[(bitsused-1)/8] &= (1 << (bitsused % 8)) - 1;
949
950 for (n = 0; n < count; n++) { 945 for (n = 0; n < count; n++) {
951 if (field->logical_minimum < 0) /* signed values */ 946 if (field->logical_minimum < 0) /* signed values */
952 implement(data, offset + n * size, size, s32ton(field->value[n], size)); 947 implement(data, offset + n * size, size, s32ton(field->value[n], size));
@@ -966,6 +961,7 @@ void hid_output_report(struct hid_report *report, __u8 *data)
966 if (report->id > 0) 961 if (report->id > 0)
967 *data++ = report->id; 962 *data++ = report->id;
968 963
964 memset(data, 0, ((report->size - 1) >> 3) + 1);
969 for (n = 0; n < report->maxfield; n++) 965 for (n = 0; n < report->maxfield; n++)
970 hid_output_field(report->field[n], data); 966 hid_output_field(report->field[n], data);
971} 967}