aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/i2c/i2c-core.c13
-rw-r--r--include/linux/i2c.h1
2 files changed, 8 insertions, 6 deletions
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index ba86af63f5cf..97f96b66653c 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -662,9 +662,9 @@ i2c_sysfs_new_device(struct device *dev, struct device_attribute *attr,
662 return -EINVAL; 662 return -EINVAL;
663 663
664 /* Keep track of the added device */ 664 /* Keep track of the added device */
665 i2c_lock_adapter(adap); 665 mutex_lock(&adap->userspace_clients_lock);
666 list_add_tail(&client->detected, &adap->userspace_clients); 666 list_add_tail(&client->detected, &adap->userspace_clients);
667 i2c_unlock_adapter(adap); 667 mutex_unlock(&adap->userspace_clients_lock);
668 dev_info(dev, "%s: Instantiated device %s at 0x%02hx\n", "new_device", 668 dev_info(dev, "%s: Instantiated device %s at 0x%02hx\n", "new_device",
669 info.type, info.addr); 669 info.type, info.addr);
670 670
@@ -703,7 +703,7 @@ i2c_sysfs_delete_device(struct device *dev, struct device_attribute *attr,
703 703
704 /* Make sure the device was added through sysfs */ 704 /* Make sure the device was added through sysfs */
705 res = -ENOENT; 705 res = -ENOENT;
706 i2c_lock_adapter(adap); 706 mutex_lock(&adap->userspace_clients_lock);
707 list_for_each_entry_safe(client, next, &adap->userspace_clients, 707 list_for_each_entry_safe(client, next, &adap->userspace_clients,
708 detected) { 708 detected) {
709 if (client->addr == addr) { 709 if (client->addr == addr) {
@@ -716,7 +716,7 @@ i2c_sysfs_delete_device(struct device *dev, struct device_attribute *attr,
716 break; 716 break;
717 } 717 }
718 } 718 }
719 i2c_unlock_adapter(adap); 719 mutex_unlock(&adap->userspace_clients_lock);
720 720
721 if (res < 0) 721 if (res < 0)
722 dev_err(dev, "%s: Can't find device in list\n", 722 dev_err(dev, "%s: Can't find device in list\n",
@@ -798,6 +798,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
798 } 798 }
799 799
800 rt_mutex_init(&adap->bus_lock); 800 rt_mutex_init(&adap->bus_lock);
801 mutex_init(&adap->userspace_clients_lock);
801 INIT_LIST_HEAD(&adap->userspace_clients); 802 INIT_LIST_HEAD(&adap->userspace_clients);
802 803
803 /* Set default timeout to 1 second if not already set */ 804 /* Set default timeout to 1 second if not already set */
@@ -1003,7 +1004,7 @@ int i2c_del_adapter(struct i2c_adapter *adap)
1003 return res; 1004 return res;
1004 1005
1005 /* Remove devices instantiated from sysfs */ 1006 /* Remove devices instantiated from sysfs */
1006 i2c_lock_adapter(adap); 1007 mutex_lock(&adap->userspace_clients_lock);
1007 list_for_each_entry_safe(client, next, &adap->userspace_clients, 1008 list_for_each_entry_safe(client, next, &adap->userspace_clients,
1008 detected) { 1009 detected) {
1009 dev_dbg(&adap->dev, "Removing %s at 0x%x\n", client->name, 1010 dev_dbg(&adap->dev, "Removing %s at 0x%x\n", client->name,
@@ -1011,7 +1012,7 @@ int i2c_del_adapter(struct i2c_adapter *adap)
1011 list_del(&client->detected); 1012 list_del(&client->detected);
1012 i2c_unregister_device(client); 1013 i2c_unregister_device(client);
1013 } 1014 }
1014 i2c_unlock_adapter(adap); 1015 mutex_unlock(&adap->userspace_clients_lock);
1015 1016
1016 /* Detach any active clients. This can't fail, thus we do not 1017 /* Detach any active clients. This can't fail, thus we do not
1017 checking the returned value. */ 1018 checking the returned value. */
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 5bf0f4beea31..798bad8741e4 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -368,6 +368,7 @@ struct i2c_adapter {
368 char name[48]; 368 char name[48];
369 struct completion dev_released; 369 struct completion dev_released;
370 370
371 struct mutex userspace_clients_lock;
371 struct list_head userspace_clients; 372 struct list_head userspace_clients;
372}; 373};
373#define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev) 374#define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev)