diff options
47 files changed, 99 insertions, 191 deletions
diff --git a/net/802/p8023.c b/net/802/p8023.c index 6368d3dce444..d23e906456eb 100644 --- a/net/802/p8023.c +++ b/net/802/p8023.c | |||
@@ -54,8 +54,7 @@ struct datalink_proto *make_8023_client(void) | |||
54 | */ | 54 | */ |
55 | void destroy_8023_client(struct datalink_proto *dl) | 55 | void destroy_8023_client(struct datalink_proto *dl) |
56 | { | 56 | { |
57 | if (dl) | 57 | kfree(dl); |
58 | kfree(dl); | ||
59 | } | 58 | } |
60 | 59 | ||
61 | EXPORT_SYMBOL(destroy_8023_client); | 60 | EXPORT_SYMBOL(destroy_8023_client); |
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index 8e37e71e34ff..1b683f302657 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c | |||
@@ -1138,10 +1138,8 @@ static int ax25_connect(struct socket *sock, struct sockaddr *uaddr, | |||
1138 | sk->sk_state = TCP_CLOSE; | 1138 | sk->sk_state = TCP_CLOSE; |
1139 | sock->state = SS_UNCONNECTED; | 1139 | sock->state = SS_UNCONNECTED; |
1140 | 1140 | ||
1141 | if (ax25->digipeat != NULL) { | 1141 | kfree(ax25->digipeat); |
1142 | kfree(ax25->digipeat); | 1142 | ax25->digipeat = NULL; |
1143 | ax25->digipeat = NULL; | ||
1144 | } | ||
1145 | 1143 | ||
1146 | /* | 1144 | /* |
1147 | * Handle digi-peaters to be used. | 1145 | * Handle digi-peaters to be used. |
diff --git a/net/ax25/ax25_in.c b/net/ax25/ax25_in.c index 73cfc3411c46..4cf87540fb3a 100644 --- a/net/ax25/ax25_in.c +++ b/net/ax25/ax25_in.c | |||
@@ -401,10 +401,8 @@ static int ax25_rcv(struct sk_buff *skb, struct net_device *dev, | |||
401 | } | 401 | } |
402 | 402 | ||
403 | if (dp.ndigi == 0) { | 403 | if (dp.ndigi == 0) { |
404 | if (ax25->digipeat != NULL) { | 404 | kfree(ax25->digipeat); |
405 | kfree(ax25->digipeat); | 405 | ax25->digipeat = NULL; |
406 | ax25->digipeat = NULL; | ||
407 | } | ||
408 | } else { | 406 | } else { |
409 | /* Reverse the source SABM's path */ | 407 | /* Reverse the source SABM's path */ |
410 | memcpy(ax25->digipeat, &reverse_dp, sizeof(ax25_digi)); | 408 | memcpy(ax25->digipeat, &reverse_dp, sizeof(ax25_digi)); |
diff --git a/net/ax25/ax25_route.c b/net/ax25/ax25_route.c index 26b77d972220..b1e945bd6ed3 100644 --- a/net/ax25/ax25_route.c +++ b/net/ax25/ax25_route.c | |||
@@ -54,15 +54,13 @@ void ax25_rt_device_down(struct net_device *dev) | |||
54 | if (s->dev == dev) { | 54 | if (s->dev == dev) { |
55 | if (ax25_route_list == s) { | 55 | if (ax25_route_list == s) { |
56 | ax25_route_list = s->next; | 56 | ax25_route_list = s->next; |
57 | if (s->digipeat != NULL) | 57 | kfree(s->digipeat); |
58 | kfree(s->digipeat); | ||
59 | kfree(s); | 58 | kfree(s); |
60 | } else { | 59 | } else { |
61 | for (t = ax25_route_list; t != NULL; t = t->next) { | 60 | for (t = ax25_route_list; t != NULL; t = t->next) { |
62 | if (t->next == s) { | 61 | if (t->next == s) { |
63 | t->next = s->next; | 62 | t->next = s->next; |
64 | if (s->digipeat != NULL) | 63 | kfree(s->digipeat); |
65 | kfree(s->digipeat); | ||
66 | kfree(s); | 64 | kfree(s); |
67 | break; | 65 | break; |
68 | } | 66 | } |
@@ -90,10 +88,8 @@ static int ax25_rt_add(struct ax25_routes_struct *route) | |||
90 | while (ax25_rt != NULL) { | 88 | while (ax25_rt != NULL) { |
91 | if (ax25cmp(&ax25_rt->callsign, &route->dest_addr) == 0 && | 89 | if (ax25cmp(&ax25_rt->callsign, &route->dest_addr) == 0 && |
92 | ax25_rt->dev == ax25_dev->dev) { | 90 | ax25_rt->dev == ax25_dev->dev) { |
93 | if (ax25_rt->digipeat != NULL) { | 91 | kfree(ax25_rt->digipeat); |
94 | kfree(ax25_rt->digipeat); | 92 | ax25_rt->digipeat = NULL; |
95 | ax25_rt->digipeat = NULL; | ||
96 | } | ||
97 | if (route->digi_count != 0) { | 93 | if (route->digi_count != 0) { |
98 | if ((ax25_rt->digipeat = kmalloc(sizeof(ax25_digi), GFP_ATOMIC)) == NULL) { | 94 | if ((ax25_rt->digipeat = kmalloc(sizeof(ax25_digi), GFP_ATOMIC)) == NULL) { |
99 | write_unlock(&ax25_route_lock); | 95 | write_unlock(&ax25_route_lock); |
@@ -145,8 +141,7 @@ static int ax25_rt_add(struct ax25_routes_struct *route) | |||
145 | static void ax25_rt_destroy(ax25_route *ax25_rt) | 141 | static void ax25_rt_destroy(ax25_route *ax25_rt) |
146 | { | 142 | { |
147 | if (atomic_read(&ax25_rt->ref) == 0) { | 143 | if (atomic_read(&ax25_rt->ref) == 0) { |
148 | if (ax25_rt->digipeat != NULL) | 144 | kfree(ax25_rt->digipeat); |
149 | kfree(ax25_rt->digipeat); | ||
150 | kfree(ax25_rt); | 145 | kfree(ax25_rt); |
151 | return; | 146 | return; |
152 | } | 147 | } |
@@ -530,9 +525,7 @@ void __exit ax25_rt_free(void) | |||
530 | s = ax25_rt; | 525 | s = ax25_rt; |
531 | ax25_rt = ax25_rt->next; | 526 | ax25_rt = ax25_rt->next; |
532 | 527 | ||
533 | if (s->digipeat != NULL) | 528 | kfree(s->digipeat); |
534 | kfree(s->digipeat); | ||
535 | |||
536 | kfree(s); | 529 | kfree(s); |
537 | } | 530 | } |
538 | write_unlock(&ax25_route_lock); | 531 | write_unlock(&ax25_route_lock); |
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index 860444a7fc0f..cdb9cfafd960 100644 --- a/net/bluetooth/hidp/core.c +++ b/net/bluetooth/hidp/core.c | |||
@@ -660,9 +660,7 @@ unlink: | |||
660 | failed: | 660 | failed: |
661 | up_write(&hidp_session_sem); | 661 | up_write(&hidp_session_sem); |
662 | 662 | ||
663 | if (session->input) | 663 | kfree(session->input); |
664 | kfree(session->input); | ||
665 | |||
666 | kfree(session); | 664 | kfree(session); |
667 | return err; | 665 | return err; |
668 | } | 666 | } |
diff --git a/net/core/dev_mcast.c b/net/core/dev_mcast.c index db098ff3cd6a..cb530eef0e39 100644 --- a/net/core/dev_mcast.c +++ b/net/core/dev_mcast.c | |||
@@ -194,8 +194,7 @@ int dev_mc_add(struct net_device *dev, void *addr, int alen, int glbl) | |||
194 | 194 | ||
195 | done: | 195 | done: |
196 | spin_unlock_bh(&dev->xmit_lock); | 196 | spin_unlock_bh(&dev->xmit_lock); |
197 | if (dmi1) | 197 | kfree(dmi1); |
198 | kfree(dmi1); | ||
199 | return err; | 198 | return err; |
200 | } | 199 | } |
201 | 200 | ||
diff --git a/net/core/sock.c b/net/core/sock.c index 9602ceb3bac9..13cc3be4f056 100644 --- a/net/core/sock.c +++ b/net/core/sock.c | |||
@@ -1242,8 +1242,7 @@ static void sock_def_write_space(struct sock *sk) | |||
1242 | 1242 | ||
1243 | static void sock_def_destruct(struct sock *sk) | 1243 | static void sock_def_destruct(struct sock *sk) |
1244 | { | 1244 | { |
1245 | if (sk->sk_protinfo) | 1245 | kfree(sk->sk_protinfo); |
1246 | kfree(sk->sk_protinfo); | ||
1247 | } | 1246 | } |
1248 | 1247 | ||
1249 | void sk_send_sigurg(struct sock *sk) | 1248 | void sk_send_sigurg(struct sock *sk) |
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c index 4b9bc81ae1a3..ca03521112c5 100644 --- a/net/dccp/ipv4.c +++ b/net/dccp/ipv4.c | |||
@@ -1263,10 +1263,8 @@ static int dccp_v4_destroy_sock(struct sock *sk) | |||
1263 | if (inet_csk(sk)->icsk_bind_hash != NULL) | 1263 | if (inet_csk(sk)->icsk_bind_hash != NULL) |
1264 | inet_put_port(&dccp_hashinfo, sk); | 1264 | inet_put_port(&dccp_hashinfo, sk); |
1265 | 1265 | ||
1266 | if (dp->dccps_service_list != NULL) { | 1266 | kfree(dp->dccps_service_list); |
1267 | kfree(dp->dccps_service_list); | 1267 | dp->dccps_service_list = NULL; |
1268 | dp->dccps_service_list = NULL; | ||
1269 | } | ||
1270 | 1268 | ||
1271 | ccid_hc_rx_exit(dp->dccps_hc_rx_ccid, sk); | 1269 | ccid_hc_rx_exit(dp->dccps_hc_rx_ccid, sk); |
1272 | ccid_hc_tx_exit(dp->dccps_hc_tx_ccid, sk); | 1270 | ccid_hc_tx_exit(dp->dccps_hc_tx_ccid, sk); |
diff --git a/net/dccp/proto.c b/net/dccp/proto.c index a021c3422f67..e0ace7cbb996 100644 --- a/net/dccp/proto.c +++ b/net/dccp/proto.c | |||
@@ -238,8 +238,7 @@ static int dccp_setsockopt_service(struct sock *sk, const u32 service, | |||
238 | lock_sock(sk); | 238 | lock_sock(sk); |
239 | dp->dccps_service = service; | 239 | dp->dccps_service = service; |
240 | 240 | ||
241 | if (dp->dccps_service_list != NULL) | 241 | kfree(dp->dccps_service_list); |
242 | kfree(dp->dccps_service_list); | ||
243 | 242 | ||
244 | dp->dccps_service_list = sl; | 243 | dp->dccps_service_list = sl; |
245 | release_sock(sk); | 244 | release_sock(sk); |
diff --git a/net/decnet/dn_table.c b/net/decnet/dn_table.c index eeba56f99323..6f8b5658cb4e 100644 --- a/net/decnet/dn_table.c +++ b/net/decnet/dn_table.c | |||
@@ -784,16 +784,14 @@ struct dn_fib_table *dn_fib_get_table(int n, int create) | |||
784 | 784 | ||
785 | static void dn_fib_del_tree(int n) | 785 | static void dn_fib_del_tree(int n) |
786 | { | 786 | { |
787 | struct dn_fib_table *t; | 787 | struct dn_fib_table *t; |
788 | 788 | ||
789 | write_lock(&dn_fib_tables_lock); | 789 | write_lock(&dn_fib_tables_lock); |
790 | t = dn_fib_tables[n]; | 790 | t = dn_fib_tables[n]; |
791 | dn_fib_tables[n] = NULL; | 791 | dn_fib_tables[n] = NULL; |
792 | write_unlock(&dn_fib_tables_lock); | 792 | write_unlock(&dn_fib_tables_lock); |
793 | 793 | ||
794 | if (t) { | 794 | kfree(t); |
795 | kfree(t); | ||
796 | } | ||
797 | } | 795 | } |
798 | 796 | ||
799 | struct dn_fib_table *dn_fib_empty_table(void) | 797 | struct dn_fib_table *dn_fib_empty_table(void) |
diff --git a/net/ethernet/pe2.c b/net/ethernet/pe2.c index 98a494be6039..9d57b4fb6440 100644 --- a/net/ethernet/pe2.c +++ b/net/ethernet/pe2.c | |||
@@ -32,8 +32,7 @@ struct datalink_proto *make_EII_client(void) | |||
32 | 32 | ||
33 | void destroy_EII_client(struct datalink_proto *dl) | 33 | void destroy_EII_client(struct datalink_proto *dl) |
34 | { | 34 | { |
35 | if (dl) | 35 | kfree(dl); |
36 | kfree(dl); | ||
37 | } | 36 | } |
38 | 37 | ||
39 | EXPORT_SYMBOL(destroy_EII_client); | 38 | EXPORT_SYMBOL(destroy_EII_client); |
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index a9d84f93442c..eaa150c33b04 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c | |||
@@ -147,8 +147,7 @@ void inet_sock_destruct(struct sock *sk) | |||
147 | BUG_TRAP(!sk->sk_wmem_queued); | 147 | BUG_TRAP(!sk->sk_wmem_queued); |
148 | BUG_TRAP(!sk->sk_forward_alloc); | 148 | BUG_TRAP(!sk->sk_forward_alloc); |
149 | 149 | ||
150 | if (inet->opt) | 150 | kfree(inet->opt); |
151 | kfree(inet->opt); | ||
152 | dst_release(sk->sk_dst_cache); | 151 | dst_release(sk->sk_dst_cache); |
153 | sk_refcnt_debug_dec(sk); | 152 | sk_refcnt_debug_dec(sk); |
154 | } | 153 | } |
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 990633c09dfe..2267c1fad879 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c | |||
@@ -266,8 +266,7 @@ int ip_rt_ioctl(unsigned int cmd, void __user *arg) | |||
266 | if (tb) | 266 | if (tb) |
267 | err = tb->tb_insert(tb, &req.rtm, &rta, &req.nlh, NULL); | 267 | err = tb->tb_insert(tb, &req.rtm, &rta, &req.nlh, NULL); |
268 | } | 268 | } |
269 | if (rta.rta_mx) | 269 | kfree(rta.rta_mx); |
270 | kfree(rta.rta_mx); | ||
271 | } | 270 | } |
272 | rtnl_unlock(); | 271 | rtnl_unlock(); |
273 | return err; | 272 | return err; |
diff --git a/net/ipv4/ip_options.c b/net/ipv4/ip_options.c index bce4e875193b..dbe12da8d8b3 100644 --- a/net/ipv4/ip_options.c +++ b/net/ipv4/ip_options.c | |||
@@ -510,8 +510,7 @@ static int ip_options_get_finish(struct ip_options **optp, | |||
510 | kfree(opt); | 510 | kfree(opt); |
511 | return -EINVAL; | 511 | return -EINVAL; |
512 | } | 512 | } |
513 | if (*optp) | 513 | kfree(*optp); |
514 | kfree(*optp); | ||
515 | *optp = opt; | 514 | *optp = opt; |
516 | return 0; | 515 | return 0; |
517 | } | 516 | } |
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 17758234a3e3..df7f20da422d 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c | |||
@@ -1262,10 +1262,8 @@ int ip_push_pending_frames(struct sock *sk) | |||
1262 | 1262 | ||
1263 | out: | 1263 | out: |
1264 | inet->cork.flags &= ~IPCORK_OPT; | 1264 | inet->cork.flags &= ~IPCORK_OPT; |
1265 | if (inet->cork.opt) { | 1265 | kfree(inet->cork.opt); |
1266 | kfree(inet->cork.opt); | 1266 | inet->cork.opt = NULL; |
1267 | inet->cork.opt = NULL; | ||
1268 | } | ||
1269 | if (inet->cork.rt) { | 1267 | if (inet->cork.rt) { |
1270 | ip_rt_put(inet->cork.rt); | 1268 | ip_rt_put(inet->cork.rt); |
1271 | inet->cork.rt = NULL; | 1269 | inet->cork.rt = NULL; |
@@ -1289,10 +1287,8 @@ void ip_flush_pending_frames(struct sock *sk) | |||
1289 | kfree_skb(skb); | 1287 | kfree_skb(skb); |
1290 | 1288 | ||
1291 | inet->cork.flags &= ~IPCORK_OPT; | 1289 | inet->cork.flags &= ~IPCORK_OPT; |
1292 | if (inet->cork.opt) { | 1290 | kfree(inet->cork.opt); |
1293 | kfree(inet->cork.opt); | 1291 | inet->cork.opt = NULL; |
1294 | inet->cork.opt = NULL; | ||
1295 | } | ||
1296 | if (inet->cork.rt) { | 1292 | if (inet->cork.rt) { |
1297 | ip_rt_put(inet->cork.rt); | 1293 | ip_rt_put(inet->cork.rt); |
1298 | inet->cork.rt = NULL; | 1294 | inet->cork.rt = NULL; |
diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c index 2f0b47da5b37..4f2d87257309 100644 --- a/net/ipv4/ip_sockglue.c +++ b/net/ipv4/ip_sockglue.c | |||
@@ -202,8 +202,7 @@ int ip_ra_control(struct sock *sk, unsigned char on, void (*destructor)(struct s | |||
202 | if (ra->sk == sk) { | 202 | if (ra->sk == sk) { |
203 | if (on) { | 203 | if (on) { |
204 | write_unlock_bh(&ip_ra_lock); | 204 | write_unlock_bh(&ip_ra_lock); |
205 | if (new_ra) | 205 | kfree(new_ra); |
206 | kfree(new_ra); | ||
207 | return -EADDRINUSE; | 206 | return -EADDRINUSE; |
208 | } | 207 | } |
209 | *rap = ra->next; | 208 | *rap = ra->next; |
@@ -446,8 +445,7 @@ int ip_setsockopt(struct sock *sk, int level, int optname, char __user *optval, | |||
446 | #endif | 445 | #endif |
447 | } | 446 | } |
448 | opt = xchg(&inet->opt, opt); | 447 | opt = xchg(&inet->opt, opt); |
449 | if (opt) | 448 | kfree(opt); |
450 | kfree(opt); | ||
451 | break; | 449 | break; |
452 | } | 450 | } |
453 | case IP_PKTINFO: | 451 | case IP_PKTINFO: |
@@ -828,10 +826,8 @@ int ip_setsockopt(struct sock *sk, int level, int optname, char __user *optval, | |||
828 | 826 | ||
829 | err = ip_mc_msfilter(sk, msf, ifindex); | 827 | err = ip_mc_msfilter(sk, msf, ifindex); |
830 | mc_msf_out: | 828 | mc_msf_out: |
831 | if (msf) | 829 | kfree(msf); |
832 | kfree(msf); | 830 | kfree(gsf); |
833 | if (gsf) | ||
834 | kfree(gsf); | ||
835 | break; | 831 | break; |
836 | } | 832 | } |
837 | case IP_ROUTER_ALERT: | 833 | case IP_ROUTER_ALERT: |
diff --git a/net/ipv4/ipvs/ip_vs_app.c b/net/ipv4/ipvs/ip_vs_app.c index fc6f95aaa969..d7eb680101c2 100644 --- a/net/ipv4/ipvs/ip_vs_app.c +++ b/net/ipv4/ipvs/ip_vs_app.c | |||
@@ -110,8 +110,7 @@ ip_vs_app_inc_new(struct ip_vs_app *app, __u16 proto, __u16 port) | |||
110 | return 0; | 110 | return 0; |
111 | 111 | ||
112 | out: | 112 | out: |
113 | if (inc->timeout_table) | 113 | kfree(inc->timeout_table); |
114 | kfree(inc->timeout_table); | ||
115 | kfree(inc); | 114 | kfree(inc); |
116 | return ret; | 115 | return ret; |
117 | } | 116 | } |
@@ -136,8 +135,7 @@ ip_vs_app_inc_release(struct ip_vs_app *inc) | |||
136 | 135 | ||
137 | list_del(&inc->a_list); | 136 | list_del(&inc->a_list); |
138 | 137 | ||
139 | if (inc->timeout_table != NULL) | 138 | kfree(inc->timeout_table); |
140 | kfree(inc->timeout_table); | ||
141 | kfree(inc); | 139 | kfree(inc); |
142 | } | 140 | } |
143 | 141 | ||
diff --git a/net/ipv4/multipath_wrandom.c b/net/ipv4/multipath_wrandom.c index bd7d75b6abe0..d34a9fa608e0 100644 --- a/net/ipv4/multipath_wrandom.c +++ b/net/ipv4/multipath_wrandom.c | |||
@@ -207,16 +207,12 @@ static void wrandom_select_route(const struct flowi *flp, | |||
207 | decision = mpc->rt; | 207 | decision = mpc->rt; |
208 | 208 | ||
209 | last_power = mpc->power; | 209 | last_power = mpc->power; |
210 | if (last_mpc) | 210 | kfree(last_mpc); |
211 | kfree(last_mpc); | ||
212 | |||
213 | last_mpc = mpc; | 211 | last_mpc = mpc; |
214 | } | 212 | } |
215 | 213 | ||
216 | if (last_mpc) { | 214 | /* concurrent __multipath_flush may lead to !last_mpc */ |
217 | /* concurrent __multipath_flush may lead to !last_mpc */ | 215 | kfree(last_mpc); |
218 | kfree(last_mpc); | ||
219 | } | ||
220 | 216 | ||
221 | decision->u.dst.__use++; | 217 | decision->u.dst.__use++; |
222 | *rp = decision; | 218 | *rp = decision; |
diff --git a/net/ipv4/netfilter/ip_nat_snmp_basic.c b/net/ipv4/netfilter/ip_nat_snmp_basic.c index 93b2c5111bb2..8acb7ed40b47 100644 --- a/net/ipv4/netfilter/ip_nat_snmp_basic.c +++ b/net/ipv4/netfilter/ip_nat_snmp_basic.c | |||
@@ -1161,8 +1161,7 @@ static int snmp_parse_mangle(unsigned char *msg, | |||
1161 | 1161 | ||
1162 | if (!snmp_object_decode(&ctx, obj)) { | 1162 | if (!snmp_object_decode(&ctx, obj)) { |
1163 | if (*obj) { | 1163 | if (*obj) { |
1164 | if ((*obj)->id) | 1164 | kfree((*obj)->id); |
1165 | kfree((*obj)->id); | ||
1166 | kfree(*obj); | 1165 | kfree(*obj); |
1167 | } | 1166 | } |
1168 | kfree(obj); | 1167 | kfree(obj); |
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 49d67cd75edd..634dabb558fd 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c | |||
@@ -823,8 +823,7 @@ out: | |||
823 | */ | 823 | */ |
824 | static void tcp_v4_reqsk_destructor(struct request_sock *req) | 824 | static void tcp_v4_reqsk_destructor(struct request_sock *req) |
825 | { | 825 | { |
826 | if (inet_rsk(req)->opt) | 826 | kfree(inet_rsk(req)->opt); |
827 | kfree(inet_rsk(req)->opt); | ||
828 | } | 827 | } |
829 | 828 | ||
830 | static inline void syn_flood_warning(struct sk_buff *skb) | 829 | static inline void syn_flood_warning(struct sk_buff *skb) |
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index a34d1504deb9..b7a5f51238b3 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c | |||
@@ -3090,8 +3090,7 @@ static int inet6_fill_ifinfo(struct sk_buff *skb, struct inet6_dev *idev, | |||
3090 | 3090 | ||
3091 | nlmsg_failure: | 3091 | nlmsg_failure: |
3092 | rtattr_failure: | 3092 | rtattr_failure: |
3093 | if (array) | 3093 | kfree(array); |
3094 | kfree(array); | ||
3095 | skb_trim(skb, b - skb->data); | 3094 | skb_trim(skb, b - skb->data); |
3096 | return -1; | 3095 | return -1; |
3097 | } | 3096 | } |
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 614296a920c6..dbd9767b32e4 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c | |||
@@ -587,8 +587,7 @@ static int ip6_fragment(struct sk_buff *skb, int (*output)(struct sk_buff *)) | |||
587 | skb->next = NULL; | 587 | skb->next = NULL; |
588 | } | 588 | } |
589 | 589 | ||
590 | if (tmp_hdr) | 590 | kfree(tmp_hdr); |
591 | kfree(tmp_hdr); | ||
592 | 591 | ||
593 | if (err == 0) { | 592 | if (err == 0) { |
594 | IP6_INC_STATS(IPSTATS_MIB_FRAGOKS); | 593 | IP6_INC_STATS(IPSTATS_MIB_FRAGOKS); |
@@ -1186,10 +1185,8 @@ int ip6_push_pending_frames(struct sock *sk) | |||
1186 | 1185 | ||
1187 | out: | 1186 | out: |
1188 | inet->cork.flags &= ~IPCORK_OPT; | 1187 | inet->cork.flags &= ~IPCORK_OPT; |
1189 | if (np->cork.opt) { | 1188 | kfree(np->cork.opt); |
1190 | kfree(np->cork.opt); | 1189 | np->cork.opt = NULL; |
1191 | np->cork.opt = NULL; | ||
1192 | } | ||
1193 | if (np->cork.rt) { | 1190 | if (np->cork.rt) { |
1194 | dst_release(&np->cork.rt->u.dst); | 1191 | dst_release(&np->cork.rt->u.dst); |
1195 | np->cork.rt = NULL; | 1192 | np->cork.rt = NULL; |
@@ -1214,10 +1211,8 @@ void ip6_flush_pending_frames(struct sock *sk) | |||
1214 | 1211 | ||
1215 | inet->cork.flags &= ~IPCORK_OPT; | 1212 | inet->cork.flags &= ~IPCORK_OPT; |
1216 | 1213 | ||
1217 | if (np->cork.opt) { | 1214 | kfree(np->cork.opt); |
1218 | kfree(np->cork.opt); | 1215 | np->cork.opt = NULL; |
1219 | np->cork.opt = NULL; | ||
1220 | } | ||
1221 | if (np->cork.rt) { | 1216 | if (np->cork.rt) { |
1222 | dst_release(&np->cork.rt->u.dst); | 1217 | dst_release(&np->cork.rt->u.dst); |
1223 | np->cork.rt = NULL; | 1218 | np->cork.rt = NULL; |
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index cf94372d1af3..e6b0e3954c02 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c | |||
@@ -756,8 +756,7 @@ ip6ip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev) | |||
756 | } | 756 | } |
757 | ip6_tnl_dst_store(t, dst); | 757 | ip6_tnl_dst_store(t, dst); |
758 | 758 | ||
759 | if (opt) | 759 | kfree(opt); |
760 | kfree(opt); | ||
761 | 760 | ||
762 | t->recursion--; | 761 | t->recursion--; |
763 | return 0; | 762 | return 0; |
@@ -766,8 +765,7 @@ tx_err_link_failure: | |||
766 | dst_link_failure(skb); | 765 | dst_link_failure(skb); |
767 | tx_err_dst_release: | 766 | tx_err_dst_release: |
768 | dst_release(dst); | 767 | dst_release(dst); |
769 | if (opt) | 768 | kfree(opt); |
770 | kfree(opt); | ||
771 | tx_err: | 769 | tx_err: |
772 | stats->tx_errors++; | 770 | stats->tx_errors++; |
773 | stats->tx_dropped++; | 771 | stats->tx_dropped++; |
diff --git a/net/ipv6/ipcomp6.c b/net/ipv6/ipcomp6.c index 85bfbc69b2c3..55917fb17094 100644 --- a/net/ipv6/ipcomp6.c +++ b/net/ipv6/ipcomp6.c | |||
@@ -130,8 +130,7 @@ static int ipcomp6_input(struct xfrm_state *x, struct xfrm_decap_state *decap, s | |||
130 | out_put_cpu: | 130 | out_put_cpu: |
131 | put_cpu(); | 131 | put_cpu(); |
132 | out: | 132 | out: |
133 | if (tmp_hdr) | 133 | kfree(tmp_hdr); |
134 | kfree(tmp_hdr); | ||
135 | if (err) | 134 | if (err) |
136 | goto error_out; | 135 | goto error_out; |
137 | return nexthdr; | 136 | return nexthdr; |
diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 8567873d0dd8..003fd99ff597 100644 --- a/net/ipv6/ipv6_sockglue.c +++ b/net/ipv6/ipv6_sockglue.c | |||
@@ -80,8 +80,7 @@ int ip6_ra_control(struct sock *sk, int sel, void (*destructor)(struct sock *)) | |||
80 | if (ra->sk == sk) { | 80 | if (ra->sk == sk) { |
81 | if (sel>=0) { | 81 | if (sel>=0) { |
82 | write_unlock_bh(&ip6_ra_lock); | 82 | write_unlock_bh(&ip6_ra_lock); |
83 | if (new_ra) | 83 | kfree(new_ra); |
84 | kfree(new_ra); | ||
85 | return -EADDRINUSE; | 84 | return -EADDRINUSE; |
86 | } | 85 | } |
87 | 86 | ||
diff --git a/net/irda/discovery.c b/net/irda/discovery.c index c4ba5fa1446a..3fefc822c1c0 100644 --- a/net/irda/discovery.c +++ b/net/irda/discovery.c | |||
@@ -194,8 +194,7 @@ void irlmp_expire_discoveries(hashbin_t *log, __u32 saddr, int force) | |||
194 | 194 | ||
195 | /* Remove it from the log */ | 195 | /* Remove it from the log */ |
196 | curr = hashbin_remove_this(log, (irda_queue_t *) curr); | 196 | curr = hashbin_remove_this(log, (irda_queue_t *) curr); |
197 | if (curr) | 197 | kfree(curr); |
198 | kfree(curr); | ||
199 | } | 198 | } |
200 | } | 199 | } |
201 | 200 | ||
diff --git a/net/irda/irias_object.c b/net/irda/irias_object.c index 6fec428b4512..75f2666e8630 100644 --- a/net/irda/irias_object.c +++ b/net/irda/irias_object.c | |||
@@ -122,8 +122,7 @@ static void __irias_delete_attrib(struct ias_attrib *attrib) | |||
122 | IRDA_ASSERT(attrib != NULL, return;); | 122 | IRDA_ASSERT(attrib != NULL, return;); |
123 | IRDA_ASSERT(attrib->magic == IAS_ATTRIB_MAGIC, return;); | 123 | IRDA_ASSERT(attrib->magic == IAS_ATTRIB_MAGIC, return;); |
124 | 124 | ||
125 | if (attrib->name) | 125 | kfree(attrib->name); |
126 | kfree(attrib->name); | ||
127 | 126 | ||
128 | irias_delete_value(attrib->value); | 127 | irias_delete_value(attrib->value); |
129 | attrib->magic = ~IAS_ATTRIB_MAGIC; | 128 | attrib->magic = ~IAS_ATTRIB_MAGIC; |
@@ -136,8 +135,7 @@ void __irias_delete_object(struct ias_object *obj) | |||
136 | IRDA_ASSERT(obj != NULL, return;); | 135 | IRDA_ASSERT(obj != NULL, return;); |
137 | IRDA_ASSERT(obj->magic == IAS_OBJECT_MAGIC, return;); | 136 | IRDA_ASSERT(obj->magic == IAS_OBJECT_MAGIC, return;); |
138 | 137 | ||
139 | if (obj->name) | 138 | kfree(obj->name); |
140 | kfree(obj->name); | ||
141 | 139 | ||
142 | hashbin_delete(obj->attribs, (FREE_FUNC) __irias_delete_attrib); | 140 | hashbin_delete(obj->attribs, (FREE_FUNC) __irias_delete_attrib); |
143 | 141 | ||
@@ -562,14 +560,12 @@ void irias_delete_value(struct ias_value *value) | |||
562 | /* No need to deallocate */ | 560 | /* No need to deallocate */ |
563 | break; | 561 | break; |
564 | case IAS_STRING: | 562 | case IAS_STRING: |
565 | /* If string, deallocate string */ | 563 | /* Deallocate string */ |
566 | if (value->t.string != NULL) | 564 | kfree(value->t.string); |
567 | kfree(value->t.string); | ||
568 | break; | 565 | break; |
569 | case IAS_OCT_SEQ: | 566 | case IAS_OCT_SEQ: |
570 | /* If byte stream, deallocate byte stream */ | 567 | /* Deallocate byte stream */ |
571 | if (value->t.oct_seq != NULL) | 568 | kfree(value->t.oct_seq); |
572 | kfree(value->t.oct_seq); | ||
573 | break; | 569 | break; |
574 | default: | 570 | default: |
575 | IRDA_DEBUG(0, "%s(), Unknown value type!\n", __FUNCTION__); | 571 | IRDA_DEBUG(0, "%s(), Unknown value type!\n", __FUNCTION__); |
diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c index b18fe5043019..8631b65a7312 100644 --- a/net/rose/rose_route.c +++ b/net/rose/rose_route.c | |||
@@ -240,8 +240,7 @@ static void rose_remove_neigh(struct rose_neigh *rose_neigh) | |||
240 | if ((s = rose_neigh_list) == rose_neigh) { | 240 | if ((s = rose_neigh_list) == rose_neigh) { |
241 | rose_neigh_list = rose_neigh->next; | 241 | rose_neigh_list = rose_neigh->next; |
242 | spin_unlock_bh(&rose_neigh_list_lock); | 242 | spin_unlock_bh(&rose_neigh_list_lock); |
243 | if (rose_neigh->digipeat != NULL) | 243 | kfree(rose_neigh->digipeat); |
244 | kfree(rose_neigh->digipeat); | ||
245 | kfree(rose_neigh); | 244 | kfree(rose_neigh); |
246 | return; | 245 | return; |
247 | } | 246 | } |
@@ -250,8 +249,7 @@ static void rose_remove_neigh(struct rose_neigh *rose_neigh) | |||
250 | if (s->next == rose_neigh) { | 249 | if (s->next == rose_neigh) { |
251 | s->next = rose_neigh->next; | 250 | s->next = rose_neigh->next; |
252 | spin_unlock_bh(&rose_neigh_list_lock); | 251 | spin_unlock_bh(&rose_neigh_list_lock); |
253 | if (rose_neigh->digipeat != NULL) | 252 | kfree(rose_neigh->digipeat); |
254 | kfree(rose_neigh->digipeat); | ||
255 | kfree(rose_neigh); | 253 | kfree(rose_neigh); |
256 | return; | 254 | return; |
257 | } | 255 | } |
diff --git a/net/sched/cls_fw.c b/net/sched/cls_fw.c index 29d8b9a4d162..75470486e405 100644 --- a/net/sched/cls_fw.c +++ b/net/sched/cls_fw.c | |||
@@ -298,8 +298,7 @@ static int fw_change(struct tcf_proto *tp, unsigned long base, | |||
298 | return 0; | 298 | return 0; |
299 | 299 | ||
300 | errout: | 300 | errout: |
301 | if (f) | 301 | kfree(f); |
302 | kfree(f); | ||
303 | return err; | 302 | return err; |
304 | } | 303 | } |
305 | 304 | ||
diff --git a/net/sched/cls_route.c b/net/sched/cls_route.c index 02996ac05c75..520ff716dab2 100644 --- a/net/sched/cls_route.c +++ b/net/sched/cls_route.c | |||
@@ -525,8 +525,7 @@ reinsert: | |||
525 | return 0; | 525 | return 0; |
526 | 526 | ||
527 | errout: | 527 | errout: |
528 | if (f) | 528 | kfree(f); |
529 | kfree(f); | ||
530 | return err; | 529 | return err; |
531 | } | 530 | } |
532 | 531 | ||
diff --git a/net/sched/cls_rsvp.h b/net/sched/cls_rsvp.h index 006168d69376..572f06be3b02 100644 --- a/net/sched/cls_rsvp.h +++ b/net/sched/cls_rsvp.h | |||
@@ -555,8 +555,7 @@ insert: | |||
555 | goto insert; | 555 | goto insert; |
556 | 556 | ||
557 | errout: | 557 | errout: |
558 | if (f) | 558 | kfree(f); |
559 | kfree(f); | ||
560 | errout2: | 559 | errout2: |
561 | tcf_exts_destroy(tp, &e); | 560 | tcf_exts_destroy(tp, &e); |
562 | return err; | 561 | return err; |
diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c index 404d9d83a7fa..9f921174c8ab 100644 --- a/net/sched/cls_tcindex.c +++ b/net/sched/cls_tcindex.c | |||
@@ -194,8 +194,7 @@ found: | |||
194 | } | 194 | } |
195 | tcf_unbind_filter(tp, &r->res); | 195 | tcf_unbind_filter(tp, &r->res); |
196 | tcf_exts_destroy(tp, &r->exts); | 196 | tcf_exts_destroy(tp, &r->exts); |
197 | if (f) | 197 | kfree(f); |
198 | kfree(f); | ||
199 | return 0; | 198 | return 0; |
200 | } | 199 | } |
201 | 200 | ||
@@ -442,10 +441,8 @@ static void tcindex_destroy(struct tcf_proto *tp) | |||
442 | walker.skip = 0; | 441 | walker.skip = 0; |
443 | walker.fn = &tcindex_destroy_element; | 442 | walker.fn = &tcindex_destroy_element; |
444 | tcindex_walk(tp,&walker); | 443 | tcindex_walk(tp,&walker); |
445 | if (p->perfect) | 444 | kfree(p->perfect); |
446 | kfree(p->perfect); | 445 | kfree(p->h); |
447 | if (p->h) | ||
448 | kfree(p->h); | ||
449 | kfree(p); | 446 | kfree(p); |
450 | tp->root = NULL; | 447 | tp->root = NULL; |
451 | } | 448 | } |
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 364b87d86455..2b670479dde1 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c | |||
@@ -347,7 +347,7 @@ static int u32_destroy_key(struct tcf_proto *tp, struct tc_u_knode *n) | |||
347 | if (n->ht_down) | 347 | if (n->ht_down) |
348 | n->ht_down->refcnt--; | 348 | n->ht_down->refcnt--; |
349 | #ifdef CONFIG_CLS_U32_PERF | 349 | #ifdef CONFIG_CLS_U32_PERF |
350 | if (n && (NULL != n->pf)) | 350 | if (n) |
351 | kfree(n->pf); | 351 | kfree(n->pf); |
352 | #endif | 352 | #endif |
353 | kfree(n); | 353 | kfree(n); |
@@ -680,7 +680,7 @@ static int u32_change(struct tcf_proto *tp, unsigned long base, u32 handle, | |||
680 | return 0; | 680 | return 0; |
681 | } | 681 | } |
682 | #ifdef CONFIG_CLS_U32_PERF | 682 | #ifdef CONFIG_CLS_U32_PERF |
683 | if (n && (NULL != n->pf)) | 683 | if (n) |
684 | kfree(n->pf); | 684 | kfree(n->pf); |
685 | #endif | 685 | #endif |
686 | kfree(n); | 686 | kfree(n); |
diff --git a/net/sched/em_meta.c b/net/sched/em_meta.c index cf68a59fdc5a..700844d49d79 100644 --- a/net/sched/em_meta.c +++ b/net/sched/em_meta.c | |||
@@ -561,8 +561,7 @@ static int meta_var_change(struct meta_value *dst, struct rtattr *rta) | |||
561 | 561 | ||
562 | static void meta_var_destroy(struct meta_value *v) | 562 | static void meta_var_destroy(struct meta_value *v) |
563 | { | 563 | { |
564 | if (v->val) | 564 | kfree((void *) v->val); |
565 | kfree((void *) v->val); | ||
566 | } | 565 | } |
567 | 566 | ||
568 | static void meta_var_apply_extras(struct meta_value *v, | 567 | static void meta_var_apply_extras(struct meta_value *v, |
diff --git a/net/sctp/associola.c b/net/sctp/associola.c index 12b0f582a66b..8c8ddf7f9b61 100644 --- a/net/sctp/associola.c +++ b/net/sctp/associola.c | |||
@@ -344,9 +344,7 @@ void sctp_association_free(struct sctp_association *asoc) | |||
344 | } | 344 | } |
345 | 345 | ||
346 | /* Free peer's cached cookie. */ | 346 | /* Free peer's cached cookie. */ |
347 | if (asoc->peer.cookie) { | 347 | kfree(asoc->peer.cookie); |
348 | kfree(asoc->peer.cookie); | ||
349 | } | ||
350 | 348 | ||
351 | /* Release the transport structures. */ | 349 | /* Release the transport structures. */ |
352 | list_for_each_safe(pos, temp, &asoc->peer.transport_addr_list) { | 350 | list_for_each_safe(pos, temp, &asoc->peer.transport_addr_list) { |
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c index 660c61bdf164..f9573eba5c7a 100644 --- a/net/sctp/sm_make_chunk.c +++ b/net/sctp/sm_make_chunk.c | |||
@@ -254,8 +254,7 @@ struct sctp_chunk *sctp_make_init(const struct sctp_association *asoc, | |||
254 | aiparam.adaption_ind = htonl(sp->adaption_ind); | 254 | aiparam.adaption_ind = htonl(sp->adaption_ind); |
255 | sctp_addto_chunk(retval, sizeof(aiparam), &aiparam); | 255 | sctp_addto_chunk(retval, sizeof(aiparam), &aiparam); |
256 | nodata: | 256 | nodata: |
257 | if (addrs.v) | 257 | kfree(addrs.v); |
258 | kfree(addrs.v); | ||
259 | return retval; | 258 | return retval; |
260 | } | 259 | } |
261 | 260 | ||
@@ -347,8 +346,7 @@ struct sctp_chunk *sctp_make_init_ack(const struct sctp_association *asoc, | |||
347 | nomem_chunk: | 346 | nomem_chunk: |
348 | kfree(cookie); | 347 | kfree(cookie); |
349 | nomem_cookie: | 348 | nomem_cookie: |
350 | if (addrs.v) | 349 | kfree(addrs.v); |
351 | kfree(addrs.v); | ||
352 | return retval; | 350 | return retval; |
353 | } | 351 | } |
354 | 352 | ||
diff --git a/net/sunrpc/auth_gss/gss_krb5_seal.c b/net/sunrpc/auth_gss/gss_krb5_seal.c index 13f8ae979454..d0dfdfd5e79e 100644 --- a/net/sunrpc/auth_gss/gss_krb5_seal.c +++ b/net/sunrpc/auth_gss/gss_krb5_seal.c | |||
@@ -143,6 +143,6 @@ gss_get_mic_kerberos(struct gss_ctx *gss_ctx, struct xdr_buf *text, | |||
143 | 143 | ||
144 | return ((ctx->endtime < now) ? GSS_S_CONTEXT_EXPIRED : GSS_S_COMPLETE); | 144 | return ((ctx->endtime < now) ? GSS_S_CONTEXT_EXPIRED : GSS_S_COMPLETE); |
145 | out_err: | 145 | out_err: |
146 | if (md5cksum.data) kfree(md5cksum.data); | 146 | kfree(md5cksum.data); |
147 | return GSS_S_FAILURE; | 147 | return GSS_S_FAILURE; |
148 | } | 148 | } |
diff --git a/net/sunrpc/auth_gss/gss_krb5_unseal.c b/net/sunrpc/auth_gss/gss_krb5_unseal.c index 2030475d98ed..db055fd7d778 100644 --- a/net/sunrpc/auth_gss/gss_krb5_unseal.c +++ b/net/sunrpc/auth_gss/gss_krb5_unseal.c | |||
@@ -176,6 +176,6 @@ gss_verify_mic_kerberos(struct gss_ctx *gss_ctx, | |||
176 | 176 | ||
177 | ret = GSS_S_COMPLETE; | 177 | ret = GSS_S_COMPLETE; |
178 | out: | 178 | out: |
179 | if (md5cksum.data) kfree(md5cksum.data); | 179 | kfree(md5cksum.data); |
180 | return ret; | 180 | return ret; |
181 | } | 181 | } |
diff --git a/net/sunrpc/auth_gss/gss_mech_switch.c b/net/sunrpc/auth_gss/gss_mech_switch.c index b048bf672da2..f8bac6ccd524 100644 --- a/net/sunrpc/auth_gss/gss_mech_switch.c +++ b/net/sunrpc/auth_gss/gss_mech_switch.c | |||
@@ -60,8 +60,7 @@ gss_mech_free(struct gss_api_mech *gm) | |||
60 | 60 | ||
61 | for (i = 0; i < gm->gm_pf_num; i++) { | 61 | for (i = 0; i < gm->gm_pf_num; i++) { |
62 | pf = &gm->gm_pfs[i]; | 62 | pf = &gm->gm_pfs[i]; |
63 | if (pf->auth_domain_name) | 63 | kfree(pf->auth_domain_name); |
64 | kfree(pf->auth_domain_name); | ||
65 | pf->auth_domain_name = NULL; | 64 | pf->auth_domain_name = NULL; |
66 | } | 65 | } |
67 | } | 66 | } |
diff --git a/net/sunrpc/auth_gss/gss_spkm3_seal.c b/net/sunrpc/auth_gss/gss_spkm3_seal.c index 148201e929d0..d1e12b25d6e2 100644 --- a/net/sunrpc/auth_gss/gss_spkm3_seal.c +++ b/net/sunrpc/auth_gss/gss_spkm3_seal.c | |||
@@ -122,8 +122,7 @@ spkm3_make_token(struct spkm3_ctx *ctx, | |||
122 | 122 | ||
123 | return GSS_S_COMPLETE; | 123 | return GSS_S_COMPLETE; |
124 | out_err: | 124 | out_err: |
125 | if (md5cksum.data) | 125 | kfree(md5cksum.data); |
126 | kfree(md5cksum.data); | ||
127 | token->data = NULL; | 126 | token->data = NULL; |
128 | token->len = 0; | 127 | token->len = 0; |
129 | return GSS_S_FAILURE; | 128 | return GSS_S_FAILURE; |
diff --git a/net/sunrpc/auth_gss/gss_spkm3_token.c b/net/sunrpc/auth_gss/gss_spkm3_token.c index 46c08a0710f6..1f824578d773 100644 --- a/net/sunrpc/auth_gss/gss_spkm3_token.c +++ b/net/sunrpc/auth_gss/gss_spkm3_token.c | |||
@@ -259,8 +259,7 @@ spkm3_verify_mic_token(unsigned char **tokp, int *mic_hdrlen, unsigned char **ck | |||
259 | 259 | ||
260 | ret = GSS_S_COMPLETE; | 260 | ret = GSS_S_COMPLETE; |
261 | out: | 261 | out: |
262 | if (spkm3_ctx_id.data) | 262 | kfree(spkm3_ctx_id.data); |
263 | kfree(spkm3_ctx_id.data); | ||
264 | return ret; | 263 | return ret; |
265 | } | 264 | } |
266 | 265 | ||
diff --git a/net/sunrpc/auth_gss/gss_spkm3_unseal.c b/net/sunrpc/auth_gss/gss_spkm3_unseal.c index c3c0d9586103..241d5b30dfcb 100644 --- a/net/sunrpc/auth_gss/gss_spkm3_unseal.c +++ b/net/sunrpc/auth_gss/gss_spkm3_unseal.c | |||
@@ -120,9 +120,7 @@ spkm3_read_token(struct spkm3_ctx *ctx, | |||
120 | /* XXX: need to add expiration and sequencing */ | 120 | /* XXX: need to add expiration and sequencing */ |
121 | ret = GSS_S_COMPLETE; | 121 | ret = GSS_S_COMPLETE; |
122 | out: | 122 | out: |
123 | if (md5cksum.data) | 123 | kfree(md5cksum.data); |
124 | kfree(md5cksum.data); | 124 | kfree(wire_cksum.data); |
125 | if (wire_cksum.data) | ||
126 | kfree(wire_cksum.data); | ||
127 | return ret; | 125 | return ret; |
128 | } | 126 | } |
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index 5a220b2bb376..e4296c8b861e 100644 --- a/net/sunrpc/svc.c +++ b/net/sunrpc/svc.c | |||
@@ -196,12 +196,9 @@ svc_exit_thread(struct svc_rqst *rqstp) | |||
196 | struct svc_serv *serv = rqstp->rq_server; | 196 | struct svc_serv *serv = rqstp->rq_server; |
197 | 197 | ||
198 | svc_release_buffer(rqstp); | 198 | svc_release_buffer(rqstp); |
199 | if (rqstp->rq_resp) | 199 | kfree(rqstp->rq_resp); |
200 | kfree(rqstp->rq_resp); | 200 | kfree(rqstp->rq_argp); |
201 | if (rqstp->rq_argp) | 201 | kfree(rqstp->rq_auth_data); |
202 | kfree(rqstp->rq_argp); | ||
203 | if (rqstp->rq_auth_data) | ||
204 | kfree(rqstp->rq_auth_data); | ||
205 | kfree(rqstp); | 202 | kfree(rqstp); |
206 | 203 | ||
207 | /* Release the server */ | 204 | /* Release the server */ |
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c index 32df43372ee9..aaf08cdd19f0 100644 --- a/net/sunrpc/xdr.c +++ b/net/sunrpc/xdr.c | |||
@@ -992,8 +992,7 @@ xdr_xcode_array2(struct xdr_buf *buf, unsigned int base, | |||
992 | err = 0; | 992 | err = 0; |
993 | 993 | ||
994 | out: | 994 | out: |
995 | if (elem) | 995 | kfree(elem); |
996 | kfree(elem); | ||
997 | if (ppages) | 996 | if (ppages) |
998 | kunmap(*ppages); | 997 | kunmap(*ppages); |
999 | return err; | 998 | return err; |
diff --git a/net/wanrouter/af_wanpipe.c b/net/wanrouter/af_wanpipe.c index 596cb96e5f47..59fec59b2132 100644 --- a/net/wanrouter/af_wanpipe.c +++ b/net/wanrouter/af_wanpipe.c | |||
@@ -1099,7 +1099,7 @@ static void release_driver(struct sock *sk) | |||
1099 | sock_reset_flag(sk, SOCK_ZAPPED); | 1099 | sock_reset_flag(sk, SOCK_ZAPPED); |
1100 | wp = wp_sk(sk); | 1100 | wp = wp_sk(sk); |
1101 | 1101 | ||
1102 | if (wp && wp->mbox) { | 1102 | if (wp) { |
1103 | kfree(wp->mbox); | 1103 | kfree(wp->mbox); |
1104 | wp->mbox = NULL; | 1104 | wp->mbox = NULL; |
1105 | } | 1105 | } |
@@ -1186,10 +1186,8 @@ static void wanpipe_kill_sock_timer (unsigned long data) | |||
1186 | return; | 1186 | return; |
1187 | } | 1187 | } |
1188 | 1188 | ||
1189 | if (wp_sk(sk)) { | 1189 | kfree(wp_sk(sk)); |
1190 | kfree(wp_sk(sk)); | 1190 | wp_sk(sk) = NULL; |
1191 | wp_sk(sk) = NULL; | ||
1192 | } | ||
1193 | 1191 | ||
1194 | if (atomic_read(&sk->sk_refcnt) != 1) { | 1192 | if (atomic_read(&sk->sk_refcnt) != 1) { |
1195 | atomic_set(&sk->sk_refcnt, 1); | 1193 | atomic_set(&sk->sk_refcnt, 1); |
@@ -1219,10 +1217,8 @@ static void wanpipe_kill_sock_accept (struct sock *sk) | |||
1219 | sk->sk_socket = NULL; | 1217 | sk->sk_socket = NULL; |
1220 | 1218 | ||
1221 | 1219 | ||
1222 | if (wp_sk(sk)) { | 1220 | kfree(wp_sk(sk)); |
1223 | kfree(wp_sk(sk)); | 1221 | wp_sk(sk) = NULL; |
1224 | wp_sk(sk) = NULL; | ||
1225 | } | ||
1226 | 1222 | ||
1227 | if (atomic_read(&sk->sk_refcnt) != 1) { | 1223 | if (atomic_read(&sk->sk_refcnt) != 1) { |
1228 | atomic_set(&sk->sk_refcnt, 1); | 1224 | atomic_set(&sk->sk_refcnt, 1); |
@@ -1243,10 +1239,8 @@ static void wanpipe_kill_sock_irq (struct sock *sk) | |||
1243 | 1239 | ||
1244 | sk->sk_socket = NULL; | 1240 | sk->sk_socket = NULL; |
1245 | 1241 | ||
1246 | if (wp_sk(sk)) { | 1242 | kfree(wp_sk(sk)); |
1247 | kfree(wp_sk(sk)); | 1243 | wp_sk(sk) = NULL; |
1248 | wp_sk(sk) = NULL; | ||
1249 | } | ||
1250 | 1244 | ||
1251 | if (atomic_read(&sk->sk_refcnt) != 1) { | 1245 | if (atomic_read(&sk->sk_refcnt) != 1) { |
1252 | atomic_set(&sk->sk_refcnt, 1); | 1246 | atomic_set(&sk->sk_refcnt, 1); |
diff --git a/net/wanrouter/wanmain.c b/net/wanrouter/wanmain.c index 13b650ad22e2..bcf7b3faa76a 100644 --- a/net/wanrouter/wanmain.c +++ b/net/wanrouter/wanmain.c | |||
@@ -714,10 +714,8 @@ static int wanrouter_device_new_if(struct wan_device *wandev, | |||
714 | } | 714 | } |
715 | 715 | ||
716 | /* This code has moved from del_if() function */ | 716 | /* This code has moved from del_if() function */ |
717 | if (dev->priv) { | 717 | kfree(dev->priv); |
718 | kfree(dev->priv); | 718 | dev->priv = NULL; |
719 | dev->priv = NULL; | ||
720 | } | ||
721 | 719 | ||
722 | #ifdef CONFIG_WANPIPE_MULTPPP | 720 | #ifdef CONFIG_WANPIPE_MULTPPP |
723 | if (cnf->config_id == WANCONFIG_MPPP) | 721 | if (cnf->config_id == WANCONFIG_MPPP) |
@@ -851,10 +849,8 @@ static int wanrouter_delete_interface(struct wan_device *wandev, char *name) | |||
851 | 849 | ||
852 | /* Due to new interface linking method using dev->priv, | 850 | /* Due to new interface linking method using dev->priv, |
853 | * this code has moved from del_if() function.*/ | 851 | * this code has moved from del_if() function.*/ |
854 | if (dev->priv){ | 852 | kfree(dev->priv); |
855 | kfree(dev->priv); | 853 | dev->priv=NULL; |
856 | dev->priv=NULL; | ||
857 | } | ||
858 | 854 | ||
859 | unregister_netdev(dev); | 855 | unregister_netdev(dev); |
860 | 856 | ||
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 8b9a4747417d..7cf48aa6c95b 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c | |||
@@ -62,14 +62,10 @@ static void xfrm_state_gc_destroy(struct xfrm_state *x) | |||
62 | { | 62 | { |
63 | if (del_timer(&x->timer)) | 63 | if (del_timer(&x->timer)) |
64 | BUG(); | 64 | BUG(); |
65 | if (x->aalg) | 65 | kfree(x->aalg); |
66 | kfree(x->aalg); | 66 | kfree(x->ealg); |
67 | if (x->ealg) | 67 | kfree(x->calg); |
68 | kfree(x->ealg); | 68 | kfree(x->encap); |
69 | if (x->calg) | ||
70 | kfree(x->calg); | ||
71 | if (x->encap) | ||
72 | kfree(x->encap); | ||
73 | if (x->type) { | 69 | if (x->type) { |
74 | x->type->destructor(x); | 70 | x->type->destructor(x); |
75 | xfrm_put_type(x->type); | 71 | xfrm_put_type(x->type); |