diff options
-rw-r--r-- | arch/Kconfig | 10 | ||||
-rw-r--r-- | include/linux/ptrace.h | 5 | ||||
-rw-r--r-- | include/linux/seccomp.h | 1 | ||||
-rw-r--r-- | kernel/seccomp.c | 16 |
4 files changed, 26 insertions, 6 deletions
diff --git a/arch/Kconfig b/arch/Kconfig index 66aef13f6038..c024b3ed6675 100644 --- a/arch/Kconfig +++ b/arch/Kconfig | |||
@@ -219,15 +219,15 @@ config ARCH_WANT_OLD_COMPAT_IPC | |||
219 | config HAVE_ARCH_SECCOMP_FILTER | 219 | config HAVE_ARCH_SECCOMP_FILTER |
220 | bool | 220 | bool |
221 | help | 221 | help |
222 | This symbol should be selected by an architecure if it provides: | 222 | An arch should select this symbol if it provides all of these things: |
223 | asm/syscall.h: | ||
224 | - syscall_get_arch() | 223 | - syscall_get_arch() |
225 | - syscall_get_arguments() | 224 | - syscall_get_arguments() |
226 | - syscall_rollback() | 225 | - syscall_rollback() |
227 | - syscall_set_return_value() | 226 | - syscall_set_return_value() |
228 | SIGSYS siginfo_t support must be implemented. | 227 | - SIGSYS siginfo_t support |
229 | __secure_computing()/secure_computing()'s return value must be | 228 | - secure_computing is called from a ptrace_event()-safe context |
230 | checked, with -1 resulting in the syscall being skipped. | 229 | - secure_computing return value is checked and a return value of -1 |
230 | results in the system call being skipped immediately. | ||
231 | 231 | ||
232 | config SECCOMP_FILTER | 232 | config SECCOMP_FILTER |
233 | def_bool y | 233 | def_bool y |
diff --git a/include/linux/ptrace.h b/include/linux/ptrace.h index 5c719627c2aa..597e4fdb97fe 100644 --- a/include/linux/ptrace.h +++ b/include/linux/ptrace.h | |||
@@ -58,6 +58,7 @@ | |||
58 | #define PTRACE_EVENT_EXEC 4 | 58 | #define PTRACE_EVENT_EXEC 4 |
59 | #define PTRACE_EVENT_VFORK_DONE 5 | 59 | #define PTRACE_EVENT_VFORK_DONE 5 |
60 | #define PTRACE_EVENT_EXIT 6 | 60 | #define PTRACE_EVENT_EXIT 6 |
61 | #define PTRACE_EVENT_SECCOMP 7 | ||
61 | /* Extended result codes which enabled by means other than options. */ | 62 | /* Extended result codes which enabled by means other than options. */ |
62 | #define PTRACE_EVENT_STOP 128 | 63 | #define PTRACE_EVENT_STOP 128 |
63 | 64 | ||
@@ -69,8 +70,9 @@ | |||
69 | #define PTRACE_O_TRACEEXEC (1 << PTRACE_EVENT_EXEC) | 70 | #define PTRACE_O_TRACEEXEC (1 << PTRACE_EVENT_EXEC) |
70 | #define PTRACE_O_TRACEVFORKDONE (1 << PTRACE_EVENT_VFORK_DONE) | 71 | #define PTRACE_O_TRACEVFORKDONE (1 << PTRACE_EVENT_VFORK_DONE) |
71 | #define PTRACE_O_TRACEEXIT (1 << PTRACE_EVENT_EXIT) | 72 | #define PTRACE_O_TRACEEXIT (1 << PTRACE_EVENT_EXIT) |
73 | #define PTRACE_O_TRACESECCOMP (1 << PTRACE_EVENT_SECCOMP) | ||
72 | 74 | ||
73 | #define PTRACE_O_MASK 0x0000007f | 75 | #define PTRACE_O_MASK 0x000000ff |
74 | 76 | ||
75 | #include <asm/ptrace.h> | 77 | #include <asm/ptrace.h> |
76 | 78 | ||
@@ -98,6 +100,7 @@ | |||
98 | #define PT_TRACE_EXEC PT_EVENT_FLAG(PTRACE_EVENT_EXEC) | 100 | #define PT_TRACE_EXEC PT_EVENT_FLAG(PTRACE_EVENT_EXEC) |
99 | #define PT_TRACE_VFORK_DONE PT_EVENT_FLAG(PTRACE_EVENT_VFORK_DONE) | 101 | #define PT_TRACE_VFORK_DONE PT_EVENT_FLAG(PTRACE_EVENT_VFORK_DONE) |
100 | #define PT_TRACE_EXIT PT_EVENT_FLAG(PTRACE_EVENT_EXIT) | 102 | #define PT_TRACE_EXIT PT_EVENT_FLAG(PTRACE_EVENT_EXIT) |
103 | #define PT_TRACE_SECCOMP PT_EVENT_FLAG(PTRACE_EVENT_SECCOMP) | ||
101 | 104 | ||
102 | /* single stepping state bits (used on ARM and PA-RISC) */ | 105 | /* single stepping state bits (used on ARM and PA-RISC) */ |
103 | #define PT_SINGLESTEP_BIT 31 | 106 | #define PT_SINGLESTEP_BIT 31 |
diff --git a/include/linux/seccomp.h b/include/linux/seccomp.h index 317ccb78cf40..5818e869651b 100644 --- a/include/linux/seccomp.h +++ b/include/linux/seccomp.h | |||
@@ -21,6 +21,7 @@ | |||
21 | #define SECCOMP_RET_KILL 0x00000000U /* kill the task immediately */ | 21 | #define SECCOMP_RET_KILL 0x00000000U /* kill the task immediately */ |
22 | #define SECCOMP_RET_TRAP 0x00030000U /* disallow and force a SIGSYS */ | 22 | #define SECCOMP_RET_TRAP 0x00030000U /* disallow and force a SIGSYS */ |
23 | #define SECCOMP_RET_ERRNO 0x00050000U /* returns an errno */ | 23 | #define SECCOMP_RET_ERRNO 0x00050000U /* returns an errno */ |
24 | #define SECCOMP_RET_TRACE 0x7ff00000U /* pass to a tracer or disallow */ | ||
24 | #define SECCOMP_RET_ALLOW 0x7fff0000U /* allow */ | 25 | #define SECCOMP_RET_ALLOW 0x7fff0000U /* allow */ |
25 | 26 | ||
26 | /* Masks for the return value sections. */ | 27 | /* Masks for the return value sections. */ |
diff --git a/kernel/seccomp.c b/kernel/seccomp.c index 9c3830692a08..d9db6ec46bc9 100644 --- a/kernel/seccomp.c +++ b/kernel/seccomp.c | |||
@@ -24,6 +24,7 @@ | |||
24 | #ifdef CONFIG_SECCOMP_FILTER | 24 | #ifdef CONFIG_SECCOMP_FILTER |
25 | #include <asm/syscall.h> | 25 | #include <asm/syscall.h> |
26 | #include <linux/filter.h> | 26 | #include <linux/filter.h> |
27 | #include <linux/ptrace.h> | ||
27 | #include <linux/security.h> | 28 | #include <linux/security.h> |
28 | #include <linux/slab.h> | 29 | #include <linux/slab.h> |
29 | #include <linux/tracehook.h> | 30 | #include <linux/tracehook.h> |
@@ -408,6 +409,21 @@ int __secure_computing(int this_syscall) | |||
408 | /* Let the filter pass back 16 bits of data. */ | 409 | /* Let the filter pass back 16 bits of data. */ |
409 | seccomp_send_sigsys(this_syscall, data); | 410 | seccomp_send_sigsys(this_syscall, data); |
410 | goto skip; | 411 | goto skip; |
412 | case SECCOMP_RET_TRACE: | ||
413 | /* Skip these calls if there is no tracer. */ | ||
414 | if (!ptrace_event_enabled(current, PTRACE_EVENT_SECCOMP)) | ||
415 | goto skip; | ||
416 | /* Allow the BPF to provide the event message */ | ||
417 | ptrace_event(PTRACE_EVENT_SECCOMP, data); | ||
418 | /* | ||
419 | * The delivery of a fatal signal during event | ||
420 | * notification may silently skip tracer notification. | ||
421 | * Terminating the task now avoids executing a system | ||
422 | * call that may not be intended. | ||
423 | */ | ||
424 | if (fatal_signal_pending(current)) | ||
425 | break; | ||
426 | return 0; | ||
411 | case SECCOMP_RET_ALLOW: | 427 | case SECCOMP_RET_ALLOW: |
412 | return 0; | 428 | return 0; |
413 | case SECCOMP_RET_KILL: | 429 | case SECCOMP_RET_KILL: |