aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--include/linux/interrupt.h4
-rw-r--r--include/linux/sched.h10
-rw-r--r--kernel/exit.c2
-rw-r--r--kernel/irq/manage.c68
4 files changed, 35 insertions, 49 deletions
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index c91171599cb6..e68a8e53bb59 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -142,8 +142,6 @@ request_any_context_irq(unsigned int irq, irq_handler_t handler,
142extern int __must_check 142extern int __must_check
143request_percpu_irq(unsigned int irq, irq_handler_t handler, 143request_percpu_irq(unsigned int irq, irq_handler_t handler,
144 const char *devname, void __percpu *percpu_dev_id); 144 const char *devname, void __percpu *percpu_dev_id);
145
146extern void exit_irq_thread(void);
147#else 145#else
148 146
149extern int __must_check 147extern int __must_check
@@ -177,8 +175,6 @@ request_percpu_irq(unsigned int irq, irq_handler_t handler,
177{ 175{
178 return request_irq(irq, handler, 0, devname, percpu_dev_id); 176 return request_irq(irq, handler, 0, devname, percpu_dev_id);
179} 177}
180
181static inline void exit_irq_thread(void) { }
182#endif 178#endif
183 179
184extern void free_irq(unsigned int, void *); 180extern void free_irq(unsigned int, void *);
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 7930131abc1a..da013853a622 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1301,11 +1301,6 @@ struct task_struct {
1301 unsigned sched_reset_on_fork:1; 1301 unsigned sched_reset_on_fork:1;
1302 unsigned sched_contributes_to_load:1; 1302 unsigned sched_contributes_to_load:1;
1303 1303
1304#ifdef CONFIG_GENERIC_HARDIRQS
1305 /* IRQ handler threads */
1306 unsigned irq_thread:1;
1307#endif
1308
1309 pid_t pid; 1304 pid_t pid;
1310 pid_t tgid; 1305 pid_t tgid;
1311 1306
@@ -1313,10 +1308,9 @@ struct task_struct {
1313 /* Canary value for the -fstack-protector gcc feature */ 1308 /* Canary value for the -fstack-protector gcc feature */
1314 unsigned long stack_canary; 1309 unsigned long stack_canary;
1315#endif 1310#endif
1316 1311 /*
1317 /*
1318 * pointers to (original) parent process, youngest child, younger sibling, 1312 * pointers to (original) parent process, youngest child, younger sibling,
1319 * older sibling, respectively. (p->father can be replaced with 1313 * older sibling, respectively. (p->father can be replaced with
1320 * p->real_parent->pid) 1314 * p->real_parent->pid)
1321 */ 1315 */
1322 struct task_struct __rcu *real_parent; /* real parent process */ 1316 struct task_struct __rcu *real_parent; /* real parent process */
diff --git a/kernel/exit.c b/kernel/exit.c
index 3d93325e0b1a..3ecd096e5d4d 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -954,8 +954,6 @@ void do_exit(long code)
954 954
955 exit_task_work(tsk); 955 exit_task_work(tsk);
956 956
957 exit_irq_thread();
958
959 if (unlikely(in_atomic())) 957 if (unlikely(in_atomic()))
960 printk(KERN_INFO "note: %s[%d] exited with preempt_count %d\n", 958 printk(KERN_INFO "note: %s[%d] exited with preempt_count %d\n",
961 current->comm, task_pid_nr(current), 959 current->comm, task_pid_nr(current),
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index bb32326afe87..4d1f8f897414 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -14,6 +14,7 @@
14#include <linux/interrupt.h> 14#include <linux/interrupt.h>
15#include <linux/slab.h> 15#include <linux/slab.h>
16#include <linux/sched.h> 16#include <linux/sched.h>
17#include <linux/task_work.h>
17 18
18#include "internals.h" 19#include "internals.h"
19 20
@@ -773,11 +774,39 @@ static void wake_threads_waitq(struct irq_desc *desc)
773 wake_up(&desc->wait_for_threads); 774 wake_up(&desc->wait_for_threads);
774} 775}
775 776
777static void irq_thread_dtor(struct task_work *unused)
778{
779 struct task_struct *tsk = current;
780 struct irq_desc *desc;
781 struct irqaction *action;
782
783 if (WARN_ON_ONCE(!(current->flags & PF_EXITING)))
784 return;
785
786 action = kthread_data(tsk);
787
788 pr_err("genirq: exiting task \"%s\" (%d) is an active IRQ thread (irq %d)\n",
789 tsk->comm ? tsk->comm : "", tsk->pid, action->irq);
790
791
792 desc = irq_to_desc(action->irq);
793 /*
794 * If IRQTF_RUNTHREAD is set, we need to decrement
795 * desc->threads_active and wake possible waiters.
796 */
797 if (test_and_clear_bit(IRQTF_RUNTHREAD, &action->thread_flags))
798 wake_threads_waitq(desc);
799
800 /* Prevent a stale desc->threads_oneshot */
801 irq_finalize_oneshot(desc, action);
802}
803
776/* 804/*
777 * Interrupt handler thread 805 * Interrupt handler thread
778 */ 806 */
779static int irq_thread(void *data) 807static int irq_thread(void *data)
780{ 808{
809 struct task_work on_exit_work;
781 static const struct sched_param param = { 810 static const struct sched_param param = {
782 .sched_priority = MAX_USER_RT_PRIO/2, 811 .sched_priority = MAX_USER_RT_PRIO/2,
783 }; 812 };
@@ -793,7 +822,9 @@ static int irq_thread(void *data)
793 handler_fn = irq_thread_fn; 822 handler_fn = irq_thread_fn;
794 823
795 sched_setscheduler(current, SCHED_FIFO, &param); 824 sched_setscheduler(current, SCHED_FIFO, &param);
796 current->irq_thread = 1; 825
826 init_task_work(&on_exit_work, irq_thread_dtor, NULL);
827 task_work_add(current, &on_exit_work, false);
797 828
798 while (!irq_wait_for_interrupt(action)) { 829 while (!irq_wait_for_interrupt(action)) {
799 irqreturn_t action_ret; 830 irqreturn_t action_ret;
@@ -815,44 +846,11 @@ static int irq_thread(void *data)
815 * cannot touch the oneshot mask at this point anymore as 846 * cannot touch the oneshot mask at this point anymore as
816 * __setup_irq() might have given out currents thread_mask 847 * __setup_irq() might have given out currents thread_mask
817 * again. 848 * again.
818 *
819 * Clear irq_thread. Otherwise exit_irq_thread() would make
820 * fuzz about an active irq thread going into nirvana.
821 */ 849 */
822 current->irq_thread = 0; 850 task_work_cancel(current, irq_thread_dtor);
823 return 0; 851 return 0;
824} 852}
825 853
826/*
827 * Called from do_exit()
828 */
829void exit_irq_thread(void)
830{
831 struct task_struct *tsk = current;
832 struct irq_desc *desc;
833 struct irqaction *action;
834
835 if (!tsk->irq_thread)
836 return;
837
838 action = kthread_data(tsk);
839
840 pr_err("genirq: exiting task \"%s\" (%d) is an active IRQ thread (irq %d)\n",
841 tsk->comm ? tsk->comm : "", tsk->pid, action->irq);
842
843 desc = irq_to_desc(action->irq);
844
845 /*
846 * If IRQTF_RUNTHREAD is set, we need to decrement
847 * desc->threads_active and wake possible waiters.
848 */
849 if (test_and_clear_bit(IRQTF_RUNTHREAD, &action->thread_flags))
850 wake_threads_waitq(desc);
851
852 /* Prevent a stale desc->threads_oneshot */
853 irq_finalize_oneshot(desc, action);
854}
855
856static void irq_setup_forced_threading(struct irqaction *new) 854static void irq_setup_forced_threading(struct irqaction *new)
857{ 855{
858 if (!force_irqthreads) 856 if (!force_irqthreads)