diff options
-rw-r--r-- | Documentation/power/runtime_pm.txt | 10 | ||||
-rw-r--r-- | drivers/base/power/runtime.c | 10 |
2 files changed, 13 insertions, 7 deletions
diff --git a/Documentation/power/runtime_pm.txt b/Documentation/power/runtime_pm.txt index 14dd3c6ad97e..4ce5450ab6e8 100644 --- a/Documentation/power/runtime_pm.txt +++ b/Documentation/power/runtime_pm.txt | |||
@@ -54,11 +54,10 @@ referred to as subsystem-level callbacks in what follows. | |||
54 | By default, the callbacks are always invoked in process context with interrupts | 54 | By default, the callbacks are always invoked in process context with interrupts |
55 | enabled. However, subsystems can use the pm_runtime_irq_safe() helper function | 55 | enabled. However, subsystems can use the pm_runtime_irq_safe() helper function |
56 | to tell the PM core that a device's ->runtime_suspend() and ->runtime_resume() | 56 | to tell the PM core that a device's ->runtime_suspend() and ->runtime_resume() |
57 | callbacks should be invoked in atomic context with interrupts disabled | 57 | callbacks should be invoked in atomic context with interrupts disabled. |
58 | (->runtime_idle() is still invoked the default way). This implies that these | 58 | This implies that these callback routines must not block or sleep, but it also |
59 | callback routines must not block or sleep, but it also means that the | 59 | means that the synchronous helper functions listed at the end of Section 4 can |
60 | synchronous helper functions listed at the end of Section 4 can be used within | 60 | be used within an interrupt handler or in an atomic context. |
61 | an interrupt handler or in an atomic context. | ||
62 | 61 | ||
63 | The subsystem-level suspend callback is _entirely_ _responsible_ for handling | 62 | The subsystem-level suspend callback is _entirely_ _responsible_ for handling |
64 | the suspend of the device as appropriate, which may, but need not include | 63 | the suspend of the device as appropriate, which may, but need not include |
@@ -483,6 +482,7 @@ pm_runtime_suspend() | |||
483 | pm_runtime_autosuspend() | 482 | pm_runtime_autosuspend() |
484 | pm_runtime_resume() | 483 | pm_runtime_resume() |
485 | pm_runtime_get_sync() | 484 | pm_runtime_get_sync() |
485 | pm_runtime_put_sync() | ||
486 | pm_runtime_put_sync_suspend() | 486 | pm_runtime_put_sync_suspend() |
487 | 487 | ||
488 | 5. Runtime PM Initialization, Device Probing and Removal | 488 | 5. Runtime PM Initialization, Device Probing and Removal |
diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index 8dc247c974af..acb3f83b8079 100644 --- a/drivers/base/power/runtime.c +++ b/drivers/base/power/runtime.c | |||
@@ -226,11 +226,17 @@ static int rpm_idle(struct device *dev, int rpmflags) | |||
226 | callback = NULL; | 226 | callback = NULL; |
227 | 227 | ||
228 | if (callback) { | 228 | if (callback) { |
229 | spin_unlock_irq(&dev->power.lock); | 229 | if (dev->power.irq_safe) |
230 | spin_unlock(&dev->power.lock); | ||
231 | else | ||
232 | spin_unlock_irq(&dev->power.lock); | ||
230 | 233 | ||
231 | callback(dev); | 234 | callback(dev); |
232 | 235 | ||
233 | spin_lock_irq(&dev->power.lock); | 236 | if (dev->power.irq_safe) |
237 | spin_lock(&dev->power.lock); | ||
238 | else | ||
239 | spin_lock_irq(&dev->power.lock); | ||
234 | } | 240 | } |
235 | 241 | ||
236 | dev->power.idle_notification = false; | 242 | dev->power.idle_notification = false; |