1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/media/video/gspca/sunplus.c b/drivers/media/video/gspca/sunplus.c
index ffbe3f625ddb..aa8f995ce04e 100644
--- a/drivers/media/video/gspca/sunplus.c
+++ b/drivers/media/video/gspca/sunplus.c
@@ -32,7 +32,7 @@ MODULE_LICENSE("GPL");
 struct sd {
        struct gspca_dev gspca_dev;     /* !! must be the first item */
-        u8 brightness;
+        s8 brightness;
        u8 contrast;
        u8 colors;
        u8 autogain;
@@ -73,8 +73,8 @@ static struct ctrl sd_ctrls[] = {
                .id      = V4L2_CID_BRIGHTNESS,
                .type    = V4L2_CTRL_TYPE_INTEGER,
                .name    = "Brightness",
-                .minimum = 0,
+                .minimum = -128,
-                .maximum = 0xff,
+                .maximum = 127,
                .step    = 1,
 #define BRIGHTNESS_DEF 0
                .default_value = BRIGHTNESS_DEF,

diff --git a/drivers/media/video/gspca/sunplus.c b/drivers/media/video/gspca/sunplus.c index ffbe3f625ddb..aa8f995ce04e 100644 --- a/drivers/media/video/gspca/sunplus.c +++ b/drivers/media/video/gspca/sunplus.c
@@ -32,7 +32,7 @@ MODULE_LICENSE("GPL");
32	struct sd {	32	struct sd {
33	struct gspca_dev gspca_dev; /* !! must be the first item */	33	struct gspca_dev gspca_dev; /* !! must be the first item */
34		34
35	u8 brightness;	35	s8 brightness;
36	u8 contrast;	36	u8 contrast;
37	u8 colors;	37	u8 colors;
38	u8 autogain;	38	u8 autogain;
@@ -73,8 +73,8 @@ static struct ctrl sd_ctrls[] = {
73	.id = V4L2_CID_BRIGHTNESS,	73	.id = V4L2_CID_BRIGHTNESS,
74	.type = V4L2_CTRL_TYPE_INTEGER,	74	.type = V4L2_CTRL_TYPE_INTEGER,
75	.name = "Brightness",	75	.name = "Brightness",
76	.minimum = 0,	76	.minimum = -128,
77	.maximum = 0xff,	77	.maximum = 127,
78	.step = 1,	78	.step = 1,
79	#define BRIGHTNESS_DEF 0	79	#define BRIGHTNESS_DEF 0
80	.default_value = BRIGHTNESS_DEF,	80	.default_value = BRIGHTNESS_DEF,