diff options
| -rw-r--r-- | drivers/infiniband/hw/ipath/ipath_driver.c | 4 | ||||
| -rw-r--r-- | drivers/infiniband/hw/ipath/ipath_file_ops.c | 5 | ||||
| -rw-r--r-- | drivers/infiniband/hw/ipath/ipath_iba6110.c | 3 | ||||
| -rw-r--r-- | drivers/infiniband/hw/ipath/ipath_iba6120.c | 6 | ||||
| -rw-r--r-- | drivers/infiniband/hw/ipath/ipath_init_chip.c | 3 | ||||
| -rw-r--r-- | drivers/infiniband/hw/ipath/ipath_intr.c | 3 | ||||
| -rw-r--r-- | drivers/infiniband/hw/ipath/ipath_sysfs.c | 3 |
7 files changed, 9 insertions, 18 deletions
diff --git a/drivers/infiniband/hw/ipath/ipath_driver.c b/drivers/infiniband/hw/ipath/ipath_driver.c index 1aeddb48e355..ae7f21a0cdc0 100644 --- a/drivers/infiniband/hw/ipath/ipath_driver.c +++ b/drivers/infiniband/hw/ipath/ipath_driver.c | |||
| @@ -1825,8 +1825,6 @@ void ipath_write_kreg_port(const struct ipath_devdata *dd, ipath_kreg regno, | |||
| 1825 | */ | 1825 | */ |
| 1826 | void ipath_shutdown_device(struct ipath_devdata *dd) | 1826 | void ipath_shutdown_device(struct ipath_devdata *dd) |
| 1827 | { | 1827 | { |
| 1828 | u64 val; | ||
| 1829 | |||
| 1830 | ipath_dbg("Shutting down the device\n"); | 1828 | ipath_dbg("Shutting down the device\n"); |
| 1831 | 1829 | ||
| 1832 | dd->ipath_flags |= IPATH_LINKUNK; | 1830 | dd->ipath_flags |= IPATH_LINKUNK; |
| @@ -1849,7 +1847,7 @@ void ipath_shutdown_device(struct ipath_devdata *dd) | |||
| 1849 | */ | 1847 | */ |
| 1850 | ipath_write_kreg(dd, dd->ipath_kregs->kr_sendctrl, 0ULL); | 1848 | ipath_write_kreg(dd, dd->ipath_kregs->kr_sendctrl, 0ULL); |
| 1851 | /* flush it */ | 1849 | /* flush it */ |
| 1852 | val = ipath_read_kreg64(dd, dd->ipath_kregs->kr_scratch); | 1850 | ipath_read_kreg64(dd, dd->ipath_kregs->kr_scratch); |
| 1853 | /* | 1851 | /* |
| 1854 | * enough for anything that's going to trickle out to have actually | 1852 | * enough for anything that's going to trickle out to have actually |
| 1855 | * done so. | 1853 | * done so. |
diff --git a/drivers/infiniband/hw/ipath/ipath_file_ops.c b/drivers/infiniband/hw/ipath/ipath_file_ops.c index 340f27e3ebff..b932bcb67a5e 100644 --- a/drivers/infiniband/hw/ipath/ipath_file_ops.c +++ b/drivers/infiniband/hw/ipath/ipath_file_ops.c | |||
| @@ -699,7 +699,6 @@ static int ipath_manage_rcvq(struct ipath_portdata *pd, unsigned subport, | |||
| 699 | int start_stop) | 699 | int start_stop) |
| 700 | { | 700 | { |
| 701 | struct ipath_devdata *dd = pd->port_dd; | 701 | struct ipath_devdata *dd = pd->port_dd; |
| 702 | u64 tval; | ||
| 703 | 702 | ||
| 704 | ipath_cdbg(PROC, "%sabling rcv for unit %u port %u:%u\n", | 703 | ipath_cdbg(PROC, "%sabling rcv for unit %u port %u:%u\n", |
| 705 | start_stop ? "en" : "dis", dd->ipath_unit, | 704 | start_stop ? "en" : "dis", dd->ipath_unit, |
| @@ -729,7 +728,7 @@ static int ipath_manage_rcvq(struct ipath_portdata *pd, unsigned subport, | |||
| 729 | ipath_write_kreg(dd, dd->ipath_kregs->kr_rcvctrl, | 728 | ipath_write_kreg(dd, dd->ipath_kregs->kr_rcvctrl, |
| 730 | dd->ipath_rcvctrl); | 729 | dd->ipath_rcvctrl); |
| 731 | /* now be sure chip saw it before we return */ | 730 | /* now be sure chip saw it before we return */ |
| 732 | tval = ipath_read_kreg64(dd, dd->ipath_kregs->kr_scratch); | 731 | ipath_read_kreg64(dd, dd->ipath_kregs->kr_scratch); |
| 733 | if (start_stop) { | 732 | if (start_stop) { |
| 734 | /* | 733 | /* |
| 735 | * And try to be sure that tail reg update has happened too. | 734 | * And try to be sure that tail reg update has happened too. |
| @@ -738,7 +737,7 @@ static int ipath_manage_rcvq(struct ipath_portdata *pd, unsigned subport, | |||
| 738 | * in memory copy, since we could overwrite an update by the | 737 | * in memory copy, since we could overwrite an update by the |
| 739 | * chip if we did. | 738 | * chip if we did. |
| 740 | */ | 739 | */ |
| 741 | tval = ipath_read_ureg32(dd, ur_rcvhdrtail, pd->port_port); | 740 | ipath_read_ureg32(dd, ur_rcvhdrtail, pd->port_port); |
| 742 | } | 741 | } |
| 743 | /* always; new head should be equal to new tail; see above */ | 742 | /* always; new head should be equal to new tail; see above */ |
| 744 | bail: | 743 | bail: |
diff --git a/drivers/infiniband/hw/ipath/ipath_iba6110.c b/drivers/infiniband/hw/ipath/ipath_iba6110.c index e57c7a351cb5..7468477ba837 100644 --- a/drivers/infiniband/hw/ipath/ipath_iba6110.c +++ b/drivers/infiniband/hw/ipath/ipath_iba6110.c | |||
| @@ -1447,7 +1447,7 @@ static void ipath_ht_tidtemplate(struct ipath_devdata *dd) | |||
| 1447 | static int ipath_ht_early_init(struct ipath_devdata *dd) | 1447 | static int ipath_ht_early_init(struct ipath_devdata *dd) |
| 1448 | { | 1448 | { |
| 1449 | u32 __iomem *piobuf; | 1449 | u32 __iomem *piobuf; |
| 1450 | u32 pioincr, val32, egrsize; | 1450 | u32 pioincr, val32; |
| 1451 | int i; | 1451 | int i; |
| 1452 | 1452 | ||
| 1453 | /* | 1453 | /* |
| @@ -1467,7 +1467,6 @@ static int ipath_ht_early_init(struct ipath_devdata *dd) | |||
| 1467 | * errors interrupts if we ever see one). | 1467 | * errors interrupts if we ever see one). |
| 1468 | */ | 1468 | */ |
| 1469 | dd->ipath_rcvegrbufsize = dd->ipath_piosize2k; | 1469 | dd->ipath_rcvegrbufsize = dd->ipath_piosize2k; |
| 1470 | egrsize = dd->ipath_rcvegrbufsize; | ||
| 1471 | 1470 | ||
| 1472 | /* | 1471 | /* |
| 1473 | * the min() check here is currently a nop, but it may not | 1472 | * the min() check here is currently a nop, but it may not |
diff --git a/drivers/infiniband/hw/ipath/ipath_iba6120.c b/drivers/infiniband/hw/ipath/ipath_iba6120.c index 6af89683f710..397da3483af1 100644 --- a/drivers/infiniband/hw/ipath/ipath_iba6120.c +++ b/drivers/infiniband/hw/ipath/ipath_iba6120.c | |||
| @@ -602,7 +602,7 @@ static void ipath_pe_init_hwerrors(struct ipath_devdata *dd) | |||
| 602 | */ | 602 | */ |
| 603 | static int ipath_pe_bringup_serdes(struct ipath_devdata *dd) | 603 | static int ipath_pe_bringup_serdes(struct ipath_devdata *dd) |
| 604 | { | 604 | { |
| 605 | u64 val, tmp, config1, prev_val; | 605 | u64 val, config1, prev_val; |
| 606 | int ret = 0; | 606 | int ret = 0; |
| 607 | 607 | ||
| 608 | ipath_dbg("Trying to bringup serdes\n"); | 608 | ipath_dbg("Trying to bringup serdes\n"); |
| @@ -633,7 +633,7 @@ static int ipath_pe_bringup_serdes(struct ipath_devdata *dd) | |||
| 633 | | INFINIPATH_SERDC0_L1PWR_DN; | 633 | | INFINIPATH_SERDC0_L1PWR_DN; |
| 634 | ipath_write_kreg(dd, dd->ipath_kregs->kr_serdesconfig0, val); | 634 | ipath_write_kreg(dd, dd->ipath_kregs->kr_serdesconfig0, val); |
| 635 | /* be sure chip saw it */ | 635 | /* be sure chip saw it */ |
| 636 | tmp = ipath_read_kreg64(dd, dd->ipath_kregs->kr_scratch); | 636 | ipath_read_kreg64(dd, dd->ipath_kregs->kr_scratch); |
| 637 | udelay(5); /* need pll reset set at least for a bit */ | 637 | udelay(5); /* need pll reset set at least for a bit */ |
| 638 | /* | 638 | /* |
| 639 | * after PLL is reset, set the per-lane Resets and TxIdle and | 639 | * after PLL is reset, set the per-lane Resets and TxIdle and |
| @@ -647,7 +647,7 @@ static int ipath_pe_bringup_serdes(struct ipath_devdata *dd) | |||
| 647 | "and txidle (%llx)\n", (unsigned long long) val); | 647 | "and txidle (%llx)\n", (unsigned long long) val); |
| 648 | ipath_write_kreg(dd, dd->ipath_kregs->kr_serdesconfig0, val); | 648 | ipath_write_kreg(dd, dd->ipath_kregs->kr_serdesconfig0, val); |
| 649 | /* be sure chip saw it */ | 649 | /* be sure chip saw it */ |
| 650 | tmp = ipath_read_kreg64(dd, dd->ipath_kregs->kr_scratch); | 650 | ipath_read_kreg64(dd, dd->ipath_kregs->kr_scratch); |
| 651 | /* need PLL reset clear for at least 11 usec before lane | 651 | /* need PLL reset clear for at least 11 usec before lane |
| 652 | * resets cleared; give it a few more to be sure */ | 652 | * resets cleared; give it a few more to be sure */ |
| 653 | udelay(15); | 653 | udelay(15); |
diff --git a/drivers/infiniband/hw/ipath/ipath_init_chip.c b/drivers/infiniband/hw/ipath/ipath_init_chip.c index d819cca524cd..d4f6b5239ef8 100644 --- a/drivers/infiniband/hw/ipath/ipath_init_chip.c +++ b/drivers/infiniband/hw/ipath/ipath_init_chip.c | |||
| @@ -347,10 +347,9 @@ done: | |||
| 347 | static int init_chip_reset(struct ipath_devdata *dd, | 347 | static int init_chip_reset(struct ipath_devdata *dd, |
| 348 | struct ipath_portdata **pdp) | 348 | struct ipath_portdata **pdp) |
| 349 | { | 349 | { |
| 350 | struct ipath_portdata *pd; | ||
| 351 | u32 rtmp; | 350 | u32 rtmp; |
| 352 | 351 | ||
| 353 | *pdp = pd = dd->ipath_pd[0]; | 352 | *pdp = dd->ipath_pd[0]; |
| 354 | /* ensure chip does no sends or receives while we re-initialize */ | 353 | /* ensure chip does no sends or receives while we re-initialize */ |
| 355 | dd->ipath_control = dd->ipath_sendctrl = dd->ipath_rcvctrl = 0U; | 354 | dd->ipath_control = dd->ipath_sendctrl = dd->ipath_rcvctrl = 0U; |
| 356 | ipath_write_kreg(dd, dd->ipath_kregs->kr_rcvctrl, 0); | 355 | ipath_write_kreg(dd, dd->ipath_kregs->kr_rcvctrl, 0); |
diff --git a/drivers/infiniband/hw/ipath/ipath_intr.c b/drivers/infiniband/hw/ipath/ipath_intr.c index 5652a550d442..72b9e279d19d 100644 --- a/drivers/infiniband/hw/ipath/ipath_intr.c +++ b/drivers/infiniband/hw/ipath/ipath_intr.c | |||
| @@ -598,10 +598,9 @@ static int handle_errors(struct ipath_devdata *dd, ipath_err_t errs) | |||
| 598 | * on close | 598 | * on close |
| 599 | */ | 599 | */ |
| 600 | if (errs & INFINIPATH_E_RRCVHDRFULL) { | 600 | if (errs & INFINIPATH_E_RRCVHDRFULL) { |
| 601 | int any; | ||
| 602 | u32 hd, tl; | 601 | u32 hd, tl; |
| 603 | ipath_stats.sps_hdrqfull++; | 602 | ipath_stats.sps_hdrqfull++; |
| 604 | for (any = i = 0; i < dd->ipath_cfgports; i++) { | 603 | for (i = 0; i < dd->ipath_cfgports; i++) { |
| 605 | struct ipath_portdata *pd = dd->ipath_pd[i]; | 604 | struct ipath_portdata *pd = dd->ipath_pd[i]; |
| 606 | if (i == 0) { | 605 | if (i == 0) { |
| 607 | hd = dd->ipath_port0head; | 606 | hd = dd->ipath_port0head; |
diff --git a/drivers/infiniband/hw/ipath/ipath_sysfs.c b/drivers/infiniband/hw/ipath/ipath_sysfs.c index 182de34f9f47..ffa6318ad0cc 100644 --- a/drivers/infiniband/hw/ipath/ipath_sysfs.c +++ b/drivers/infiniband/hw/ipath/ipath_sysfs.c | |||
| @@ -215,7 +215,6 @@ static ssize_t store_mlid(struct device *dev, | |||
| 215 | size_t count) | 215 | size_t count) |
| 216 | { | 216 | { |
| 217 | struct ipath_devdata *dd = dev_get_drvdata(dev); | 217 | struct ipath_devdata *dd = dev_get_drvdata(dev); |
| 218 | int unit; | ||
| 219 | u16 mlid; | 218 | u16 mlid; |
| 220 | int ret; | 219 | int ret; |
| 221 | 220 | ||
| @@ -223,8 +222,6 @@ static ssize_t store_mlid(struct device *dev, | |||
| 223 | if (ret < 0 || mlid < IPATH_MULTICAST_LID_BASE) | 222 | if (ret < 0 || mlid < IPATH_MULTICAST_LID_BASE) |
| 224 | goto invalid; | 223 | goto invalid; |
| 225 | 224 | ||
| 226 | unit = dd->ipath_unit; | ||
| 227 | |||
| 228 | dd->ipath_mlid = mlid; | 225 | dd->ipath_mlid = mlid; |
| 229 | 226 | ||
| 230 | goto bail; | 227 | goto bail; |
