diff options
-rw-r--r-- | Documentation/feature-removal-schedule.txt | 17 | ||||
-rw-r--r-- | drivers/i2c/i2c-core.c | 28 |
2 files changed, 41 insertions, 4 deletions
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt index 30f3c8c9c12a..f2024df7ebe5 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt | |||
@@ -226,6 +226,23 @@ Who: Jean Delvare <khali@linux-fr.org> | |||
226 | 226 | ||
227 | --------------------------- | 227 | --------------------------- |
228 | 228 | ||
229 | What: i2c_adapter.dev | ||
230 | i2c_adapter.list | ||
231 | When: July 2007 | ||
232 | Why: Superfluous, given i2c_adapter.class_dev: | ||
233 | * The "dev" was a stand-in for the physical device node that legacy | ||
234 | drivers would not have; but now it's almost always present. Any | ||
235 | remaining legacy drivers must upgrade (they now trigger warnings). | ||
236 | * The "list" duplicates class device children. | ||
237 | The delay in removing this is so upgraded lm_sensors and libsensors | ||
238 | can get deployed. (Removal causes minor changes in the sysfs layout, | ||
239 | notably the location of the adapter type name and parenting the i2c | ||
240 | client hardware directly from their controller.) | ||
241 | Who: Jean Delvare <khali@linux-fr.org>, | ||
242 | David Brownell <dbrownell@users.sourceforge.net> | ||
243 | |||
244 | --------------------------- | ||
245 | |||
229 | What: IPv4 only connection tracking/NAT/helpers | 246 | What: IPv4 only connection tracking/NAT/helpers |
230 | When: 2.6.22 | 247 | When: 2.6.22 |
231 | Why: The new layer 3 independant connection tracking replaces the old | 248 | Why: The new layer 3 independant connection tracking replaces the old |
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 3e31f1d265c9..b05378a3d673 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c | |||
@@ -95,16 +95,32 @@ struct device_driver i2c_adapter_driver = { | |||
95 | .bus = &i2c_bus_type, | 95 | .bus = &i2c_bus_type, |
96 | }; | 96 | }; |
97 | 97 | ||
98 | /* ------------------------------------------------------------------------- */ | ||
99 | |||
100 | /* I2C bus adapters -- one roots each I2C or SMBUS segment */ | ||
101 | |||
98 | static void i2c_adapter_class_dev_release(struct class_device *dev) | 102 | static void i2c_adapter_class_dev_release(struct class_device *dev) |
99 | { | 103 | { |
100 | struct i2c_adapter *adap = class_dev_to_i2c_adapter(dev); | 104 | struct i2c_adapter *adap = class_dev_to_i2c_adapter(dev); |
101 | complete(&adap->class_dev_released); | 105 | complete(&adap->class_dev_released); |
102 | } | 106 | } |
103 | 107 | ||
108 | static ssize_t i2c_adapter_show_name(struct class_device *cdev, char *buf) | ||
109 | { | ||
110 | struct i2c_adapter *adap = class_dev_to_i2c_adapter(cdev); | ||
111 | return sprintf(buf, "%s\n", adap->name); | ||
112 | } | ||
113 | |||
114 | static struct class_device_attribute i2c_adapter_attrs[] = { | ||
115 | __ATTR(name, S_IRUGO, i2c_adapter_show_name, NULL), | ||
116 | { }, | ||
117 | }; | ||
118 | |||
104 | struct class i2c_adapter_class = { | 119 | struct class i2c_adapter_class = { |
105 | .owner = THIS_MODULE, | 120 | .owner = THIS_MODULE, |
106 | .name = "i2c-adapter", | 121 | .name = "i2c-adapter", |
107 | .release = &i2c_adapter_class_dev_release, | 122 | .class_dev_attrs = i2c_adapter_attrs, |
123 | .release = &i2c_adapter_class_dev_release, | ||
108 | }; | 124 | }; |
109 | 125 | ||
110 | static ssize_t show_adapter_name(struct device *dev, struct device_attribute *attr, char *buf) | 126 | static ssize_t show_adapter_name(struct device *dev, struct device_attribute *attr, char *buf) |
@@ -175,8 +191,12 @@ int i2c_add_adapter(struct i2c_adapter *adap) | |||
175 | * If the parent pointer is not set up, | 191 | * If the parent pointer is not set up, |
176 | * we add this adapter to the host bus. | 192 | * we add this adapter to the host bus. |
177 | */ | 193 | */ |
178 | if (adap->dev.parent == NULL) | 194 | if (adap->dev.parent == NULL) { |
179 | adap->dev.parent = &platform_bus; | 195 | adap->dev.parent = &platform_bus; |
196 | printk(KERN_WARNING "**WARNING** I2C adapter driver [%s] " | ||
197 | "forgot to specify physical device; fix it!\n", | ||
198 | adap->name); | ||
199 | } | ||
180 | sprintf(adap->dev.bus_id, "i2c-%d", adap->nr); | 200 | sprintf(adap->dev.bus_id, "i2c-%d", adap->nr); |
181 | adap->dev.driver = &i2c_adapter_driver; | 201 | adap->dev.driver = &i2c_adapter_driver; |
182 | adap->dev.release = &i2c_adapter_dev_release; | 202 | adap->dev.release = &i2c_adapter_dev_release; |