aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--block/cfq-iosched.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 4ab240c875df..829d87d3e00f 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -454,9 +454,9 @@ static inline bool cfq_slice_used(struct cfq_queue *cfqq)
454 * behind the head is penalized and only allowed to a certain extent. 454 * behind the head is penalized and only allowed to a certain extent.
455 */ 455 */
456static struct request * 456static struct request *
457cfq_choose_req(struct cfq_data *cfqd, struct request *rq1, struct request *rq2) 457cfq_choose_req(struct cfq_data *cfqd, struct request *rq1, struct request *rq2, sector_t last)
458{ 458{
459 sector_t last, s1, s2, d1 = 0, d2 = 0; 459 sector_t s1, s2, d1 = 0, d2 = 0;
460 unsigned long back_max; 460 unsigned long back_max;
461#define CFQ_RQ1_WRAP 0x01 /* request 1 wraps */ 461#define CFQ_RQ1_WRAP 0x01 /* request 1 wraps */
462#define CFQ_RQ2_WRAP 0x02 /* request 2 wraps */ 462#define CFQ_RQ2_WRAP 0x02 /* request 2 wraps */
@@ -479,8 +479,6 @@ cfq_choose_req(struct cfq_data *cfqd, struct request *rq1, struct request *rq2)
479 s1 = blk_rq_pos(rq1); 479 s1 = blk_rq_pos(rq1);
480 s2 = blk_rq_pos(rq2); 480 s2 = blk_rq_pos(rq2);
481 481
482 last = cfqd->last_position;
483
484 /* 482 /*
485 * by definition, 1KiB is 2 sectors 483 * by definition, 1KiB is 2 sectors
486 */ 484 */
@@ -595,7 +593,7 @@ cfq_find_next_rq(struct cfq_data *cfqd, struct cfq_queue *cfqq,
595 next = rb_entry_rq(rbnext); 593 next = rb_entry_rq(rbnext);
596 } 594 }
597 595
598 return cfq_choose_req(cfqd, next, prev); 596 return cfq_choose_req(cfqd, next, prev, blk_rq_pos(last));
599} 597}
600 598
601static unsigned long cfq_slice_offset(struct cfq_data *cfqd, 599static unsigned long cfq_slice_offset(struct cfq_data *cfqd,
@@ -843,7 +841,7 @@ static void cfq_add_rq_rb(struct request *rq)
843 * check if this request is a better next-serve candidate 841 * check if this request is a better next-serve candidate
844 */ 842 */
845 prev = cfqq->next_rq; 843 prev = cfqq->next_rq;
846 cfqq->next_rq = cfq_choose_req(cfqd, cfqq->next_rq, rq); 844 cfqq->next_rq = cfq_choose_req(cfqd, cfqq->next_rq, rq, cfqd->last_position);
847 845
848 /* 846 /*
849 * adjust priority tree position, if ->next_rq changes 847 * adjust priority tree position, if ->next_rq changes
@@ -950,6 +948,7 @@ static void
950cfq_merged_requests(struct request_queue *q, struct request *rq, 948cfq_merged_requests(struct request_queue *q, struct request *rq,
951 struct request *next) 949 struct request *next)
952{ 950{
951 struct cfq_queue *cfqq = RQ_CFQQ(rq);
953 /* 952 /*
954 * reposition in fifo if next is older than rq 953 * reposition in fifo if next is older than rq
955 */ 954 */
@@ -959,6 +958,8 @@ cfq_merged_requests(struct request_queue *q, struct request *rq,
959 rq_set_fifo_time(rq, rq_fifo_time(next)); 958 rq_set_fifo_time(rq, rq_fifo_time(next));
960 } 959 }
961 960
961 if (cfqq->next_rq == next)
962 cfqq->next_rq = rq;
962 cfq_remove_request(next); 963 cfq_remove_request(next);
963} 964}
964 965