diff options
-rw-r--r-- | arch/x86/kernel/cpuid.c | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/arch/x86/kernel/cpuid.c b/arch/x86/kernel/cpuid.c index 23e8316c8357..8e9cd6a8ec12 100644 --- a/arch/x86/kernel/cpuid.c +++ b/arch/x86/kernel/cpuid.c | |||
@@ -89,7 +89,8 @@ static ssize_t cpuid_read(struct file *file, char __user *buf, | |||
89 | struct cpuid_regs cmd; | 89 | struct cpuid_regs cmd; |
90 | int cpu = iminor(file->f_path.dentry->d_inode); | 90 | int cpu = iminor(file->f_path.dentry->d_inode); |
91 | u64 pos = *ppos; | 91 | u64 pos = *ppos; |
92 | int err; | 92 | ssize_t bytes = 0; |
93 | int err = 0; | ||
93 | 94 | ||
94 | if (count % 16) | 95 | if (count % 16) |
95 | return -EINVAL; /* Invalid chunk size */ | 96 | return -EINVAL; /* Invalid chunk size */ |
@@ -99,14 +100,17 @@ static ssize_t cpuid_read(struct file *file, char __user *buf, | |||
99 | cmd.ecx = pos >> 32; | 100 | cmd.ecx = pos >> 32; |
100 | err = smp_call_function_single(cpu, cpuid_smp_cpuid, &cmd, 1); | 101 | err = smp_call_function_single(cpu, cpuid_smp_cpuid, &cmd, 1); |
101 | if (err) | 102 | if (err) |
102 | return err; | 103 | break; |
103 | if (copy_to_user(tmp, &cmd, 16)) | 104 | if (copy_to_user(tmp, &cmd, 16)) { |
104 | return -EFAULT; | 105 | err = -EFAULT; |
106 | break; | ||
107 | } | ||
105 | tmp += 16; | 108 | tmp += 16; |
109 | bytes += 16; | ||
106 | *ppos = ++pos; | 110 | *ppos = ++pos; |
107 | } | 111 | } |
108 | 112 | ||
109 | return tmp - buf; | 113 | return bytes ? bytes : err; |
110 | } | 114 | } |
111 | 115 | ||
112 | static int cpuid_open(struct inode *inode, struct file *file) | 116 | static int cpuid_open(struct inode *inode, struct file *file) |