aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/ieee1394/sbp2.c31
1 files changed, 12 insertions, 19 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c
index 38abf0325403..ecbb5ee500ab 100644
--- a/drivers/ieee1394/sbp2.c
+++ b/drivers/ieee1394/sbp2.c
@@ -217,18 +217,12 @@ static u32 global_outstanding_dmas = 0;
217#if CONFIG_IEEE1394_SBP2_DEBUG >= 2 217#if CONFIG_IEEE1394_SBP2_DEBUG >= 2
218#define SBP2_DEBUG(fmt, args...) HPSB_ERR("sbp2: "fmt, ## args) 218#define SBP2_DEBUG(fmt, args...) HPSB_ERR("sbp2: "fmt, ## args)
219#define SBP2_INFO(fmt, args...) HPSB_ERR("sbp2: "fmt, ## args) 219#define SBP2_INFO(fmt, args...) HPSB_ERR("sbp2: "fmt, ## args)
220#define SBP2_NOTICE(fmt, args...) HPSB_ERR("sbp2: "fmt, ## args)
221#define SBP2_WARN(fmt, args...) HPSB_ERR("sbp2: "fmt, ## args)
222#elif CONFIG_IEEE1394_SBP2_DEBUG == 1 220#elif CONFIG_IEEE1394_SBP2_DEBUG == 1
223#define SBP2_DEBUG(fmt, args...) HPSB_DEBUG("sbp2: "fmt, ## args) 221#define SBP2_DEBUG(fmt, args...) HPSB_DEBUG("sbp2: "fmt, ## args)
224#define SBP2_INFO(fmt, args...) HPSB_INFO("sbp2: "fmt, ## args) 222#define SBP2_INFO(fmt, args...) HPSB_INFO("sbp2: "fmt, ## args)
225#define SBP2_NOTICE(fmt, args...) HPSB_NOTICE("sbp2: "fmt, ## args)
226#define SBP2_WARN(fmt, args...) HPSB_WARN("sbp2: "fmt, ## args)
227#else 223#else
228#define SBP2_DEBUG(fmt, args...) do {} while (0) 224#define SBP2_DEBUG(fmt, args...) do {} while (0)
229#define SBP2_INFO(fmt, args...) HPSB_INFO("sbp2: "fmt, ## args) 225#define SBP2_INFO(fmt, args...) HPSB_INFO("sbp2: "fmt, ## args)
230#define SBP2_NOTICE(fmt, args...) HPSB_NOTICE("sbp2: "fmt, ## args)
231#define SBP2_WARN(fmt, args...) HPSB_WARN("sbp2: "fmt, ## args)
232#endif 226#endif
233 227
234#define SBP2_ERR(fmt, args...) HPSB_ERR("sbp2: "fmt, ## args) 228#define SBP2_ERR(fmt, args...) HPSB_ERR("sbp2: "fmt, ## args)
@@ -1559,7 +1553,7 @@ static int sbp2_reconnect_device(struct scsi_id_instance_data *scsi_id)
1559 return -EIO; 1553 return -EIO;
1560 } 1554 }
1561 1555
1562 HPSB_DEBUG("Reconnected to SBP-2 device"); 1556 SBP2_INFO("Reconnected to SBP-2 device");
1563 return 0; 1557 return 0;
1564} 1558}
1565 1559
@@ -1685,7 +1679,7 @@ static void sbp2_parse_unit_directory(struct scsi_id_instance_data *scsi_id,
1685 * max_sectors on the fly, therefore warn only. */ 1679 * max_sectors on the fly, therefore warn only. */
1686 if (workarounds & SBP2_WORKAROUND_128K_MAX_TRANS && 1680 if (workarounds & SBP2_WORKAROUND_128K_MAX_TRANS &&
1687 (max_sectors * 512) > (128 * 1024)) 1681 (max_sectors * 512) > (128 * 1024))
1688 SBP2_WARN("Node " NODE_BUS_FMT ": Bridge only supports 128KB " 1682 SBP2_INFO("Node " NODE_BUS_FMT ": Bridge only supports 128KB "
1689 "max transfer size. WARNING: Current max_sectors " 1683 "max transfer size. WARNING: Current max_sectors "
1690 "setting is larger than 128KB (%d sectors)", 1684 "setting is larger than 128KB (%d sectors)",
1691 NODE_BUS_ARGS(ud->ne->host, ud->ne->nodeid), 1685 NODE_BUS_ARGS(ud->ne->host, ud->ne->nodeid),
@@ -1733,8 +1727,7 @@ static int sbp2_max_speed_and_size(struct scsi_id_instance_data *scsi_id)
1733 /* Bump down our speed if the user requested it */ 1727 /* Bump down our speed if the user requested it */
1734 if (scsi_id->speed_code > max_speed) { 1728 if (scsi_id->speed_code > max_speed) {
1735 scsi_id->speed_code = max_speed; 1729 scsi_id->speed_code = max_speed;
1736 SBP2_ERR("Forcing SBP-2 max speed down to %s", 1730 SBP2_INFO("Reducing speed to %s", hpsb_speedto_str[max_speed]);
1737 hpsb_speedto_str[scsi_id->speed_code]);
1738 } 1731 }
1739 1732
1740 /* Payload size is the lesser of what our speed supports and what 1733 /* Payload size is the lesser of what our speed supports and what
@@ -1749,10 +1742,10 @@ static int sbp2_max_speed_and_size(struct scsi_id_instance_data *scsi_id)
1749 payload) 1742 payload)
1750 payload--; 1743 payload--;
1751 1744
1752 HPSB_DEBUG("Node " NODE_BUS_FMT ": Max speed [%s] - Max payload [%u]", 1745 SBP2_INFO("Node " NODE_BUS_FMT ": Max speed [%s] - Max payload [%u]",
1753 NODE_BUS_ARGS(hi->host, scsi_id->ne->nodeid), 1746 NODE_BUS_ARGS(hi->host, scsi_id->ne->nodeid),
1754 hpsb_speedto_str[scsi_id->speed_code], 1747 hpsb_speedto_str[scsi_id->speed_code],
1755 SBP2_PAYLOAD_TO_BYTES(payload)); 1748 SBP2_PAYLOAD_TO_BYTES(payload));
1756 1749
1757 scsi_id->max_payload_size = payload; 1750 scsi_id->max_payload_size = payload;
1758 return 0; 1751 return 0;
@@ -1997,7 +1990,7 @@ static void sbp2_create_command_orb(struct scsi_id_instance_data *scsi_id,
1997 else if (dma_dir == DMA_FROM_DEVICE && scsi_request_bufflen) 1990 else if (dma_dir == DMA_FROM_DEVICE && scsi_request_bufflen)
1998 orb_direction = ORB_DIRECTION_READ_FROM_MEDIA; 1991 orb_direction = ORB_DIRECTION_READ_FROM_MEDIA;
1999 else { 1992 else {
2000 SBP2_WARN("Falling back to DMA_NONE"); 1993 SBP2_INFO("Falling back to DMA_NONE");
2001 orb_direction = ORB_DIRECTION_NO_DATA_TRANSFER; 1994 orb_direction = ORB_DIRECTION_NO_DATA_TRANSFER;
2002 } 1995 }
2003 1996
@@ -2280,7 +2273,7 @@ static int sbp2_handle_status_write(struct hpsb_host *host, int nodeid,
2280 u32 r = STATUS_GET_RESP(h); 2273 u32 r = STATUS_GET_RESP(h);
2281 2274
2282 if (r != RESP_STATUS_REQUEST_COMPLETE) { 2275 if (r != RESP_STATUS_REQUEST_COMPLETE) {
2283 SBP2_WARN("resp 0x%x, sbp_status 0x%x", 2276 SBP2_INFO("resp 0x%x, sbp_status 0x%x",
2284 r, STATUS_GET_SBP_STATUS(h)); 2277 r, STATUS_GET_SBP_STATUS(h));
2285 scsi_status = 2278 scsi_status =
2286 r == RESP_STATUS_TRANSPORT_FAILURE ? 2279 r == RESP_STATUS_TRANSPORT_FAILURE ?
@@ -2587,7 +2580,7 @@ static int sbp2scsi_abort(struct scsi_cmnd *SCpnt)
2587 struct sbp2_command_info *command; 2580 struct sbp2_command_info *command;
2588 unsigned long flags; 2581 unsigned long flags;
2589 2582
2590 SBP2_ERR("aborting sbp2 command"); 2583 SBP2_INFO("aborting sbp2 command");
2591 scsi_print_command(SCpnt); 2584 scsi_print_command(SCpnt);
2592 2585
2593 if (sbp2util_node_is_available(scsi_id)) { 2586 if (sbp2util_node_is_available(scsi_id)) {
@@ -2628,10 +2621,10 @@ static int sbp2scsi_reset(struct scsi_cmnd *SCpnt)
2628 struct scsi_id_instance_data *scsi_id = 2621 struct scsi_id_instance_data *scsi_id =
2629 (struct scsi_id_instance_data *)SCpnt->device->host->hostdata[0]; 2622 (struct scsi_id_instance_data *)SCpnt->device->host->hostdata[0];
2630 2623
2631 SBP2_ERR("reset requested"); 2624 SBP2_INFO("reset requested");
2632 2625
2633 if (sbp2util_node_is_available(scsi_id)) { 2626 if (sbp2util_node_is_available(scsi_id)) {
2634 SBP2_ERR("Generating sbp2 fetch agent reset"); 2627 SBP2_INFO("generating sbp2 fetch agent reset");
2635 sbp2_agent_reset(scsi_id, 1); 2628 sbp2_agent_reset(scsi_id, 1);
2636 } 2629 }
2637 2630