diff options
-rw-r--r-- | net/bridge/br_stp_timer.c | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/net/bridge/br_stp_timer.c b/net/bridge/br_stp_timer.c index 9bef55f56425..75a5f6fbfa53 100644 --- a/net/bridge/br_stp_timer.c +++ b/net/bridge/br_stp_timer.c | |||
@@ -39,13 +39,13 @@ static void br_hello_timer_expired(unsigned long arg) | |||
39 | struct net_bridge *br = (struct net_bridge *)arg; | 39 | struct net_bridge *br = (struct net_bridge *)arg; |
40 | 40 | ||
41 | pr_debug("%s: hello timer expired\n", br->dev->name); | 41 | pr_debug("%s: hello timer expired\n", br->dev->name); |
42 | spin_lock_bh(&br->lock); | 42 | spin_lock(&br->lock); |
43 | if (br->dev->flags & IFF_UP) { | 43 | if (br->dev->flags & IFF_UP) { |
44 | br_config_bpdu_generation(br); | 44 | br_config_bpdu_generation(br); |
45 | 45 | ||
46 | mod_timer(&br->hello_timer, jiffies + br->hello_time); | 46 | mod_timer(&br->hello_timer, jiffies + br->hello_time); |
47 | } | 47 | } |
48 | spin_unlock_bh(&br->lock); | 48 | spin_unlock(&br->lock); |
49 | } | 49 | } |
50 | 50 | ||
51 | static void br_message_age_timer_expired(unsigned long arg) | 51 | static void br_message_age_timer_expired(unsigned long arg) |
@@ -71,7 +71,7 @@ static void br_message_age_timer_expired(unsigned long arg) | |||
71 | * running when we are the root bridge. So.. this was_root | 71 | * running when we are the root bridge. So.. this was_root |
72 | * check is redundant. I'm leaving it in for now, though. | 72 | * check is redundant. I'm leaving it in for now, though. |
73 | */ | 73 | */ |
74 | spin_lock_bh(&br->lock); | 74 | spin_lock(&br->lock); |
75 | if (p->state == BR_STATE_DISABLED) | 75 | if (p->state == BR_STATE_DISABLED) |
76 | goto unlock; | 76 | goto unlock; |
77 | was_root = br_is_root_bridge(br); | 77 | was_root = br_is_root_bridge(br); |
@@ -82,7 +82,7 @@ static void br_message_age_timer_expired(unsigned long arg) | |||
82 | if (br_is_root_bridge(br) && !was_root) | 82 | if (br_is_root_bridge(br) && !was_root) |
83 | br_become_root_bridge(br); | 83 | br_become_root_bridge(br); |
84 | unlock: | 84 | unlock: |
85 | spin_unlock_bh(&br->lock); | 85 | spin_unlock(&br->lock); |
86 | } | 86 | } |
87 | 87 | ||
88 | static void br_forward_delay_timer_expired(unsigned long arg) | 88 | static void br_forward_delay_timer_expired(unsigned long arg) |
@@ -92,7 +92,7 @@ static void br_forward_delay_timer_expired(unsigned long arg) | |||
92 | 92 | ||
93 | pr_debug("%s: %d(%s) forward delay timer\n", | 93 | pr_debug("%s: %d(%s) forward delay timer\n", |
94 | br->dev->name, p->port_no, p->dev->name); | 94 | br->dev->name, p->port_no, p->dev->name); |
95 | spin_lock_bh(&br->lock); | 95 | spin_lock(&br->lock); |
96 | if (p->state == BR_STATE_LISTENING) { | 96 | if (p->state == BR_STATE_LISTENING) { |
97 | p->state = BR_STATE_LEARNING; | 97 | p->state = BR_STATE_LEARNING; |
98 | mod_timer(&p->forward_delay_timer, | 98 | mod_timer(&p->forward_delay_timer, |
@@ -103,7 +103,7 @@ static void br_forward_delay_timer_expired(unsigned long arg) | |||
103 | br_topology_change_detection(br); | 103 | br_topology_change_detection(br); |
104 | } | 104 | } |
105 | br_log_state(p); | 105 | br_log_state(p); |
106 | spin_unlock_bh(&br->lock); | 106 | spin_unlock(&br->lock); |
107 | } | 107 | } |
108 | 108 | ||
109 | static void br_tcn_timer_expired(unsigned long arg) | 109 | static void br_tcn_timer_expired(unsigned long arg) |
@@ -111,13 +111,13 @@ static void br_tcn_timer_expired(unsigned long arg) | |||
111 | struct net_bridge *br = (struct net_bridge *) arg; | 111 | struct net_bridge *br = (struct net_bridge *) arg; |
112 | 112 | ||
113 | pr_debug("%s: tcn timer expired\n", br->dev->name); | 113 | pr_debug("%s: tcn timer expired\n", br->dev->name); |
114 | spin_lock_bh(&br->lock); | 114 | spin_lock(&br->lock); |
115 | if (br->dev->flags & IFF_UP) { | 115 | if (br->dev->flags & IFF_UP) { |
116 | br_transmit_tcn(br); | 116 | br_transmit_tcn(br); |
117 | 117 | ||
118 | mod_timer(&br->tcn_timer,jiffies + br->bridge_hello_time); | 118 | mod_timer(&br->tcn_timer,jiffies + br->bridge_hello_time); |
119 | } | 119 | } |
120 | spin_unlock_bh(&br->lock); | 120 | spin_unlock(&br->lock); |
121 | } | 121 | } |
122 | 122 | ||
123 | static void br_topology_change_timer_expired(unsigned long arg) | 123 | static void br_topology_change_timer_expired(unsigned long arg) |
@@ -125,10 +125,10 @@ static void br_topology_change_timer_expired(unsigned long arg) | |||
125 | struct net_bridge *br = (struct net_bridge *) arg; | 125 | struct net_bridge *br = (struct net_bridge *) arg; |
126 | 126 | ||
127 | pr_debug("%s: topo change timer expired\n", br->dev->name); | 127 | pr_debug("%s: topo change timer expired\n", br->dev->name); |
128 | spin_lock_bh(&br->lock); | 128 | spin_lock(&br->lock); |
129 | br->topology_change_detected = 0; | 129 | br->topology_change_detected = 0; |
130 | br->topology_change = 0; | 130 | br->topology_change = 0; |
131 | spin_unlock_bh(&br->lock); | 131 | spin_unlock(&br->lock); |
132 | } | 132 | } |
133 | 133 | ||
134 | static void br_hold_timer_expired(unsigned long arg) | 134 | static void br_hold_timer_expired(unsigned long arg) |
@@ -138,10 +138,10 @@ static void br_hold_timer_expired(unsigned long arg) | |||
138 | pr_debug("%s: %d(%s) hold timer expired\n", | 138 | pr_debug("%s: %d(%s) hold timer expired\n", |
139 | p->br->dev->name, p->port_no, p->dev->name); | 139 | p->br->dev->name, p->port_no, p->dev->name); |
140 | 140 | ||
141 | spin_lock_bh(&p->br->lock); | 141 | spin_lock(&p->br->lock); |
142 | if (p->config_pending) | 142 | if (p->config_pending) |
143 | br_transmit_config(p); | 143 | br_transmit_config(p); |
144 | spin_unlock_bh(&p->br->lock); | 144 | spin_unlock(&p->br->lock); |
145 | } | 145 | } |
146 | 146 | ||
147 | static inline void br_timer_init(struct timer_list *timer, | 147 | static inline void br_timer_init(struct timer_list *timer, |