diff options
-rw-r--r-- | drivers/ide/ide-lib.c | 18 | ||||
-rw-r--r-- | include/linux/ide.h | 3 |
2 files changed, 8 insertions, 13 deletions
diff --git a/drivers/ide/ide-lib.c b/drivers/ide/ide-lib.c index 8afce4ceea31..68719314df3f 100644 --- a/drivers/ide/ide-lib.c +++ b/drivers/ide/ide-lib.c | |||
@@ -345,16 +345,16 @@ static int ide_scan_pio_blacklist (char *model) | |||
345 | 345 | ||
346 | /** | 346 | /** |
347 | * ide_get_best_pio_mode - get PIO mode from drive | 347 | * ide_get_best_pio_mode - get PIO mode from drive |
348 | * @driver: drive to consider | 348 | * @drive: drive to consider |
349 | * @mode_wanted: preferred mode | 349 | * @mode_wanted: preferred mode |
350 | * @max_mode: highest allowed | 350 | * @max_mode: highest allowed mode |
351 | * @d: pio data | 351 | * @d: PIO data |
352 | * | 352 | * |
353 | * This routine returns the recommended PIO settings for a given drive, | 353 | * This routine returns the recommended PIO settings for a given drive, |
354 | * based on the drive->id information and the ide_pio_blacklist[]. | 354 | * based on the drive->id information and the ide_pio_blacklist[]. |
355 | * This is used by most chipset support modules when "auto-tuning". | ||
356 | * | 355 | * |
357 | * Drive PIO mode auto selection | 356 | * Drive PIO mode is auto-selected if 255 is passed as mode_wanted. |
357 | * This is used by most chipset support modules when "auto-tuning". | ||
358 | */ | 358 | */ |
359 | 359 | ||
360 | u8 ide_get_best_pio_mode (ide_drive_t *drive, u8 mode_wanted, u8 max_mode, ide_pio_data_t *d) | 360 | u8 ide_get_best_pio_mode (ide_drive_t *drive, u8 mode_wanted, u8 max_mode, ide_pio_data_t *d) |
@@ -367,6 +367,7 @@ u8 ide_get_best_pio_mode (ide_drive_t *drive, u8 mode_wanted, u8 max_mode, ide_p | |||
367 | 367 | ||
368 | if (mode_wanted != 255) { | 368 | if (mode_wanted != 255) { |
369 | pio_mode = mode_wanted; | 369 | pio_mode = mode_wanted; |
370 | use_iordy = (pio_mode > 2); | ||
370 | } else if (!drive->id) { | 371 | } else if (!drive->id) { |
371 | pio_mode = 0; | 372 | pio_mode = 0; |
372 | } else if ((pio_mode = ide_scan_pio_blacklist(id->model)) != -1) { | 373 | } else if ((pio_mode = ide_scan_pio_blacklist(id->model)) != -1) { |
@@ -396,19 +397,12 @@ u8 ide_get_best_pio_mode (ide_drive_t *drive, u8 mode_wanted, u8 max_mode, ide_p | |||
396 | } | 397 | } |
397 | } | 398 | } |
398 | 399 | ||
399 | #if 0 | ||
400 | if (drive->id->major_rev_num & 0x0004) printk("ATA-2 "); | ||
401 | #endif | ||
402 | |||
403 | /* | 400 | /* |
404 | * Conservative "downgrade" for all pre-ATA2 drives | 401 | * Conservative "downgrade" for all pre-ATA2 drives |
405 | */ | 402 | */ |
406 | if (pio_mode && pio_mode < 4) { | 403 | if (pio_mode && pio_mode < 4) { |
407 | pio_mode--; | 404 | pio_mode--; |
408 | overridden = 1; | 405 | overridden = 1; |
409 | #if 0 | ||
410 | use_iordy = (pio_mode > 2); | ||
411 | #endif | ||
412 | if (cycle_time && cycle_time < ide_pio_timings[pio_mode].cycle_time) | 406 | if (cycle_time && cycle_time < ide_pio_timings[pio_mode].cycle_time) |
413 | cycle_time = 0; /* use standard timing */ | 407 | cycle_time = 0; /* use standard timing */ |
414 | } | 408 | } |
diff --git a/include/linux/ide.h b/include/linux/ide.h index 79c028251c70..34f2676b3c62 100644 --- a/include/linux/ide.h +++ b/include/linux/ide.h | |||
@@ -1359,7 +1359,8 @@ u8 ide_dump_status(ide_drive_t *, const char *, u8); | |||
1359 | typedef struct ide_pio_timings_s { | 1359 | typedef struct ide_pio_timings_s { |
1360 | int setup_time; /* Address setup (ns) minimum */ | 1360 | int setup_time; /* Address setup (ns) minimum */ |
1361 | int active_time; /* Active pulse (ns) minimum */ | 1361 | int active_time; /* Active pulse (ns) minimum */ |
1362 | int cycle_time; /* Cycle time (ns) minimum = (setup + active + recovery) */ | 1362 | int cycle_time; /* Cycle time (ns) minimum = */ |
1363 | /* active + recovery (+ setup for some chips) */ | ||
1363 | } ide_pio_timings_t; | 1364 | } ide_pio_timings_t; |
1364 | 1365 | ||
1365 | typedef struct ide_pio_data_s { | 1366 | typedef struct ide_pio_data_s { |