aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/ide/ide-cd.c1
-rw-r--r--drivers/ide/ide-gd.c1
-rw-r--r--drivers/ide/ide-io.c13
-rw-r--r--drivers/ide/ide-tape.c1
-rw-r--r--include/linux/ide.h3
5 files changed, 2 insertions, 17 deletions
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index bc982dfacc36..6c7dd8fd8638 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -1925,7 +1925,6 @@ static struct ide_driver ide_cdrom_driver = {
1925 .version = IDECD_VERSION, 1925 .version = IDECD_VERSION,
1926 .do_request = ide_cd_do_request, 1926 .do_request = ide_cd_do_request,
1927 .end_request = ide_end_request, 1927 .end_request = ide_end_request,
1928 .error = __ide_error,
1929#ifdef CONFIG_IDE_PROC_FS 1928#ifdef CONFIG_IDE_PROC_FS
1930 .proc_entries = ide_cd_proc_entries, 1929 .proc_entries = ide_cd_proc_entries,
1931 .proc_devsets = ide_cd_proc_devsets, 1930 .proc_devsets = ide_cd_proc_devsets,
diff --git a/drivers/ide/ide-gd.c b/drivers/ide/ide-gd.c
index cae82b3c432a..7857b209c6df 100644
--- a/drivers/ide/ide-gd.c
+++ b/drivers/ide/ide-gd.c
@@ -162,7 +162,6 @@ static struct ide_driver ide_gd_driver = {
162 .version = IDE_GD_VERSION, 162 .version = IDE_GD_VERSION,
163 .do_request = ide_gd_do_request, 163 .do_request = ide_gd_do_request,
164 .end_request = ide_gd_end_request, 164 .end_request = ide_gd_end_request,
165 .error = __ide_error,
166#ifdef CONFIG_IDE_PROC_FS 165#ifdef CONFIG_IDE_PROC_FS
167 .proc_entries = ide_disk_proc_entries, 166 .proc_entries = ide_disk_proc_entries,
168 .proc_devsets = ide_disk_proc_devsets, 167 .proc_devsets = ide_disk_proc_devsets,
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index e788b3622f2e..9d363a1b5573 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -291,7 +291,7 @@ static ide_startstop_t ide_atapi_error(ide_drive_t *drive, struct request *rq, u
291 return ide_stopped; 291 return ide_stopped;
292} 292}
293 293
294ide_startstop_t 294static ide_startstop_t
295__ide_error(ide_drive_t *drive, struct request *rq, u8 stat, u8 err) 295__ide_error(ide_drive_t *drive, struct request *rq, u8 stat, u8 err)
296{ 296{
297 if (drive->media == ide_disk) 297 if (drive->media == ide_disk)
@@ -299,8 +299,6 @@ __ide_error(ide_drive_t *drive, struct request *rq, u8 stat, u8 err)
299 return ide_atapi_error(drive, rq, stat, err); 299 return ide_atapi_error(drive, rq, stat, err);
300} 300}
301 301
302EXPORT_SYMBOL_GPL(__ide_error);
303
304/** 302/**
305 * ide_error - handle an error on the IDE 303 * ide_error - handle an error on the IDE
306 * @drive: drive the error occurred on 304 * @drive: drive the error occurred on
@@ -332,15 +330,8 @@ ide_startstop_t ide_error (ide_drive_t *drive, const char *msg, u8 stat)
332 return ide_stopped; 330 return ide_stopped;
333 } 331 }
334 332
335 if (rq->rq_disk) { 333 return __ide_error(drive, rq, stat, err);
336 struct ide_driver *drv;
337
338 drv = *(struct ide_driver **)rq->rq_disk->private_data;
339 return drv->error(drive, rq, stat, err);
340 } else
341 return __ide_error(drive, rq, stat, err);
342} 334}
343
344EXPORT_SYMBOL_GPL(ide_error); 335EXPORT_SYMBOL_GPL(ide_error);
345 336
346static void ide_tf_set_specify_cmd(ide_drive_t *drive, struct ide_taskfile *tf) 337static void ide_tf_set_specify_cmd(ide_drive_t *drive, struct ide_taskfile *tf)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index fd865039bfdb..d7ecd3c79757 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -2324,7 +2324,6 @@ static struct ide_driver idetape_driver = {
2324 .version = IDETAPE_VERSION, 2324 .version = IDETAPE_VERSION,
2325 .do_request = idetape_do_request, 2325 .do_request = idetape_do_request,
2326 .end_request = idetape_end_request, 2326 .end_request = idetape_end_request,
2327 .error = __ide_error,
2328#ifdef CONFIG_IDE_PROC_FS 2327#ifdef CONFIG_IDE_PROC_FS
2329 .proc_entries = ide_tape_proc_entries, 2328 .proc_entries = ide_tape_proc_entries,
2330 .proc_devsets = ide_tape_proc_devsets, 2329 .proc_devsets = ide_tape_proc_devsets,
diff --git a/include/linux/ide.h b/include/linux/ide.h
index fcbcfa2cbe75..9f6fe1fe7a6c 100644
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -1113,7 +1113,6 @@ struct ide_driver {
1113 const char *version; 1113 const char *version;
1114 ide_startstop_t (*do_request)(ide_drive_t *, struct request *, sector_t); 1114 ide_startstop_t (*do_request)(ide_drive_t *, struct request *, sector_t);
1115 int (*end_request)(ide_drive_t *, int, int); 1115 int (*end_request)(ide_drive_t *, int, int);
1116 ide_startstop_t (*error)(ide_drive_t *, struct request *rq, u8, u8);
1117 struct device_driver gen_driver; 1116 struct device_driver gen_driver;
1118 int (*probe)(ide_drive_t *); 1117 int (*probe)(ide_drive_t *);
1119 void (*remove)(ide_drive_t *); 1118 void (*remove)(ide_drive_t *);
@@ -1157,8 +1156,6 @@ void ide_execute_pkt_cmd(ide_drive_t *);
1157 1156
1158void ide_pad_transfer(ide_drive_t *, int, int); 1157void ide_pad_transfer(ide_drive_t *, int, int);
1159 1158
1160ide_startstop_t __ide_error(ide_drive_t *, struct request *, u8, u8);
1161
1162ide_startstop_t ide_error(ide_drive_t *, const char *, u8); 1159ide_startstop_t ide_error(ide_drive_t *, const char *, u8);
1163 1160
1164void ide_fix_driveid(u16 *); 1161void ide_fix_driveid(u16 *);