1 files changed, 15 insertions, 13 deletions

diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index f2db7a41cf1d..c76e73a3ffbe 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -1284,7 +1284,9 @@ EXPORT_SYMBOL(fc_release_transport);
  * @work:       Work to queue for execution.
  *
  * Return value:
- *      0 on success / != 0 for error
+ *      1 - work queued for execution
+ *      0 - work is already queued
+ *      -EINVAL - work queue doesn't exist
  **/
 static int
 fc_queue_work(struct Scsi_Host *shost, struct work_struct *work)
@@ -1434,8 +1436,6 @@ fc_starget_delete(void *data)
         struct Scsi_Host *shost = rport_to_shost(rport);
         unsigned long flags;
 
-        scsi_target_unblock(&rport->dev);
-
         spin_lock_irqsave(shost->host_lock, flags);
         if (rport->flags & FC_RPORT_DEVLOSS_PENDING) {
                 spin_unlock_irqrestore(shost->host_lock, flags);
@@ -1707,6 +1707,8 @@ fc_remote_port_add(struct Scsi_Host *shost, int channel,
 
                                 spin_unlock_irqrestore(shost->host_lock, flags);
 
+                                scsi_target_unblock(&rport->dev);
+
                                 return rport;
                         }
                 }
@@ -1762,9 +1764,10 @@ fc_remote_port_add(struct Scsi_Host *shost, int channel,
                                 /* initiate a scan of the target */
                                 rport->flags |= FC_RPORT_SCAN_PENDING;
                                 scsi_queue_work(shost, &rport->scan_work);
-                        }
-
-                        spin_unlock_irqrestore(shost->host_lock, flags);
+                                spin_unlock_irqrestore(shost->host_lock, flags);
+                                scsi_target_unblock(&rport->dev);
+                        } else
+                                spin_unlock_irqrestore(shost->host_lock, flags);
 
                         return rport;
                 }
@@ -1938,6 +1941,7 @@ fc_remote_port_rolechg(struct fc_rport  *rport, u32 roles)
                 rport->flags |= FC_RPORT_SCAN_PENDING;
                 scsi_queue_work(shost, &rport->scan_work);
                 spin_unlock_irqrestore(shost->host_lock, flags);
+                scsi_target_unblock(&rport->dev);
         }
 }
 EXPORT_SYMBOL(fc_remote_port_rolechg);
@@ -1970,8 +1974,9 @@ fc_timeout_deleted_rport(void  *data)
                 dev_printk(KERN_ERR, &rport->dev,
                         "blocked FC remote port time out: no longer"
                         " a FCP target, removing starget\n");
-                fc_queue_work(shost, &rport->stgt_delete_work);
                 spin_unlock_irqrestore(shost->host_lock, flags);
+                scsi_target_unblock(&rport->dev);
+                fc_queue_work(shost, &rport->stgt_delete_work);
                 return;
         }
 
@@ -2035,17 +2040,15 @@ fc_timeout_deleted_rport(void  *data)
          * went away and didn't come back - we'll remove
          * all attached scsi devices.
          */
-        fc_queue_work(shost, &rport->stgt_delete_work);
-
         spin_unlock_irqrestore(shost->host_lock, flags);
+
+        scsi_target_unblock(&rport->dev);
+        fc_queue_work(shost, &rport->stgt_delete_work);
 }
 
 /**
  * fc_scsi_scan_rport - called to perform a scsi scan on a remote port.
  *
- * Will unblock the target (in case it went away and has now come back),
- * then invoke a scan.
- *
  * @data:       remote port to be scanned.
  **/
 static void
@@ -2057,7 +2060,6 @@ fc_scsi_scan_rport(void *data)
 
         if ((rport->port_state == FC_PORTSTATE_ONLINE) &&
             (rport->roles & FC_RPORT_ROLE_FCP_TARGET)) {
-                scsi_target_unblock(&rport->dev);
                 scsi_scan_target(&rport->dev, rport->channel,
                         rport->scsi_target_id, SCAN_WILD_CARD, 1);
         }