aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--arch/i386/pci/direct.c4
-rw-r--r--arch/i386/pci/mmconfig.c4
-rw-r--r--arch/x86_64/pci/mmconfig.c4
3 files changed, 9 insertions, 3 deletions
diff --git a/arch/i386/pci/direct.c b/arch/i386/pci/direct.c
index 4457cf3eb401..0659ced01185 100644
--- a/arch/i386/pci/direct.c
+++ b/arch/i386/pci/direct.c
@@ -19,8 +19,10 @@ int pci_conf1_read(unsigned int seg, unsigned int bus,
19{ 19{
20 unsigned long flags; 20 unsigned long flags;
21 21
22 if (!value || (bus > 255) || (devfn > 255) || (reg > 255)) 22 if (!value || (bus > 255) || (devfn > 255) || (reg > 255)) {
23 *value = -1;
23 return -EINVAL; 24 return -EINVAL;
25 }
24 26
25 spin_lock_irqsave(&pci_config_lock, flags); 27 spin_lock_irqsave(&pci_config_lock, flags);
26 28
diff --git a/arch/i386/pci/mmconfig.c b/arch/i386/pci/mmconfig.c
index 2002c741a383..f77d7f8b9bf6 100644
--- a/arch/i386/pci/mmconfig.c
+++ b/arch/i386/pci/mmconfig.c
@@ -80,8 +80,10 @@ static int pci_mmcfg_read(unsigned int seg, unsigned int bus,
80 unsigned long flags; 80 unsigned long flags;
81 u32 base; 81 u32 base;
82 82
83 if (!value || (bus > 255) || (devfn > 255) || (reg > 4095)) 83 if (!value || (bus > 255) || (devfn > 255) || (reg > 4095)) {
84 *value = -1;
84 return -EINVAL; 85 return -EINVAL;
86 }
85 87
86 base = get_base_addr(seg, bus, devfn); 88 base = get_base_addr(seg, bus, devfn);
87 if (!base) 89 if (!base)
diff --git a/arch/x86_64/pci/mmconfig.c b/arch/x86_64/pci/mmconfig.c
index d4e25f38287d..b493ed977e7c 100644
--- a/arch/x86_64/pci/mmconfig.c
+++ b/arch/x86_64/pci/mmconfig.c
@@ -75,8 +75,10 @@ static int pci_mmcfg_read(unsigned int seg, unsigned int bus,
75 char __iomem *addr; 75 char __iomem *addr;
76 76
77 /* Why do we have this when nobody checks it. How about a BUG()!? -AK */ 77 /* Why do we have this when nobody checks it. How about a BUG()!? -AK */
78 if (unlikely(!value || (bus > 255) || (devfn > 255) || (reg > 4095))) 78 if (unlikely(!value || (bus > 255) || (devfn > 255) || (reg > 4095))) {
79 *value = -1;
79 return -EINVAL; 80 return -EINVAL;
81 }
80 82
81 addr = pci_dev_base(seg, bus, devfn); 83 addr = pci_dev_base(seg, bus, devfn);
82 if (!addr) 84 if (!addr)