diff options
-rw-r--r-- | drivers/acpi/dispatcher/dsmethod.c | 12 | ||||
-rw-r--r-- | drivers/acpi/executer/exdump.c | 2 | ||||
-rw-r--r-- | drivers/acpi/executer/exmutex.c | 36 | ||||
-rw-r--r-- | drivers/acpi/utilities/utdelete.c | 1 | ||||
-rw-r--r-- | include/acpi/acinterp.h | 3 | ||||
-rw-r--r-- | include/acpi/acobject.h | 2 |
6 files changed, 25 insertions, 31 deletions
diff --git a/drivers/acpi/dispatcher/dsmethod.c b/drivers/acpi/dispatcher/dsmethod.c index 1cbe61905824..1683e5c5b94c 100644 --- a/drivers/acpi/dispatcher/dsmethod.c +++ b/drivers/acpi/dispatcher/dsmethod.c | |||
@@ -231,10 +231,8 @@ acpi_ds_begin_method_execution(struct acpi_namespace_node *method_node, | |||
231 | * Obtain the method mutex if necessary. Do not acquire mutex for a | 231 | * Obtain the method mutex if necessary. Do not acquire mutex for a |
232 | * recursive call. | 232 | * recursive call. |
233 | */ | 233 | */ |
234 | if (!walk_state || | 234 | if (acpi_os_get_thread_id() != |
235 | !obj_desc->method.mutex->mutex.owner_thread || | 235 | obj_desc->method.mutex->mutex.owner_thread_id) { |
236 | (walk_state->thread != | ||
237 | obj_desc->method.mutex->mutex.owner_thread)) { | ||
238 | /* | 236 | /* |
239 | * Acquire the method mutex. This releases the interpreter if we | 237 | * Acquire the method mutex. This releases the interpreter if we |
240 | * block (and reacquires it before it returns) | 238 | * block (and reacquires it before it returns) |
@@ -248,14 +246,14 @@ acpi_ds_begin_method_execution(struct acpi_namespace_node *method_node, | |||
248 | } | 246 | } |
249 | 247 | ||
250 | /* Update the mutex and walk info and save the original sync_level */ | 248 | /* Update the mutex and walk info and save the original sync_level */ |
249 | obj_desc->method.mutex->mutex.owner_thread_id = | ||
250 | acpi_os_get_thread_id(); | ||
251 | 251 | ||
252 | if (walk_state) { | 252 | if (walk_state) { |
253 | obj_desc->method.mutex->mutex. | 253 | obj_desc->method.mutex->mutex. |
254 | original_sync_level = | 254 | original_sync_level = |
255 | walk_state->thread->current_sync_level; | 255 | walk_state->thread->current_sync_level; |
256 | 256 | ||
257 | obj_desc->method.mutex->mutex.owner_thread = | ||
258 | walk_state->thread; | ||
259 | walk_state->thread->current_sync_level = | 257 | walk_state->thread->current_sync_level = |
260 | obj_desc->method.sync_level; | 258 | obj_desc->method.sync_level; |
261 | } else { | 259 | } else { |
@@ -569,7 +567,7 @@ acpi_ds_terminate_control_method(union acpi_operand_object *method_desc, | |||
569 | 567 | ||
570 | acpi_os_release_mutex(method_desc->method.mutex->mutex. | 568 | acpi_os_release_mutex(method_desc->method.mutex->mutex. |
571 | os_mutex); | 569 | os_mutex); |
572 | method_desc->method.mutex->mutex.owner_thread = NULL; | 570 | method_desc->method.mutex->mutex.owner_thread_id = ACPI_MUTEX_NOT_ACQUIRED; |
573 | } | 571 | } |
574 | } | 572 | } |
575 | 573 | ||
diff --git a/drivers/acpi/executer/exdump.c b/drivers/acpi/executer/exdump.c index 68d283fd60e7..1a73c14df2c5 100644 --- a/drivers/acpi/executer/exdump.c +++ b/drivers/acpi/executer/exdump.c | |||
@@ -134,7 +134,7 @@ static struct acpi_exdump_info acpi_ex_dump_method[8] = { | |||
134 | static struct acpi_exdump_info acpi_ex_dump_mutex[5] = { | 134 | static struct acpi_exdump_info acpi_ex_dump_mutex[5] = { |
135 | {ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_mutex), NULL}, | 135 | {ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_mutex), NULL}, |
136 | {ACPI_EXD_UINT8, ACPI_EXD_OFFSET(mutex.sync_level), "Sync Level"}, | 136 | {ACPI_EXD_UINT8, ACPI_EXD_OFFSET(mutex.sync_level), "Sync Level"}, |
137 | {ACPI_EXD_POINTER, ACPI_EXD_OFFSET(mutex.owner_thread), "Owner Thread"}, | 137 | {ACPI_EXD_POINTER, ACPI_EXD_OFFSET(mutex.owner_thread_id), "Owner Thread"}, |
138 | {ACPI_EXD_UINT16, ACPI_EXD_OFFSET(mutex.acquisition_depth), | 138 | {ACPI_EXD_UINT16, ACPI_EXD_OFFSET(mutex.acquisition_depth), |
139 | "Acquire Depth"}, | 139 | "Acquire Depth"}, |
140 | {ACPI_EXD_POINTER, ACPI_EXD_OFFSET(mutex.os_mutex), "OsMutex"} | 140 | {ACPI_EXD_POINTER, ACPI_EXD_OFFSET(mutex.os_mutex), "OsMutex"} |
diff --git a/drivers/acpi/executer/exmutex.c b/drivers/acpi/executer/exmutex.c index 5101bad5baf8..4eb883bda6ae 100644 --- a/drivers/acpi/executer/exmutex.c +++ b/drivers/acpi/executer/exmutex.c | |||
@@ -66,10 +66,9 @@ acpi_ex_link_mutex(union acpi_operand_object *obj_desc, | |||
66 | * | 66 | * |
67 | ******************************************************************************/ | 67 | ******************************************************************************/ |
68 | 68 | ||
69 | void acpi_ex_unlink_mutex(union acpi_operand_object *obj_desc) | 69 | void acpi_ex_unlink_mutex(union acpi_operand_object *obj_desc, |
70 | struct acpi_thread_state *thread) | ||
70 | { | 71 | { |
71 | struct acpi_thread_state *thread = obj_desc->mutex.owner_thread; | ||
72 | |||
73 | if (!thread) { | 72 | if (!thread) { |
74 | return; | 73 | return; |
75 | } | 74 | } |
@@ -174,16 +173,13 @@ acpi_ex_acquire_mutex(union acpi_operand_object *time_desc, | |||
174 | 173 | ||
175 | /* Support for multiple acquires by the owning thread */ | 174 | /* Support for multiple acquires by the owning thread */ |
176 | 175 | ||
177 | if (obj_desc->mutex.owner_thread) { | 176 | if (obj_desc->mutex.owner_thread_id == acpi_os_get_thread_id()) { |
178 | if (obj_desc->mutex.owner_thread->thread_id == | 177 | /* |
179 | walk_state->thread->thread_id) { | 178 | * The mutex is already owned by this thread, just increment the |
180 | /* | 179 | * acquisition depth |
181 | * The mutex is already owned by this thread, just increment the | 180 | */ |
182 | * acquisition depth | 181 | obj_desc->mutex.acquisition_depth++; |
183 | */ | 182 | return_ACPI_STATUS(AE_OK); |
184 | obj_desc->mutex.acquisition_depth++; | ||
185 | return_ACPI_STATUS(AE_OK); | ||
186 | } | ||
187 | } | 183 | } |
188 | 184 | ||
189 | /* Acquire the mutex, wait if necessary. Special case for Global Lock */ | 185 | /* Acquire the mutex, wait if necessary. Special case for Global Lock */ |
@@ -206,7 +202,7 @@ acpi_ex_acquire_mutex(union acpi_operand_object *time_desc, | |||
206 | 202 | ||
207 | /* Have the mutex: update mutex and walk info and save the sync_level */ | 203 | /* Have the mutex: update mutex and walk info and save the sync_level */ |
208 | 204 | ||
209 | obj_desc->mutex.owner_thread = walk_state->thread; | 205 | obj_desc->mutex.owner_thread_id = acpi_os_get_thread_id(); |
210 | obj_desc->mutex.acquisition_depth = 1; | 206 | obj_desc->mutex.acquisition_depth = 1; |
211 | obj_desc->mutex.original_sync_level = | 207 | obj_desc->mutex.original_sync_level = |
212 | walk_state->thread->current_sync_level; | 208 | walk_state->thread->current_sync_level; |
@@ -246,7 +242,7 @@ acpi_ex_release_mutex(union acpi_operand_object *obj_desc, | |||
246 | 242 | ||
247 | /* The mutex must have been previously acquired in order to release it */ | 243 | /* The mutex must have been previously acquired in order to release it */ |
248 | 244 | ||
249 | if (!obj_desc->mutex.owner_thread) { | 245 | if (!obj_desc->mutex.owner_thread_id) { |
250 | ACPI_ERROR((AE_INFO, | 246 | ACPI_ERROR((AE_INFO, |
251 | "Cannot release Mutex [%4.4s], not acquired", | 247 | "Cannot release Mutex [%4.4s], not acquired", |
252 | acpi_ut_get_node_name(obj_desc->mutex.node))); | 248 | acpi_ut_get_node_name(obj_desc->mutex.node))); |
@@ -266,14 +262,14 @@ acpi_ex_release_mutex(union acpi_operand_object *obj_desc, | |||
266 | * The Mutex is owned, but this thread must be the owner. | 262 | * The Mutex is owned, but this thread must be the owner. |
267 | * Special case for Global Lock, any thread can release | 263 | * Special case for Global Lock, any thread can release |
268 | */ | 264 | */ |
269 | if ((obj_desc->mutex.owner_thread->thread_id != | 265 | if ((obj_desc->mutex.owner_thread_id != |
270 | walk_state->thread->thread_id) | 266 | walk_state->thread->thread_id) |
271 | && (obj_desc->mutex.os_mutex != acpi_gbl_global_lock_mutex)) { | 267 | && (obj_desc->mutex.os_mutex != acpi_gbl_global_lock_mutex)) { |
272 | ACPI_ERROR((AE_INFO, | 268 | ACPI_ERROR((AE_INFO, |
273 | "Thread %lX cannot release Mutex [%4.4s] acquired by thread %lX", | 269 | "Thread %lX cannot release Mutex [%4.4s] acquired by thread %lX", |
274 | (unsigned long)walk_state->thread->thread_id, | 270 | (unsigned long)walk_state->thread->thread_id, |
275 | acpi_ut_get_node_name(obj_desc->mutex.node), | 271 | acpi_ut_get_node_name(obj_desc->mutex.node), |
276 | (unsigned long)obj_desc->mutex.owner_thread->thread_id)); | 272 | (unsigned long)obj_desc->mutex.owner_thread_id)); |
277 | return_ACPI_STATUS(AE_AML_NOT_OWNER); | 273 | return_ACPI_STATUS(AE_AML_NOT_OWNER); |
278 | } | 274 | } |
279 | 275 | ||
@@ -300,7 +296,7 @@ acpi_ex_release_mutex(union acpi_operand_object *obj_desc, | |||
300 | 296 | ||
301 | /* Unlink the mutex from the owner's list */ | 297 | /* Unlink the mutex from the owner's list */ |
302 | 298 | ||
303 | acpi_ex_unlink_mutex(obj_desc); | 299 | acpi_ex_unlink_mutex(obj_desc, walk_state->thread); |
304 | 300 | ||
305 | /* Release the mutex, special case for Global Lock */ | 301 | /* Release the mutex, special case for Global Lock */ |
306 | 302 | ||
@@ -312,7 +308,7 @@ acpi_ex_release_mutex(union acpi_operand_object *obj_desc, | |||
312 | 308 | ||
313 | /* Update the mutex and restore sync_level */ | 309 | /* Update the mutex and restore sync_level */ |
314 | 310 | ||
315 | obj_desc->mutex.owner_thread = NULL; | 311 | obj_desc->mutex.owner_thread_id = ACPI_MUTEX_NOT_ACQUIRED; |
316 | walk_state->thread->current_sync_level = | 312 | walk_state->thread->current_sync_level = |
317 | obj_desc->mutex.original_sync_level; | 313 | obj_desc->mutex.original_sync_level; |
318 | 314 | ||
@@ -367,7 +363,7 @@ void acpi_ex_release_all_mutexes(struct acpi_thread_state *thread) | |||
367 | 363 | ||
368 | /* Mark mutex unowned */ | 364 | /* Mark mutex unowned */ |
369 | 365 | ||
370 | obj_desc->mutex.owner_thread = NULL; | 366 | obj_desc->mutex.owner_thread_id = ACPI_MUTEX_NOT_ACQUIRED; |
371 | 367 | ||
372 | /* Update Thread sync_level (Last mutex is the important one) */ | 368 | /* Update Thread sync_level (Last mutex is the important one) */ |
373 | 369 | ||
diff --git a/drivers/acpi/utilities/utdelete.c b/drivers/acpi/utilities/utdelete.c index f777cebdc46d..673a0caa4073 100644 --- a/drivers/acpi/utilities/utdelete.c +++ b/drivers/acpi/utilities/utdelete.c | |||
@@ -170,7 +170,6 @@ static void acpi_ut_delete_internal_obj(union acpi_operand_object *object) | |||
170 | acpi_os_delete_mutex(object->mutex.os_mutex); | 170 | acpi_os_delete_mutex(object->mutex.os_mutex); |
171 | acpi_gbl_global_lock_mutex = NULL; | 171 | acpi_gbl_global_lock_mutex = NULL; |
172 | } else { | 172 | } else { |
173 | acpi_ex_unlink_mutex(object); | ||
174 | acpi_os_delete_mutex(object->mutex.os_mutex); | 173 | acpi_os_delete_mutex(object->mutex.os_mutex); |
175 | } | 174 | } |
176 | break; | 175 | break; |
diff --git a/include/acpi/acinterp.h b/include/acpi/acinterp.h index ce7c9d653910..73967c8152d3 100644 --- a/include/acpi/acinterp.h +++ b/include/acpi/acinterp.h | |||
@@ -253,7 +253,8 @@ acpi_ex_release_mutex(union acpi_operand_object *obj_desc, | |||
253 | 253 | ||
254 | void acpi_ex_release_all_mutexes(struct acpi_thread_state *thread); | 254 | void acpi_ex_release_all_mutexes(struct acpi_thread_state *thread); |
255 | 255 | ||
256 | void acpi_ex_unlink_mutex(union acpi_operand_object *obj_desc); | 256 | void acpi_ex_unlink_mutex(union acpi_operand_object *obj_desc, |
257 | struct acpi_thread_state *thread); | ||
257 | 258 | ||
258 | /* | 259 | /* |
259 | * exprep - ACPI AML execution - prep utilities | 260 | * exprep - ACPI AML execution - prep utilities |
diff --git a/include/acpi/acobject.h b/include/acpi/acobject.h index 04e9735a6742..5206d61d74a6 100644 --- a/include/acpi/acobject.h +++ b/include/acpi/acobject.h | |||
@@ -155,7 +155,7 @@ struct acpi_object_event { | |||
155 | struct acpi_object_mutex { | 155 | struct acpi_object_mutex { |
156 | ACPI_OBJECT_COMMON_HEADER u8 sync_level; /* 0-15, specified in Mutex() call */ | 156 | ACPI_OBJECT_COMMON_HEADER u8 sync_level; /* 0-15, specified in Mutex() call */ |
157 | u16 acquisition_depth; /* Allow multiple Acquires, same thread */ | 157 | u16 acquisition_depth; /* Allow multiple Acquires, same thread */ |
158 | struct acpi_thread_state *owner_thread; /* Current owner of the mutex */ | 158 | acpi_thread_id owner_thread_id; /* Current owner of the mutex */ |
159 | acpi_mutex os_mutex; /* Actual OS synchronization object */ | 159 | acpi_mutex os_mutex; /* Actual OS synchronization object */ |
160 | union acpi_operand_object *prev; /* Link for list of acquired mutexes */ | 160 | union acpi_operand_object *prev; /* Link for list of acquired mutexes */ |
161 | union acpi_operand_object *next; /* Link for list of acquired mutexes */ | 161 | union acpi_operand_object *next; /* Link for list of acquired mutexes */ |