diff options
| -rw-r--r-- | drivers/s390/scsi/zfcp_def.h | 1 | ||||
| -rw-r--r-- | drivers/s390/scsi/zfcp_erp.c | 7 | ||||
| -rw-r--r-- | drivers/s390/scsi/zfcp_fc.c | 2 | ||||
| -rw-r--r-- | drivers/s390/scsi/zfcp_fsf.c | 3 |
4 files changed, 4 insertions, 9 deletions
diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h index 4f3b7a5ce7fe..abc44086d470 100644 --- a/drivers/s390/scsi/zfcp_def.h +++ b/drivers/s390/scsi/zfcp_def.h | |||
| @@ -244,7 +244,6 @@ struct zfcp_ls_adisc { | |||
| 244 | 244 | ||
| 245 | /* remote port status */ | 245 | /* remote port status */ |
| 246 | #define ZFCP_STATUS_PORT_PHYS_OPEN 0x00000001 | 246 | #define ZFCP_STATUS_PORT_PHYS_OPEN 0x00000001 |
| 247 | #define ZFCP_STATUS_PORT_DID_DID 0x00000002 | ||
| 248 | #define ZFCP_STATUS_PORT_PHYS_CLOSING 0x00000004 | 247 | #define ZFCP_STATUS_PORT_PHYS_CLOSING 0x00000004 |
| 249 | #define ZFCP_STATUS_PORT_NO_WWPN 0x00000008 | 248 | #define ZFCP_STATUS_PORT_NO_WWPN 0x00000008 |
| 250 | #define ZFCP_STATUS_PORT_INVALID_WWPN 0x00000020 | 249 | #define ZFCP_STATUS_PORT_INVALID_WWPN 0x00000020 |
diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c index 495a4a33e37d..387a3af528ac 100644 --- a/drivers/s390/scsi/zfcp_erp.c +++ b/drivers/s390/scsi/zfcp_erp.c | |||
| @@ -840,7 +840,6 @@ static int zfcp_erp_open_ptp_port(struct zfcp_erp_action *act) | |||
| 840 | return ZFCP_ERP_FAILED; | 840 | return ZFCP_ERP_FAILED; |
| 841 | } | 841 | } |
| 842 | port->d_id = adapter->peer_d_id; | 842 | port->d_id = adapter->peer_d_id; |
| 843 | atomic_set_mask(ZFCP_STATUS_PORT_DID_DID, &port->status); | ||
| 844 | return zfcp_erp_port_strategy_open_port(act); | 843 | return zfcp_erp_port_strategy_open_port(act); |
| 845 | } | 844 | } |
| 846 | 845 | ||
| @@ -871,12 +870,12 @@ static int zfcp_erp_port_strategy_open_common(struct zfcp_erp_action *act) | |||
| 871 | case ZFCP_ERP_STEP_PORT_CLOSING: | 870 | case ZFCP_ERP_STEP_PORT_CLOSING: |
| 872 | if (fc_host_port_type(adapter->scsi_host) == FC_PORTTYPE_PTP) | 871 | if (fc_host_port_type(adapter->scsi_host) == FC_PORTTYPE_PTP) |
| 873 | return zfcp_erp_open_ptp_port(act); | 872 | return zfcp_erp_open_ptp_port(act); |
| 874 | if (!(p_status & ZFCP_STATUS_PORT_DID_DID)) { | 873 | if (!port->d_id) { |
| 875 | queue_work(zfcp_data.work_queue, &port->gid_pn_work); | 874 | queue_work(zfcp_data.work_queue, &port->gid_pn_work); |
| 876 | return ZFCP_ERP_CONTINUES; | 875 | return ZFCP_ERP_CONTINUES; |
| 877 | } | 876 | } |
| 878 | case ZFCP_ERP_STEP_NAMESERVER_LOOKUP: | 877 | case ZFCP_ERP_STEP_NAMESERVER_LOOKUP: |
| 879 | if (!(p_status & ZFCP_STATUS_PORT_DID_DID)) { | 878 | if (!port->d_id) { |
| 880 | if (p_status & (ZFCP_STATUS_PORT_INVALID_WWPN)) { | 879 | if (p_status & (ZFCP_STATUS_PORT_INVALID_WWPN)) { |
| 881 | zfcp_erp_port_failed(port, 26, NULL); | 880 | zfcp_erp_port_failed(port, 26, NULL); |
| 882 | return ZFCP_ERP_EXIT; | 881 | return ZFCP_ERP_EXIT; |
| @@ -888,7 +887,7 @@ static int zfcp_erp_port_strategy_open_common(struct zfcp_erp_action *act) | |||
| 888 | case ZFCP_ERP_STEP_PORT_OPENING: | 887 | case ZFCP_ERP_STEP_PORT_OPENING: |
| 889 | /* D_ID might have changed during open */ | 888 | /* D_ID might have changed during open */ |
| 890 | if (p_status & ZFCP_STATUS_COMMON_OPEN) { | 889 | if (p_status & ZFCP_STATUS_COMMON_OPEN) { |
| 891 | if (p_status & ZFCP_STATUS_PORT_DID_DID) | 890 | if (port->d_id) |
| 892 | return ZFCP_ERP_SUCCEEDED; | 891 | return ZFCP_ERP_SUCCEEDED; |
| 893 | else { | 892 | else { |
| 894 | act->step = ZFCP_ERP_STEP_PORT_CLOSING; | 893 | act->step = ZFCP_ERP_STEP_PORT_CLOSING; |
diff --git a/drivers/s390/scsi/zfcp_fc.c b/drivers/s390/scsi/zfcp_fc.c index 396f05ed912f..217c3b04fd01 100644 --- a/drivers/s390/scsi/zfcp_fc.c +++ b/drivers/s390/scsi/zfcp_fc.c | |||
| @@ -265,7 +265,6 @@ static void zfcp_fc_ns_gid_pn_eval(unsigned long data) | |||
| 265 | return; | 265 | return; |
| 266 | /* looks like a valid d_id */ | 266 | /* looks like a valid d_id */ |
| 267 | port->d_id = ct_iu_resp->d_id & ZFCP_DID_MASK; | 267 | port->d_id = ct_iu_resp->d_id & ZFCP_DID_MASK; |
| 268 | atomic_set_mask(ZFCP_STATUS_PORT_DID_DID, &port->status); | ||
| 269 | } | 268 | } |
| 270 | 269 | ||
| 271 | int static zfcp_fc_ns_gid_pn_request(struct zfcp_erp_action *erp_action, | 270 | int static zfcp_fc_ns_gid_pn_request(struct zfcp_erp_action *erp_action, |
| @@ -588,7 +587,6 @@ static int zfcp_scan_eval_gpn_ft(struct zfcp_gpn_ft *gpn_ft) | |||
| 588 | } | 587 | } |
| 589 | 588 | ||
| 590 | port = zfcp_port_enqueue(adapter, acc->wwpn, | 589 | port = zfcp_port_enqueue(adapter, acc->wwpn, |
| 591 | ZFCP_STATUS_PORT_DID_DID | | ||
| 592 | ZFCP_STATUS_COMMON_NOESC, d_id); | 590 | ZFCP_STATUS_COMMON_NOESC, d_id); |
| 593 | if (IS_ERR(port)) | 591 | if (IS_ERR(port)) |
| 594 | ret = PTR_ERR(port); | 592 | ret = PTR_ERR(port); |
diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c index 878b8f86ddc7..17620ecda335 100644 --- a/drivers/s390/scsi/zfcp_fsf.c +++ b/drivers/s390/scsi/zfcp_fsf.c | |||
| @@ -1442,8 +1442,7 @@ static void zfcp_fsf_open_port_handler(struct zfcp_fsf_req *req) | |||
| 1442 | plogi = (struct fsf_plogi *) req->qtcb->bottom.support.els; | 1442 | plogi = (struct fsf_plogi *) req->qtcb->bottom.support.els; |
| 1443 | if (req->qtcb->bottom.support.els1_length >= sizeof(*plogi)) { | 1443 | if (req->qtcb->bottom.support.els1_length >= sizeof(*plogi)) { |
| 1444 | if (plogi->serv_param.wwpn != port->wwpn) | 1444 | if (plogi->serv_param.wwpn != port->wwpn) |
| 1445 | atomic_clear_mask(ZFCP_STATUS_PORT_DID_DID, | 1445 | port->d_id = 0; |
| 1446 | &port->status); | ||
| 1447 | else { | 1446 | else { |
| 1448 | port->wwnn = plogi->serv_param.wwnn; | 1447 | port->wwnn = plogi->serv_param.wwnn; |
| 1449 | zfcp_fc_plogi_evaluate(port, plogi); | 1448 | zfcp_fc_plogi_evaluate(port, plogi); |
