1 files changed, 12 insertions, 11 deletions

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index afd61d72837d..d1c1016cd505 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -1758,8 +1758,8 @@ static int nfs4_open_expired(struct nfs4_state_owner *sp, struct nfs4_state *sta
 #if defined(CONFIG_NFS_V4_1)
 static int nfs41_check_expired_stateid(struct nfs4_state *state, nfs4_stateid *stateid, unsigned int flags)
 {
-        int status = NFS_OK;
         struct nfs_server *server = NFS_SERVER(state->inode);
+        int status = -NFS4ERR_BAD_STATEID;
 
         if (state->flags & flags) {
                 status = nfs41_test_stateid(server, stateid);
@@ -1774,16 +1774,17 @@ static int nfs41_check_expired_stateid(struct nfs4_state *state, nfs4_stateid *s
 
 static int nfs41_open_expired(struct nfs4_state_owner *sp, struct nfs4_state *state)
 {
-        int deleg_status, open_status;
         int deleg_flags = 1 << NFS_DELEGATED_STATE;
         int open_flags = (1 << NFS_O_RDONLY_STATE) | (1 << NFS_O_WRONLY_STATE) | (1 << NFS_O_RDWR_STATE);
+        int status;
 
-        deleg_status = nfs41_check_expired_stateid(state, &state->stateid, deleg_flags);
-        open_status = nfs41_check_expired_stateid(state,  &state->open_stateid, open_flags);
+        nfs41_check_expired_stateid(state, &state->stateid, deleg_flags);
+        status = nfs41_check_expired_stateid(state, &state->open_stateid,
+                                                        open_flags);
 
-        if ((deleg_status == NFS_OK) && (open_status == NFS_OK))
-                return NFS_OK;
-        return nfs4_open_expired(sp, state);
+        if (status != NFS_OK)
+                status = nfs4_open_expired(sp, state);
+        return status;
 }
 #endif
 
@@ -4690,7 +4691,7 @@ out:
 #if defined(CONFIG_NFS_V4_1)
 static int nfs41_check_expired_locks(struct nfs4_state *state)
 {
-        int status, ret = NFS_OK;
+        int status, ret = -NFS4ERR_BAD_STATEID;
         struct nfs4_lock_state *lsp;
         struct nfs_server *server = NFS_SERVER(state->inode);
 
@@ -4716,9 +4717,9 @@ static int nfs41_lock_expired(struct nfs4_state *state, struct file_lock *reques
 
         if (test_bit(LK_STATE_IN_USE, &state->flags))
                 status = nfs41_check_expired_locks(state);
-        if (status == NFS_OK)
-                return status;
-        return nfs4_lock_expired(state, request);
+        if (status != NFS_OK)
+                status = nfs4_lock_expired(state, request);
+        return status;
 }
 #endif