diff options
-rw-r--r-- | drivers/net/ethernet/micrel/ks8851.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c index 13767eb36a48..f2bfc708880c 100644 --- a/drivers/net/ethernet/micrel/ks8851.c +++ b/drivers/net/ethernet/micrel/ks8851.c | |||
@@ -1417,7 +1417,7 @@ static int ks8851_probe(struct spi_device *spi) | |||
1417 | ks->spidev = spi; | 1417 | ks->spidev = spi; |
1418 | ks->tx_space = 6144; | 1418 | ks->tx_space = 6144; |
1419 | 1419 | ||
1420 | ks->vdd_reg = regulator_get_optional(&spi->dev, "vdd"); | 1420 | ks->vdd_reg = devm_regulator_get_optional(&spi->dev, "vdd"); |
1421 | if (IS_ERR(ks->vdd_reg)) { | 1421 | if (IS_ERR(ks->vdd_reg)) { |
1422 | ret = PTR_ERR(ks->vdd_reg); | 1422 | ret = PTR_ERR(ks->vdd_reg); |
1423 | if (ret == -EPROBE_DEFER) | 1423 | if (ret == -EPROBE_DEFER) |
@@ -1427,7 +1427,7 @@ static int ks8851_probe(struct spi_device *spi) | |||
1427 | if (ret) { | 1427 | if (ret) { |
1428 | dev_err(&spi->dev, "regulator enable fail: %d\n", | 1428 | dev_err(&spi->dev, "regulator enable fail: %d\n", |
1429 | ret); | 1429 | ret); |
1430 | goto err_reg_en; | 1430 | goto err_reg; |
1431 | } | 1431 | } |
1432 | } | 1432 | } |
1433 | 1433 | ||
@@ -1530,9 +1530,6 @@ err_irq: | |||
1530 | err_id: | 1530 | err_id: |
1531 | if (!IS_ERR(ks->vdd_reg)) | 1531 | if (!IS_ERR(ks->vdd_reg)) |
1532 | regulator_disable(ks->vdd_reg); | 1532 | regulator_disable(ks->vdd_reg); |
1533 | err_reg_en: | ||
1534 | if (!IS_ERR(ks->vdd_reg)) | ||
1535 | regulator_put(ks->vdd_reg); | ||
1536 | err_reg: | 1533 | err_reg: |
1537 | free_netdev(ndev); | 1534 | free_netdev(ndev); |
1538 | return ret; | 1535 | return ret; |
@@ -1547,10 +1544,8 @@ static int ks8851_remove(struct spi_device *spi) | |||
1547 | 1544 | ||
1548 | unregister_netdev(priv->netdev); | 1545 | unregister_netdev(priv->netdev); |
1549 | free_irq(spi->irq, priv); | 1546 | free_irq(spi->irq, priv); |
1550 | if (!IS_ERR(priv->vdd_reg)) { | 1547 | if (!IS_ERR(priv->vdd_reg)) |
1551 | regulator_disable(priv->vdd_reg); | 1548 | regulator_disable(priv->vdd_reg); |
1552 | regulator_put(priv->vdd_reg); | ||
1553 | } | ||
1554 | free_netdev(priv->netdev); | 1549 | free_netdev(priv->netdev); |
1555 | 1550 | ||
1556 | return 0; | 1551 | return 0; |