diff options
-rw-r--r-- | include/net/bluetooth/l2cap.h | 3 | ||||
-rw-r--r-- | net/bluetooth/l2cap_core.c | 17 | ||||
-rw-r--r-- | net/bluetooth/l2cap_sock.c | 10 |
3 files changed, 19 insertions, 11 deletions
diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h index 05bb254c9ebd..0ad61d069686 100644 --- a/include/net/bluetooth/l2cap.h +++ b/include/net/bluetooth/l2cap.h | |||
@@ -364,6 +364,7 @@ struct l2cap_ops { | |||
364 | 364 | ||
365 | struct l2cap_chan *(*new_connection) (void *data); | 365 | struct l2cap_chan *(*new_connection) (void *data); |
366 | int (*recv) (void *data, struct sk_buff *skb); | 366 | int (*recv) (void *data, struct sk_buff *skb); |
367 | void (*close) (void *data); | ||
367 | }; | 368 | }; |
368 | 369 | ||
369 | struct l2cap_conn { | 370 | struct l2cap_conn { |
@@ -469,8 +470,6 @@ int __l2cap_wait_ack(struct sock *sk); | |||
469 | int l2cap_add_psm(struct l2cap_chan *chan, bdaddr_t *src, __le16 psm); | 470 | int l2cap_add_psm(struct l2cap_chan *chan, bdaddr_t *src, __le16 psm); |
470 | int l2cap_add_scid(struct l2cap_chan *chan, __u16 scid); | 471 | int l2cap_add_scid(struct l2cap_chan *chan, __u16 scid); |
471 | 472 | ||
472 | void l2cap_sock_kill(struct sock *sk); | ||
473 | |||
474 | struct l2cap_chan *l2cap_chan_create(struct sock *sk); | 473 | struct l2cap_chan *l2cap_chan_create(struct sock *sk); |
475 | void l2cap_chan_close(struct l2cap_chan *chan, int reason); | 474 | void l2cap_chan_close(struct l2cap_chan *chan, int reason); |
476 | void l2cap_chan_destroy(struct l2cap_chan *chan); | 475 | void l2cap_chan_destroy(struct l2cap_chan *chan); |
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 4cbb48d523e4..3a121ac6b310 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c | |||
@@ -254,7 +254,7 @@ static void l2cap_chan_timeout(unsigned long arg) | |||
254 | 254 | ||
255 | bh_unlock_sock(sk); | 255 | bh_unlock_sock(sk); |
256 | 256 | ||
257 | l2cap_sock_kill(sk); | 257 | chan->ops->close(chan->data); |
258 | sock_put(sk); | 258 | sock_put(sk); |
259 | } | 259 | } |
260 | 260 | ||
@@ -391,11 +391,12 @@ static void l2cap_chan_cleanup_listen(struct sock *parent) | |||
391 | 391 | ||
392 | /* Close not yet accepted channels */ | 392 | /* Close not yet accepted channels */ |
393 | while ((sk = bt_accept_dequeue(parent, NULL))) { | 393 | while ((sk = bt_accept_dequeue(parent, NULL))) { |
394 | l2cap_chan_clear_timer(l2cap_pi(sk)->chan); | 394 | struct l2cap_chan *chan = l2cap_pi(sk)->chan; |
395 | l2cap_chan_clear_timer(chan); | ||
395 | lock_sock(sk); | 396 | lock_sock(sk); |
396 | l2cap_chan_close(l2cap_pi(sk)->chan, ECONNRESET); | 397 | l2cap_chan_close(chan, ECONNRESET); |
397 | release_sock(sk); | 398 | release_sock(sk); |
398 | l2cap_sock_kill(sk); | 399 | chan->ops->close(chan->data); |
399 | } | 400 | } |
400 | 401 | ||
401 | parent->sk_state = BT_CLOSED; | 402 | parent->sk_state = BT_CLOSED; |
@@ -993,7 +994,7 @@ static void l2cap_conn_del(struct hci_conn *hcon, int err) | |||
993 | bh_lock_sock(sk); | 994 | bh_lock_sock(sk); |
994 | l2cap_chan_del(chan, err); | 995 | l2cap_chan_del(chan, err); |
995 | bh_unlock_sock(sk); | 996 | bh_unlock_sock(sk); |
996 | l2cap_sock_kill(sk); | 997 | chan->ops->close(chan->data); |
997 | } | 998 | } |
998 | 999 | ||
999 | if (conn->info_state & L2CAP_INFO_FEAT_MASK_REQ_SENT) | 1000 | if (conn->info_state & L2CAP_INFO_FEAT_MASK_REQ_SENT) |
@@ -2339,7 +2340,7 @@ static inline int l2cap_connect_req(struct l2cap_conn *conn, struct l2cap_cmd_hd | |||
2339 | if (__l2cap_get_chan_by_dcid(conn, scid)) { | 2340 | if (__l2cap_get_chan_by_dcid(conn, scid)) { |
2340 | write_unlock_bh(&conn->chan_lock); | 2341 | write_unlock_bh(&conn->chan_lock); |
2341 | sock_set_flag(sk, SOCK_ZAPPED); | 2342 | sock_set_flag(sk, SOCK_ZAPPED); |
2342 | l2cap_sock_kill(sk); | 2343 | chan->ops->close(chan->data); |
2343 | goto response; | 2344 | goto response; |
2344 | } | 2345 | } |
2345 | 2346 | ||
@@ -2712,7 +2713,7 @@ static inline int l2cap_disconnect_req(struct l2cap_conn *conn, struct l2cap_cmd | |||
2712 | l2cap_chan_del(chan, ECONNRESET); | 2713 | l2cap_chan_del(chan, ECONNRESET); |
2713 | bh_unlock_sock(sk); | 2714 | bh_unlock_sock(sk); |
2714 | 2715 | ||
2715 | l2cap_sock_kill(sk); | 2716 | chan->ops->close(chan->data); |
2716 | return 0; | 2717 | return 0; |
2717 | } | 2718 | } |
2718 | 2719 | ||
@@ -2746,7 +2747,7 @@ static inline int l2cap_disconnect_rsp(struct l2cap_conn *conn, struct l2cap_cmd | |||
2746 | l2cap_chan_del(chan, 0); | 2747 | l2cap_chan_del(chan, 0); |
2747 | bh_unlock_sock(sk); | 2748 | bh_unlock_sock(sk); |
2748 | 2749 | ||
2749 | l2cap_sock_kill(sk); | 2750 | chan->ops->close(chan->data); |
2750 | return 0; | 2751 | return 0; |
2751 | } | 2752 | } |
2752 | 2753 | ||
diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c index 28cdc7e6df54..9f15a164993a 100644 --- a/net/bluetooth/l2cap_sock.c +++ b/net/bluetooth/l2cap_sock.c | |||
@@ -713,7 +713,7 @@ static int l2cap_sock_recvmsg(struct kiocb *iocb, struct socket *sock, struct ms | |||
713 | /* Kill socket (only if zapped and orphan) | 713 | /* Kill socket (only if zapped and orphan) |
714 | * Must be called on unlocked socket. | 714 | * Must be called on unlocked socket. |
715 | */ | 715 | */ |
716 | void l2cap_sock_kill(struct sock *sk) | 716 | static void l2cap_sock_kill(struct sock *sk) |
717 | { | 717 | { |
718 | if (!sock_flag(sk, SOCK_ZAPPED) || sk->sk_socket) | 718 | if (!sock_flag(sk, SOCK_ZAPPED) || sk->sk_socket) |
719 | return; | 719 | return; |
@@ -796,10 +796,18 @@ static int l2cap_sock_recv_cb(void *data, struct sk_buff *skb) | |||
796 | return sock_queue_rcv_skb(sk, skb); | 796 | return sock_queue_rcv_skb(sk, skb); |
797 | } | 797 | } |
798 | 798 | ||
799 | static void l2cap_sock_close_cb(void *data) | ||
800 | { | ||
801 | struct sock *sk = data; | ||
802 | |||
803 | l2cap_sock_kill(sk); | ||
804 | } | ||
805 | |||
799 | static struct l2cap_ops l2cap_chan_ops = { | 806 | static struct l2cap_ops l2cap_chan_ops = { |
800 | .name = "L2CAP Socket Interface", | 807 | .name = "L2CAP Socket Interface", |
801 | .new_connection = l2cap_sock_new_connection_cb, | 808 | .new_connection = l2cap_sock_new_connection_cb, |
802 | .recv = l2cap_sock_recv_cb, | 809 | .recv = l2cap_sock_recv_cb, |
810 | .close = l2cap_sock_close_cb, | ||
803 | }; | 811 | }; |
804 | 812 | ||
805 | static void l2cap_sock_destruct(struct sock *sk) | 813 | static void l2cap_sock_destruct(struct sock *sk) |