diff options
-rw-r--r-- | drivers/media/video/cx25840/cx25840-core.c | 10 | ||||
-rw-r--r-- | include/media/cx25840.h | 12 |
2 files changed, 22 insertions, 0 deletions
diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c index 25eb3bec9e5d..be467b4b9545 100644 --- a/drivers/media/video/cx25840/cx25840-core.c +++ b/drivers/media/video/cx25840/cx25840-core.c | |||
@@ -1101,6 +1101,16 @@ static void log_audio_status(struct i2c_client *client) | |||
1101 | 1101 | ||
1102 | /* ----------------------------------------------------------------------- */ | 1102 | /* ----------------------------------------------------------------------- */ |
1103 | 1103 | ||
1104 | /* This init operation must be called to load the driver's firmware. | ||
1105 | Without this the audio standard detection will fail and you will | ||
1106 | only get mono. | ||
1107 | |||
1108 | Since loading the firmware is often problematic when the driver is | ||
1109 | compiled into the kernel I recommend postponing calling this function | ||
1110 | until the first open of the video device. Another reason for | ||
1111 | postponing it is that loading this firmware takes a long time (seconds) | ||
1112 | due to the slow i2c bus speed. So it will speed up the boot process if | ||
1113 | you can avoid loading the fw as long as the video device isn't used. */ | ||
1104 | static int cx25840_init(struct v4l2_subdev *sd, u32 val) | 1114 | static int cx25840_init(struct v4l2_subdev *sd, u32 val) |
1105 | { | 1115 | { |
1106 | struct cx25840_state *state = to_state(sd); | 1116 | struct cx25840_state *state = to_state(sd); |
diff --git a/include/media/cx25840.h b/include/media/cx25840.h index db431d513f2f..2c3fbaa33f74 100644 --- a/include/media/cx25840.h +++ b/include/media/cx25840.h | |||
@@ -21,6 +21,18 @@ | |||
21 | #ifndef _CX25840_H_ | 21 | #ifndef _CX25840_H_ |
22 | #define _CX25840_H_ | 22 | #define _CX25840_H_ |
23 | 23 | ||
24 | /* Note that the cx25840 driver requires that the bridge driver calls the | ||
25 | v4l2_subdev's init operation in order to load the driver's firmware. | ||
26 | Without this the audio standard detection will fail and you will | ||
27 | only get mono. | ||
28 | |||
29 | Since loading the firmware is often problematic when the driver is | ||
30 | compiled into the kernel I recommend postponing calling this function | ||
31 | until the first open of the video device. Another reason for | ||
32 | postponing it is that loading this firmware takes a long time (seconds) | ||
33 | due to the slow i2c bus speed. So it will speed up the boot process if | ||
34 | you can avoid loading the fw as long as the video device isn't used. */ | ||
35 | |||
24 | enum cx25840_video_input { | 36 | enum cx25840_video_input { |
25 | /* Composite video inputs In1-In8 */ | 37 | /* Composite video inputs In1-In8 */ |
26 | CX25840_COMPOSITE1 = 1, | 38 | CX25840_COMPOSITE1 = 1, |