diff options
| -rw-r--r-- | tools/perf/util/event.c | 1 | ||||
| -rw-r--r-- | tools/perf/util/evlist.c | 4 | ||||
| -rw-r--r-- | tools/perf/util/probe-event.c | 6 | ||||
| -rw-r--r-- | tools/perf/util/probe-finder.c | 12 |
4 files changed, 22 insertions, 1 deletions
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c index 2044324b755a..2a6f33cd888c 100644 --- a/tools/perf/util/event.c +++ b/tools/perf/util/event.c | |||
| @@ -74,6 +74,7 @@ static pid_t perf_event__get_comm_tgid(pid_t pid, char *comm, size_t len) | |||
| 74 | if (size >= len) | 74 | if (size >= len) |
| 75 | size = len - 1; | 75 | size = len - 1; |
| 76 | memcpy(comm, name, size); | 76 | memcpy(comm, name, size); |
| 77 | comm[size] = '\0'; | ||
| 77 | 78 | ||
| 78 | } else if (memcmp(bf, "Tgid:", 5) == 0) { | 79 | } else if (memcmp(bf, "Tgid:", 5) == 0) { |
| 79 | char *tgids = bf + 5; | 80 | char *tgids = bf + 5; |
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 3f16e08a5c8d..ea32a061f1c8 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c | |||
| @@ -349,6 +349,10 @@ struct perf_evsel *perf_evlist__id2evsel(struct perf_evlist *evlist, u64 id) | |||
| 349 | hlist_for_each_entry(sid, pos, head, node) | 349 | hlist_for_each_entry(sid, pos, head, node) |
| 350 | if (sid->id == id) | 350 | if (sid->id == id) |
| 351 | return sid->evsel; | 351 | return sid->evsel; |
| 352 | |||
| 353 | if (!perf_evlist__sample_id_all(evlist)) | ||
| 354 | return list_entry(evlist->entries.next, struct perf_evsel, node); | ||
| 355 | |||
| 352 | return NULL; | 356 | return NULL; |
| 353 | } | 357 | } |
| 354 | 358 | ||
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 29cb65459811..e33554a562b3 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c | |||
| @@ -1867,6 +1867,12 @@ static int convert_to_probe_trace_events(struct perf_probe_event *pev, | |||
| 1867 | tev->point.symbol); | 1867 | tev->point.symbol); |
| 1868 | ret = -ENOENT; | 1868 | ret = -ENOENT; |
| 1869 | goto error; | 1869 | goto error; |
| 1870 | } else if (tev->point.offset > sym->end - sym->start) { | ||
| 1871 | pr_warning("Offset specified is greater than size of %s\n", | ||
| 1872 | tev->point.symbol); | ||
| 1873 | ret = -ENOENT; | ||
| 1874 | goto error; | ||
| 1875 | |||
| 1870 | } | 1876 | } |
| 1871 | 1877 | ||
| 1872 | return 1; | 1878 | return 1; |
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c index 5d732621a462..74bd2e63c4b4 100644 --- a/tools/perf/util/probe-finder.c +++ b/tools/perf/util/probe-finder.c | |||
| @@ -672,7 +672,7 @@ static int find_variable(Dwarf_Die *sc_die, struct probe_finder *pf) | |||
| 672 | static int convert_to_trace_point(Dwarf_Die *sp_die, Dwarf_Addr paddr, | 672 | static int convert_to_trace_point(Dwarf_Die *sp_die, Dwarf_Addr paddr, |
| 673 | bool retprobe, struct probe_trace_point *tp) | 673 | bool retprobe, struct probe_trace_point *tp) |
| 674 | { | 674 | { |
| 675 | Dwarf_Addr eaddr; | 675 | Dwarf_Addr eaddr, highaddr; |
| 676 | const char *name; | 676 | const char *name; |
| 677 | 677 | ||
| 678 | /* Copy the name of probe point */ | 678 | /* Copy the name of probe point */ |
| @@ -683,6 +683,16 @@ static int convert_to_trace_point(Dwarf_Die *sp_die, Dwarf_Addr paddr, | |||
| 683 | dwarf_diename(sp_die)); | 683 | dwarf_diename(sp_die)); |
| 684 | return -ENOENT; | 684 | return -ENOENT; |
| 685 | } | 685 | } |
| 686 | if (dwarf_highpc(sp_die, &highaddr) != 0) { | ||
| 687 | pr_warning("Failed to get end address of %s\n", | ||
| 688 | dwarf_diename(sp_die)); | ||
| 689 | return -ENOENT; | ||
| 690 | } | ||
| 691 | if (paddr > highaddr) { | ||
| 692 | pr_warning("Offset specified is greater than size of %s\n", | ||
| 693 | dwarf_diename(sp_die)); | ||
| 694 | return -EINVAL; | ||
| 695 | } | ||
| 686 | tp->symbol = strdup(name); | 696 | tp->symbol = strdup(name); |
| 687 | if (tp->symbol == NULL) | 697 | if (tp->symbol == NULL) |
| 688 | return -ENOMEM; | 698 | return -ENOMEM; |
