aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--fs/ocfs2/file.c6
-rw-r--r--fs/ocfs2/journal.c35
-rw-r--r--fs/ocfs2/journal.h11
-rw-r--r--fs/ocfs2/ocfs2_trace.h2
4 files changed, 49 insertions, 5 deletions
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 3261d71319ee..409c549ae02a 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -671,11 +671,7 @@ restarted_transaction:
671 } else { 671 } else {
672 BUG_ON(why != RESTART_TRANS); 672 BUG_ON(why != RESTART_TRANS);
673 673
674 /* TODO: This can be more intelligent. */ 674 status = ocfs2_allocate_extend_trans(handle, 1);
675 credits = ocfs2_calc_extend_credits(osb->sb,
676 &fe->id2.i_list,
677 clusters_to_add);
678 status = ocfs2_extend_trans(handle, credits);
679 if (status < 0) { 675 if (status < 0) {
680 /* handle still has to be committed at 676 /* handle still has to be committed at
681 * this point. */ 677 * this point. */
diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c
index 242170d83971..a126cb37ca4d 100644
--- a/fs/ocfs2/journal.c
+++ b/fs/ocfs2/journal.c
@@ -455,6 +455,41 @@ bail:
455 return status; 455 return status;
456} 456}
457 457
458/*
459 * If we have fewer than thresh credits, extend by OCFS2_MAX_TRANS_DATA.
460 * If that fails, restart the transaction & regain write access for the
461 * buffer head which is used for metadata modifications.
462 * Taken from Ext4: extend_or_restart_transaction()
463 */
464int ocfs2_allocate_extend_trans(handle_t *handle, int thresh)
465{
466 int status, old_nblks;
467
468 BUG_ON(!handle);
469
470 old_nblks = handle->h_buffer_credits;
471 trace_ocfs2_allocate_extend_trans(old_nblks, thresh);
472
473 if (old_nblks < thresh)
474 return 0;
475
476 status = jbd2_journal_extend(handle, OCFS2_MAX_TRANS_DATA);
477 if (status < 0) {
478 mlog_errno(status);
479 goto bail;
480 }
481
482 if (status > 0) {
483 status = jbd2_journal_restart(handle, OCFS2_MAX_TRANS_DATA);
484 if (status < 0)
485 mlog_errno(status);
486 }
487
488bail:
489 return status;
490}
491
492
458struct ocfs2_triggers { 493struct ocfs2_triggers {
459 struct jbd2_buffer_trigger_type ot_triggers; 494 struct jbd2_buffer_trigger_type ot_triggers;
460 int ot_offset; 495 int ot_offset;
diff --git a/fs/ocfs2/journal.h b/fs/ocfs2/journal.h
index 0a992737dcaf..0b479bab3671 100644
--- a/fs/ocfs2/journal.h
+++ b/fs/ocfs2/journal.h
@@ -258,6 +258,17 @@ handle_t *ocfs2_start_trans(struct ocfs2_super *osb,
258int ocfs2_commit_trans(struct ocfs2_super *osb, 258int ocfs2_commit_trans(struct ocfs2_super *osb,
259 handle_t *handle); 259 handle_t *handle);
260int ocfs2_extend_trans(handle_t *handle, int nblocks); 260int ocfs2_extend_trans(handle_t *handle, int nblocks);
261int ocfs2_allocate_extend_trans(handle_t *handle,
262 int thresh);
263
264/*
265 * Define an arbitrary limit for the amount of data we will anticipate
266 * writing to any given transaction. For unbounded transactions such as
267 * fallocate(2) we can write more than this, but we always
268 * start off at the maximum transaction size and grow the transaction
269 * optimistically as we go.
270 */
271#define OCFS2_MAX_TRANS_DATA 64U
261 272
262/* 273/*
263 * Create access is for when we get a newly created buffer and we're 274 * Create access is for when we get a newly created buffer and we're
diff --git a/fs/ocfs2/ocfs2_trace.h b/fs/ocfs2/ocfs2_trace.h
index 3b481f490633..1b60c62aa9d6 100644
--- a/fs/ocfs2/ocfs2_trace.h
+++ b/fs/ocfs2/ocfs2_trace.h
@@ -2579,6 +2579,8 @@ DEFINE_OCFS2_INT_INT_EVENT(ocfs2_extend_trans);
2579 2579
2580DEFINE_OCFS2_INT_EVENT(ocfs2_extend_trans_restart); 2580DEFINE_OCFS2_INT_EVENT(ocfs2_extend_trans_restart);
2581 2581
2582DEFINE_OCFS2_INT_INT_EVENT(ocfs2_allocate_extend_trans);
2583
2582DEFINE_OCFS2_ULL_ULL_UINT_UINT_EVENT(ocfs2_journal_access); 2584DEFINE_OCFS2_ULL_ULL_UINT_UINT_EVENT(ocfs2_journal_access);
2583 2585
2584DEFINE_OCFS2_ULL_EVENT(ocfs2_journal_dirty); 2586DEFINE_OCFS2_ULL_EVENT(ocfs2_journal_dirty);