diff options
-rw-r--r-- | drivers/net/macb.c | 24 |
1 files changed, 3 insertions, 21 deletions
diff --git a/drivers/net/macb.c b/drivers/net/macb.c index a41418b3c518..2e9571bf0736 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c | |||
@@ -881,27 +881,15 @@ static struct net_device_stats *macb_get_stats(struct net_device *dev) | |||
881 | static int macb_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) | 881 | static int macb_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) |
882 | { | 882 | { |
883 | struct macb *bp = netdev_priv(dev); | 883 | struct macb *bp = netdev_priv(dev); |
884 | int ret; | ||
885 | unsigned long flags; | ||
886 | |||
887 | spin_lock_irqsave(&bp->lock, flags); | ||
888 | ret = mii_ethtool_gset(&bp->mii, cmd); | ||
889 | spin_unlock_irqrestore(&bp->lock, flags); | ||
890 | 884 | ||
891 | return ret; | 885 | return mii_ethtool_gset(&bp->mii, cmd); |
892 | } | 886 | } |
893 | 887 | ||
894 | static int macb_set_settings(struct net_device *dev, struct ethtool_cmd *cmd) | 888 | static int macb_set_settings(struct net_device *dev, struct ethtool_cmd *cmd) |
895 | { | 889 | { |
896 | struct macb *bp = netdev_priv(dev); | 890 | struct macb *bp = netdev_priv(dev); |
897 | int ret; | ||
898 | unsigned long flags; | ||
899 | |||
900 | spin_lock_irqsave(&bp->lock, flags); | ||
901 | ret = mii_ethtool_sset(&bp->mii, cmd); | ||
902 | spin_unlock_irqrestore(&bp->lock, flags); | ||
903 | 891 | ||
904 | return ret; | 892 | return mii_ethtool_sset(&bp->mii, cmd); |
905 | } | 893 | } |
906 | 894 | ||
907 | static void macb_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) | 895 | static void macb_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) |
@@ -930,17 +918,11 @@ static struct ethtool_ops macb_ethtool_ops = { | |||
930 | static int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) | 918 | static int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) |
931 | { | 919 | { |
932 | struct macb *bp = netdev_priv(dev); | 920 | struct macb *bp = netdev_priv(dev); |
933 | int ret; | ||
934 | unsigned long flags; | ||
935 | 921 | ||
936 | if (!netif_running(dev)) | 922 | if (!netif_running(dev)) |
937 | return -EINVAL; | 923 | return -EINVAL; |
938 | 924 | ||
939 | spin_lock_irqsave(&bp->lock, flags); | 925 | return generic_mii_ioctl(&bp->mii, if_mii(rq), cmd, NULL); |
940 | ret = generic_mii_ioctl(&bp->mii, if_mii(rq), cmd, NULL); | ||
941 | spin_unlock_irqrestore(&bp->lock, flags); | ||
942 | |||
943 | return ret; | ||
944 | } | 926 | } |
945 | 927 | ||
946 | static ssize_t macb_mii_show(const struct device *_dev, char *buf, | 928 | static ssize_t macb_mii_show(const struct device *_dev, char *buf, |