diff options
-rw-r--r-- | net/core/rtnetlink.c | 4 | ||||
-rw-r--r-- | net/netlink/af_netlink.c | 4 | ||||
-rw-r--r-- | net/netlink/genetlink.c | 6 | ||||
-rw-r--r-- | net/xfrm/xfrm_user.c | 4 |
4 files changed, 4 insertions, 14 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index cc09283fd76a..b2136accd267 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c | |||
@@ -864,10 +864,6 @@ rtnetlink_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, int *errp) | |||
864 | 864 | ||
865 | type = nlh->nlmsg_type; | 865 | type = nlh->nlmsg_type; |
866 | 866 | ||
867 | /* A control message: ignore them */ | ||
868 | if (type < RTM_BASE) | ||
869 | return 0; | ||
870 | |||
871 | /* Unknown message: reply with EINVAL */ | 867 | /* Unknown message: reply with EINVAL */ |
872 | if (type > RTM_MAX) | 868 | if (type > RTM_MAX) |
873 | goto err_inval; | 869 | goto err_inval; |
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 7b455980e9bf..5d1079b1838c 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c | |||
@@ -1479,6 +1479,10 @@ static int netlink_rcv_skb(struct sk_buff *skb, int (*cb)(struct sk_buff *, | |||
1479 | if (!(nlh->nlmsg_flags & NLM_F_REQUEST)) | 1479 | if (!(nlh->nlmsg_flags & NLM_F_REQUEST)) |
1480 | goto skip; | 1480 | goto skip; |
1481 | 1481 | ||
1482 | /* Skip control messages */ | ||
1483 | if (nlh->nlmsg_type < NLMSG_MIN_TYPE) | ||
1484 | goto skip; | ||
1485 | |||
1482 | if (cb(skb, nlh, &err) < 0) { | 1486 | if (cb(skb, nlh, &err) < 0) { |
1483 | /* Not an error, but we have to interrupt processing | 1487 | /* Not an error, but we have to interrupt processing |
1484 | * here. Note: that in this case we do not pull | 1488 | * here. Note: that in this case we do not pull |
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 039516f6cd80..95391e609046 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c | |||
@@ -304,9 +304,6 @@ static int genl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, | |||
304 | struct genlmsghdr *hdr = nlmsg_data(nlh); | 304 | struct genlmsghdr *hdr = nlmsg_data(nlh); |
305 | int hdrlen, err = -EINVAL; | 305 | int hdrlen, err = -EINVAL; |
306 | 306 | ||
307 | if (nlh->nlmsg_type < NLMSG_MIN_TYPE) | ||
308 | goto ignore; | ||
309 | |||
310 | family = genl_family_find_byid(nlh->nlmsg_type); | 307 | family = genl_family_find_byid(nlh->nlmsg_type); |
311 | if (family == NULL) { | 308 | if (family == NULL) { |
312 | err = -ENOENT; | 309 | err = -ENOENT; |
@@ -364,9 +361,6 @@ static int genl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, | |||
364 | *errp = err = ops->doit(skb, &info); | 361 | *errp = err = ops->doit(skb, &info); |
365 | return err; | 362 | return err; |
366 | 363 | ||
367 | ignore: | ||
368 | return 0; | ||
369 | |||
370 | errout: | 364 | errout: |
371 | *errp = err; | 365 | *errp = err; |
372 | return -1; | 366 | return -1; |
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 913c8b727d8f..4d2f2094e6df 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c | |||
@@ -1860,10 +1860,6 @@ static int xfrm_user_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, int *err | |||
1860 | 1860 | ||
1861 | type = nlh->nlmsg_type; | 1861 | type = nlh->nlmsg_type; |
1862 | 1862 | ||
1863 | /* A control message: ignore them */ | ||
1864 | if (type < XFRM_MSG_BASE) | ||
1865 | return 0; | ||
1866 | |||
1867 | /* Unknown message: reply with EINVAL */ | 1863 | /* Unknown message: reply with EINVAL */ |
1868 | if (type > XFRM_MSG_MAX) | 1864 | if (type > XFRM_MSG_MAX) |
1869 | goto err_einval; | 1865 | goto err_einval; |