13 files changed, 59 insertions, 57 deletions

diff --git a/sound/ac97_bus.c b/sound/ac97_bus.c
index 7fa37e15f196..a351dd0a09c7 100644
--- a/sound/ac97_bus.c
+++ b/sound/ac97_bus.c
@@ -15,6 +15,7 @@
 #include <linux/init.h>
 #include <linux/device.h>
 #include <linux/string.h>
+#include <sound/ac97_codec.h>
 
 /*
  * Let drivers decide whether they want to support given codec from their
diff --git a/sound/drivers/Kconfig b/sound/drivers/Kconfig
index 255fd18b9aec..0bcf14640fde 100644
--- a/sound/drivers/Kconfig
+++ b/sound/drivers/Kconfig
@@ -163,7 +163,7 @@ config SND_ML403_AC97CR
 
 config SND_AC97_POWER_SAVE
         bool "AC97 Power-Saving Mode"
-        depends on SND_AC97_CODEC && EXPERIMENTAL
+        depends on SND_AC97_CODEC
         default n
         help
           Say Y here to enable the aggressive power-saving support of
diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c
index 667eccc676a4..ea06877be4b1 100644
--- a/sound/isa/sb/sb8.c
+++ b/sound/isa/sb/sb8.c
@@ -140,8 +140,10 @@ static int __devinit snd_sb8_probe(struct device *pdev, unsigned int dev)
                                 break;
                         }
                 }
-                if (i >= ARRAY_SIZE(possible_ports))
+                if (i >= ARRAY_SIZE(possible_ports)) {
+                        err = -EINVAL;
                         goto _err;
+                }
         }
         acard->chip = chip;
                         
diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
index bd510eceff1f..e2b843b4f9d0 100644
--- a/sound/pci/ac97/ac97_codec.c
+++ b/sound/pci/ac97/ac97_codec.c
@@ -175,7 +175,7 @@ static const struct ac97_codec_id snd_ac97_codec_ids[] = {
 { 0x574d4C04, 0xffffffff, "WM9704M,WM9704Q",    patch_wolfson04, NULL},
 { 0x574d4C05, 0xffffffff, "WM9705,WM9710",      patch_wolfson05, NULL},
 { 0x574d4C09, 0xffffffff, "WM9709",             NULL,           NULL},
-{ 0x574d4C12, 0xffffffff, "WM9711,WM9712",      patch_wolfson11, NULL},
+{ 0x574d4C12, 0xffffffff, "WM9711,WM9712,WM9715",       patch_wolfson11, NULL},
 { 0x574d4c13, 0xffffffff, "WM9713,WM9714",      patch_wolfson13, NULL, AC97_DEFAULT_POWER_OFF},
 { 0x594d4800, 0xffffffff, "YMF743",             patch_yamaha_ymf743,    NULL },
 { 0x594d4802, 0xffffffff, "YMF752",             NULL,           NULL },
diff --git a/sound/pci/ca0106/ca0106.h b/sound/pci/ca0106/ca0106.h
index 74175fc80c7f..3faccb6ecad9 100644
--- a/sound/pci/ca0106/ca0106.h
+++ b/sound/pci/ca0106/ca0106.h
@@ -664,10 +664,14 @@ struct snd_ca0106_pcm {
 struct snd_ca0106_details {
         u32 serial;
         char * name;
-        int ac97;
-        int gpio_type;
-        int i2c_adc;
-        int spi_dac;
+        int ac97;       /* ac97 = 0 -> Select MIC, Line in, TAD in, AUX in.
+                           ac97 = 1 -> Default to AC97 in. */
+        int gpio_type;  /* gpio_type = 1 -> shared mic-in/line-in
+                           gpio_type = 2 -> shared side-out/line-in. */
+        int i2c_adc;    /* with i2c_adc=1, the driver adds some capture volume
+                           controls, phone, mic, line-in and aux. */
+        int spi_dac;    /* spi_dac=1 adds the mute switch for each analog
+                           output, front, rear, etc. */
 };
 
 // definition of the chip-specific record
diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
index 88fbf285d2b7..6ac19364631b 100644
--- a/sound/pci/ca0106/ca0106_main.c
+++ b/sound/pci/ca0106/ca0106_main.c
@@ -254,7 +254,7 @@ static struct snd_ca0106_details ca0106_chip_details[] = {
            .name   = "MSI K8N Diamond MB",
            .gpio_type = 2,
            .i2c_adc = 1,
-           .spi_dac = 2 } ,
+           .spi_dac = 1 } ,
          /* Shuttle XPC SD31P which has an onboard Creative Labs
           * Sound Blaster Live! 24-bit EAX
           * high-definition 7.1 audio processor".
diff --git a/sound/pci/cs46xx/cs46xx_lib.c b/sound/pci/cs46xx/cs46xx_lib.c
index fb6dc3980257..8ab07aa63652 100644
--- a/sound/pci/cs46xx/cs46xx_lib.c
+++ b/sound/pci/cs46xx/cs46xx_lib.c
@@ -3640,7 +3640,10 @@ int snd_cs46xx_resume(struct pci_dev *pci)
 {
         struct snd_card *card = pci_get_drvdata(pci);
         struct snd_cs46xx *chip = card->private_data;
-        int i, amp_saved;
+        int amp_saved;
+#ifdef CONFIG_SND_CS46XX_NEW_DSP
+        int i;
+#endif
 
         pci_set_power_state(pci, PCI_D0);
         pci_restore_state(pci);
diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index ae7601f353a7..f23a73577c22 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -1010,7 +1010,7 @@ static int __devinit snd_mixart_create(struct mixart_mgr *mgr, struct snd_card *
                 .dev_free = snd_mixart_chip_dev_free,
         };
 
-        mgr->chip[idx] = chip = kzalloc(sizeof(*chip), GFP_KERNEL);
+        chip = kzalloc(sizeof(*chip), GFP_KERNEL);
         if (! chip) {
                 snd_printk(KERN_ERR "cannot allocate chip\n");
                 return -ENOMEM;
@@ -1025,6 +1025,7 @@ static int __devinit snd_mixart_create(struct mixart_mgr *mgr, struct snd_card *
                 return err;
         }
 
+        mgr->chip[idx] = chip;
         snd_card_set_dev(card, &mgr->pci->dev);
 
         return 0;
@@ -1377,6 +1378,7 @@ static int __devinit snd_mixart_probe(struct pci_dev *pci,
                 sprintf(card->longname, "%s [PCM #%d]", mgr->longname, i);
 
                 if ((err = snd_mixart_create(mgr, card, i)) < 0) {
+                        snd_card_free(card);
                         snd_mixart_free(mgr);
                         return err;
                 }
diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c
index 73de6e989b3d..7d2b136295d5 100644
--- a/sound/pci/pcxhr/pcxhr.c
+++ b/sound/pci/pcxhr/pcxhr.c
@@ -1024,7 +1024,7 @@ static int __devinit pcxhr_create(struct pcxhr_mgr *mgr, struct snd_card *card,
                 .dev_free = pcxhr_chip_dev_free,
         };
 
-        mgr->chip[idx] = chip = kzalloc(sizeof(*chip), GFP_KERNEL);
+        chip = kzalloc(sizeof(*chip), GFP_KERNEL);
         if (! chip) {
                 snd_printk(KERN_ERR "cannot allocate chip\n");
                 return -ENOMEM;
@@ -1050,6 +1050,7 @@ static int __devinit pcxhr_create(struct pcxhr_mgr *mgr, struct snd_card *card,
                 return err;
         }
 
+        mgr->chip[idx] = chip;
         snd_card_set_dev(card, &mgr->pci->dev);
 
         return 0;
@@ -1310,6 +1311,7 @@ static int __devinit pcxhr_probe(struct pci_dev *pci, const struct pci_device_id
                 sprintf(card->longname, "%s [PCM #%d]", mgr->longname, i);
 
                 if ((err = pcxhr_create(mgr, card, i)) < 0) {
+                        snd_card_free(card);
                         pcxhr_free(mgr);
                         return err;
                 }
diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
index e9f0706ed3e4..d0ccfc68c522 100644
--- a/sound/pci/riptide/riptide.c
+++ b/sound/pci/riptide/riptide.c
@@ -172,7 +172,7 @@ MODULE_PARM_DESC(opl3_port, "OPL3 port # for Riptide driver.");
 
 #define MAX_WRITE_RETRY  10     /* cmd interface limits */
 #define MAX_ERROR_COUNT  10
-#define CMDIF_TIMEOUT    500000
+#define CMDIF_TIMEOUT    50000
 #define RESET_TRIES      5
 
 #define READ_PORT_ULONG(p)     inl((unsigned long)&(p))
diff --git a/sound/usb/caiaq/caiaq-control.c b/sound/usb/caiaq/caiaq-control.c
index 798ca124da58..ccd763dd7167 100644
--- a/sound/usb/caiaq/caiaq-control.c
+++ b/sound/usb/caiaq/caiaq-control.c
@@ -247,69 +247,56 @@ static struct caiaq_controller a8dj_controller[] = {
         { "Software lock",                      40              }
 };
 
-int __devinit snd_usb_caiaq_control_init(struct snd_usb_caiaqdev *dev)
+static int __devinit add_controls(struct caiaq_controller *c, int num,
+                                  struct snd_usb_caiaqdev *dev)
 {
-        int i;
+        int i, ret;
         struct snd_kcontrol *kc;
 
+        for (i = 0; i < num; i++, c++) {
+                kcontrol_template.name = c->name;
+                kcontrol_template.private_value = c->index;
+                kc = snd_ctl_new1(&kcontrol_template, dev);
+                ret = snd_ctl_add(dev->chip.card, kc);
+                if (ret < 0)
+                        return ret;
+        }
+
+        return 0;
+}
+
+int __devinit snd_usb_caiaq_control_init(struct snd_usb_caiaqdev *dev)
+{
+        int ret = 0;
+
         switch (dev->chip.usb_id) {
         case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AK1):
-                for (i = 0; i < ARRAY_SIZE(ak1_controller); i++) {
-                        struct caiaq_controller *c = ak1_controller + i;
-                        kcontrol_template.name = c->name;
-                        kcontrol_template.private_value = c->index;
-                        kc = snd_ctl_new1(&kcontrol_template, dev);
-                        snd_ctl_add(dev->chip.card, kc);
-                }
-
+                ret = add_controls(ak1_controller,
+                        ARRAY_SIZE(ak1_controller), dev);
                 break;
 
         case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_RIGKONTROL2):
-                for (i = 0; i < ARRAY_SIZE(rk2_controller); i++) {
-                        struct caiaq_controller *c = rk2_controller + i;
-                        kcontrol_template.name = c->name;
-                        kcontrol_template.private_value = c->index;
-                        kc = snd_ctl_new1(&kcontrol_template, dev);
-                        snd_ctl_add(dev->chip.card, kc);
-                }
-
+                ret = add_controls(rk2_controller,
+                        ARRAY_SIZE(rk2_controller), dev);
                 break;
 
         case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_RIGKONTROL3):
-                for (i = 0; i < ARRAY_SIZE(rk3_controller); i++) {
-                        struct caiaq_controller *c = rk3_controller + i;
-                        kcontrol_template.name = c->name;
-                        kcontrol_template.private_value = c->index;
-                        kc = snd_ctl_new1(&kcontrol_template, dev);
-                        snd_ctl_add(dev->chip.card, kc);
-                }
-
+                ret = add_controls(rk3_controller,
+                        ARRAY_SIZE(rk3_controller), dev);
                 break;
 
         case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_KORECONTROLLER):
         case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_KORECONTROLLER2):
-                for (i = 0; i < ARRAY_SIZE(kore_controller); i++) {
-                        struct caiaq_controller *c = kore_controller + i;
-                        kcontrol_template.name = c->name;
-                        kcontrol_template.private_value = c->index;
-                        kc = snd_ctl_new1(&kcontrol_template, dev);
-                        snd_ctl_add(dev->chip.card, kc);
-                }
-
+                ret = add_controls(kore_controller,
+                        ARRAY_SIZE(kore_controller), dev);
                 break;
 
         case USB_ID(USB_VID_NATIVEINSTRUMENTS, USB_PID_AUDIO8DJ):
-                for (i = 0; i < ARRAY_SIZE(a8dj_controller); i++) {
-                        struct caiaq_controller *c = a8dj_controller + i;
-                        kcontrol_template.name = c->name;
-                        kcontrol_template.private_value = c->index;
-                        kc = snd_ctl_new1(&kcontrol_template, dev);
-                        snd_ctl_add(dev->chip.card, kc);
-                }
-
+                ret = add_controls(a8dj_controller,
+                        ARRAY_SIZE(a8dj_controller), dev);
                 break;
         }
 
-        return 0;
+        return ret;
 }
 
diff --git a/sound/usb/caiaq/caiaq-device.c b/sound/usb/caiaq/caiaq-device.c
index 83175083e50f..b143ef7152f7 100644
--- a/sound/usb/caiaq/caiaq-device.c
+++ b/sound/usb/caiaq/caiaq-device.c
@@ -42,7 +42,7 @@
 #endif
 
 MODULE_AUTHOR("Daniel Mack <daniel@caiaq.de>");
-MODULE_DESCRIPTION("caiaq USB audio, version 1.3.8");
+MODULE_DESCRIPTION("caiaq USB audio, version 1.3.9");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("{{Native Instruments, RigKontrol2},"
                          "{Native Instruments, RigKontrol3},"
diff --git a/sound/usb/usx2y/usb_stream.c b/sound/usb/usx2y/usb_stream.c
index ff23cc1ce3b9..70b96355ca4c 100644
--- a/sound/usb/usx2y/usb_stream.c
+++ b/sound/usb/usx2y/usb_stream.c
@@ -276,7 +276,8 @@ static void subs_set_complete(struct urb **urbs, void (*complete)(struct urb *))
         }
 }
 
-int usb_stream_prepare_playback(struct usb_stream_kernel *sk, struct urb *inurb)
+static int usb_stream_prepare_playback(struct usb_stream_kernel *sk,
+                struct urb *inurb)
 {
         struct usb_stream *s = sk->s;
         struct urb *io;