diff options
| -rw-r--r-- | fs/file_table.c | 9 | ||||
| -rw-r--r-- | fs/notify/fanotify/fanotify.c | 8 | ||||
| -rw-r--r-- | fs/notify/fanotify/fanotify_user.c | 6 | ||||
| -rw-r--r-- | fs/notify/fsnotify.c | 12 | ||||
| -rw-r--r-- | fs/notify/inotify/inotify_fsnotify.c | 12 | ||||
| -rw-r--r-- | fs/notify/notification.c | 33 | ||||
| -rw-r--r-- | include/linux/fsnotify.h | 37 | ||||
| -rw-r--r-- | include/linux/fsnotify_backend.h | 16 | ||||
| -rw-r--r-- | kernel/audit_watch.c | 4 |
9 files changed, 61 insertions, 76 deletions
diff --git a/fs/file_table.c b/fs/file_table.c index 2fc3b3c08911..edecd36fed9b 100644 --- a/fs/file_table.c +++ b/fs/file_table.c | |||
| @@ -230,15 +230,6 @@ static void __fput(struct file *file) | |||
| 230 | might_sleep(); | 230 | might_sleep(); |
| 231 | 231 | ||
| 232 | fsnotify_close(file); | 232 | fsnotify_close(file); |
| 233 | |||
| 234 | /* | ||
| 235 | * fsnotify_create_event may have taken one or more references on this | ||
| 236 | * file. If it did so it left one reference for us to drop to make sure | ||
| 237 | * its calls to fput could not prematurely destroy the file. | ||
| 238 | */ | ||
| 239 | if (atomic_long_read(&file->f_count)) | ||
| 240 | return fput(file); | ||
| 241 | |||
| 242 | /* | 233 | /* |
| 243 | * The function eventpoll_release() should be the first called | 234 | * The function eventpoll_release() should be the first called |
| 244 | * in the file cleanup chain. | 235 | * in the file cleanup chain. |
diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c index eb8f73c9c131..756566fe8449 100644 --- a/fs/notify/fanotify/fanotify.c +++ b/fs/notify/fanotify/fanotify.c | |||
| @@ -17,9 +17,9 @@ static bool should_merge(struct fsnotify_event *old, struct fsnotify_event *new) | |||
| 17 | old->data_type == new->data_type && | 17 | old->data_type == new->data_type && |
| 18 | old->tgid == new->tgid) { | 18 | old->tgid == new->tgid) { |
| 19 | switch (old->data_type) { | 19 | switch (old->data_type) { |
| 20 | case (FSNOTIFY_EVENT_FILE): | 20 | case (FSNOTIFY_EVENT_PATH): |
| 21 | if ((old->file->f_path.mnt == new->file->f_path.mnt) && | 21 | if ((old->path.mnt == new->path.mnt) && |
| 22 | (old->file->f_path.dentry == new->file->f_path.dentry)) | 22 | (old->path.dentry == new->path.dentry)) |
| 23 | return true; | 23 | return true; |
| 24 | case (FSNOTIFY_EVENT_NONE): | 24 | case (FSNOTIFY_EVENT_NONE): |
| 25 | return true; | 25 | return true; |
| @@ -174,7 +174,7 @@ static bool fanotify_should_send_event(struct fsnotify_group *group, | |||
| 174 | return false; | 174 | return false; |
| 175 | 175 | ||
| 176 | /* if we don't have enough info to send an event to userspace say no */ | 176 | /* if we don't have enough info to send an event to userspace say no */ |
| 177 | if (data_type != FSNOTIFY_EVENT_FILE) | 177 | if (data_type != FSNOTIFY_EVENT_PATH) |
| 178 | return false; | 178 | return false; |
| 179 | 179 | ||
| 180 | if (inode_mark && vfsmnt_mark) { | 180 | if (inode_mark && vfsmnt_mark) { |
diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c index 25a3b4dfcf61..032b837fcd11 100644 --- a/fs/notify/fanotify/fanotify_user.c +++ b/fs/notify/fanotify/fanotify_user.c | |||
| @@ -65,7 +65,7 @@ static int create_fd(struct fsnotify_group *group, struct fsnotify_event *event) | |||
| 65 | if (client_fd < 0) | 65 | if (client_fd < 0) |
| 66 | return client_fd; | 66 | return client_fd; |
| 67 | 67 | ||
| 68 | if (event->data_type != FSNOTIFY_EVENT_FILE) { | 68 | if (event->data_type != FSNOTIFY_EVENT_PATH) { |
| 69 | WARN_ON(1); | 69 | WARN_ON(1); |
| 70 | put_unused_fd(client_fd); | 70 | put_unused_fd(client_fd); |
| 71 | return -EINVAL; | 71 | return -EINVAL; |
| @@ -75,8 +75,8 @@ static int create_fd(struct fsnotify_group *group, struct fsnotify_event *event) | |||
| 75 | * we need a new file handle for the userspace program so it can read even if it was | 75 | * we need a new file handle for the userspace program so it can read even if it was |
| 76 | * originally opened O_WRONLY. | 76 | * originally opened O_WRONLY. |
| 77 | */ | 77 | */ |
| 78 | dentry = dget(event->file->f_path.dentry); | 78 | dentry = dget(event->path.dentry); |
| 79 | mnt = mntget(event->file->f_path.mnt); | 79 | mnt = mntget(event->path.mnt); |
| 80 | /* it's possible this event was an overflow event. in that case dentry and mnt | 80 | /* it's possible this event was an overflow event. in that case dentry and mnt |
| 81 | * are NULL; That's fine, just don't call dentry open */ | 81 | * are NULL; That's fine, just don't call dentry open */ |
| 82 | if (dentry && mnt) | 82 | if (dentry && mnt) |
diff --git a/fs/notify/fsnotify.c b/fs/notify/fsnotify.c index 4d2a82c1ceb1..3970392b2722 100644 --- a/fs/notify/fsnotify.c +++ b/fs/notify/fsnotify.c | |||
| @@ -84,7 +84,7 @@ void __fsnotify_update_child_dentry_flags(struct inode *inode) | |||
| 84 | } | 84 | } |
| 85 | 85 | ||
| 86 | /* Notify this dentry's parent about a child's events. */ | 86 | /* Notify this dentry's parent about a child's events. */ |
| 87 | void __fsnotify_parent(struct file *file, struct dentry *dentry, __u32 mask) | 87 | void __fsnotify_parent(struct path *path, struct dentry *dentry, __u32 mask) |
| 88 | { | 88 | { |
| 89 | struct dentry *parent; | 89 | struct dentry *parent; |
| 90 | struct inode *p_inode; | 90 | struct inode *p_inode; |
| @@ -92,7 +92,7 @@ void __fsnotify_parent(struct file *file, struct dentry *dentry, __u32 mask) | |||
| 92 | bool should_update_children = false; | 92 | bool should_update_children = false; |
| 93 | 93 | ||
| 94 | if (!dentry) | 94 | if (!dentry) |
| 95 | dentry = file->f_path.dentry; | 95 | dentry = path->dentry; |
| 96 | 96 | ||
| 97 | if (!(dentry->d_flags & DCACHE_FSNOTIFY_PARENT_WATCHED)) | 97 | if (!(dentry->d_flags & DCACHE_FSNOTIFY_PARENT_WATCHED)) |
| 98 | return; | 98 | return; |
| @@ -124,8 +124,8 @@ void __fsnotify_parent(struct file *file, struct dentry *dentry, __u32 mask) | |||
| 124 | * specifies these are events which came from a child. */ | 124 | * specifies these are events which came from a child. */ |
| 125 | mask |= FS_EVENT_ON_CHILD; | 125 | mask |= FS_EVENT_ON_CHILD; |
| 126 | 126 | ||
| 127 | if (file) | 127 | if (path) |
| 128 | fsnotify(p_inode, mask, file, FSNOTIFY_EVENT_FILE, | 128 | fsnotify(p_inode, mask, path, FSNOTIFY_EVENT_PATH, |
| 129 | dentry->d_name.name, 0); | 129 | dentry->d_name.name, 0); |
| 130 | else | 130 | else |
| 131 | fsnotify(p_inode, mask, dentry->d_inode, FSNOTIFY_EVENT_INODE, | 131 | fsnotify(p_inode, mask, dentry->d_inode, FSNOTIFY_EVENT_INODE, |
| @@ -217,8 +217,8 @@ int fsnotify(struct inode *to_tell, __u32 mask, void *data, int data_is, | |||
| 217 | /* global tests shouldn't care about events on child only the specific event */ | 217 | /* global tests shouldn't care about events on child only the specific event */ |
| 218 | __u32 test_mask = (mask & ~FS_EVENT_ON_CHILD); | 218 | __u32 test_mask = (mask & ~FS_EVENT_ON_CHILD); |
| 219 | 219 | ||
| 220 | if (data_is == FSNOTIFY_EVENT_FILE) | 220 | if (data_is == FSNOTIFY_EVENT_PATH) |
| 221 | mnt = ((struct file *)data)->f_path.mnt; | 221 | mnt = ((struct path *)data)->mnt; |
| 222 | else | 222 | else |
| 223 | mnt = NULL; | 223 | mnt = NULL; |
| 224 | 224 | ||
diff --git a/fs/notify/inotify/inotify_fsnotify.c b/fs/notify/inotify/inotify_fsnotify.c index 5e73eeb2c697..a91b69a6a291 100644 --- a/fs/notify/inotify/inotify_fsnotify.c +++ b/fs/notify/inotify/inotify_fsnotify.c | |||
| @@ -52,9 +52,9 @@ static bool event_compare(struct fsnotify_event *old, struct fsnotify_event *new | |||
| 52 | !strcmp(old->file_name, new->file_name)) | 52 | !strcmp(old->file_name, new->file_name)) |
| 53 | return true; | 53 | return true; |
| 54 | break; | 54 | break; |
| 55 | case (FSNOTIFY_EVENT_FILE): | 55 | case (FSNOTIFY_EVENT_PATH): |
| 56 | if ((old->file->f_path.mnt == new->file->f_path.mnt) && | 56 | if ((old->path.mnt == new->path.mnt) && |
| 57 | (old->file->f_path.dentry == new->file->f_path.dentry)) | 57 | (old->path.dentry == new->path.dentry)) |
| 58 | return true; | 58 | return true; |
| 59 | break; | 59 | break; |
| 60 | case (FSNOTIFY_EVENT_NONE): | 60 | case (FSNOTIFY_EVENT_NONE): |
| @@ -147,10 +147,10 @@ static bool inotify_should_send_event(struct fsnotify_group *group, struct inode | |||
| 147 | __u32 mask, void *data, int data_type) | 147 | __u32 mask, void *data, int data_type) |
| 148 | { | 148 | { |
| 149 | if ((inode_mark->mask & FS_EXCL_UNLINK) && | 149 | if ((inode_mark->mask & FS_EXCL_UNLINK) && |
| 150 | (data_type == FSNOTIFY_EVENT_FILE)) { | 150 | (data_type == FSNOTIFY_EVENT_PATH)) { |
| 151 | struct file *file = data; | 151 | struct path *path = data; |
| 152 | 152 | ||
| 153 | if (d_unlinked(file->f_path.dentry)) | 153 | if (d_unlinked(path->dentry)) |
| 154 | return false; | 154 | return false; |
| 155 | } | 155 | } |
| 156 | 156 | ||
diff --git a/fs/notify/notification.c b/fs/notify/notification.c index d6c435adc7a2..f39260f8f865 100644 --- a/fs/notify/notification.c +++ b/fs/notify/notification.c | |||
| @@ -31,7 +31,6 @@ | |||
| 31 | * allocated and used. | 31 | * allocated and used. |
| 32 | */ | 32 | */ |
| 33 | 33 | ||
| 34 | #include <linux/file.h> | ||
| 35 | #include <linux/fs.h> | 34 | #include <linux/fs.h> |
| 36 | #include <linux/init.h> | 35 | #include <linux/init.h> |
| 37 | #include <linux/kernel.h> | 36 | #include <linux/kernel.h> |
| @@ -90,8 +89,8 @@ void fsnotify_put_event(struct fsnotify_event *event) | |||
| 90 | if (atomic_dec_and_test(&event->refcnt)) { | 89 | if (atomic_dec_and_test(&event->refcnt)) { |
| 91 | pr_debug("%s: event=%p\n", __func__, event); | 90 | pr_debug("%s: event=%p\n", __func__, event); |
| 92 | 91 | ||
| 93 | if (event->data_type == FSNOTIFY_EVENT_FILE) | 92 | if (event->data_type == FSNOTIFY_EVENT_PATH) |
