diff options
-rw-r--r-- | include/linux/sunrpc/gss_krb5.h | 2 | ||||
-rw-r--r-- | net/sunrpc/auth_gss/gss_krb5_mech.c | 11 |
2 files changed, 6 insertions, 7 deletions
diff --git a/include/linux/sunrpc/gss_krb5.h b/include/linux/sunrpc/gss_krb5.h index 01c5e4314632..5a4b1e0206e3 100644 --- a/include/linux/sunrpc/gss_krb5.h +++ b/include/linux/sunrpc/gss_krb5.h | |||
@@ -42,8 +42,6 @@ | |||
42 | 42 | ||
43 | struct krb5_ctx { | 43 | struct krb5_ctx { |
44 | int initiate; /* 1 = initiating, 0 = accepting */ | 44 | int initiate; /* 1 = initiating, 0 = accepting */ |
45 | int seed_init; | ||
46 | unsigned char seed[16]; | ||
47 | struct crypto_blkcipher *enc; | 45 | struct crypto_blkcipher *enc; |
48 | struct crypto_blkcipher *seq; | 46 | struct crypto_blkcipher *seq; |
49 | s32 endtime; | 47 | s32 endtime; |
diff --git a/net/sunrpc/auth_gss/gss_krb5_mech.c b/net/sunrpc/auth_gss/gss_krb5_mech.c index bf5435db8785..05d4bee86fc0 100644 --- a/net/sunrpc/auth_gss/gss_krb5_mech.c +++ b/net/sunrpc/auth_gss/gss_krb5_mech.c | |||
@@ -137,12 +137,13 @@ gss_import_sec_context_kerberos(const void *p, | |||
137 | p = simple_get_bytes(p, end, &ctx->initiate, sizeof(ctx->initiate)); | 137 | p = simple_get_bytes(p, end, &ctx->initiate, sizeof(ctx->initiate)); |
138 | if (IS_ERR(p)) | 138 | if (IS_ERR(p)) |
139 | goto out_err_free_ctx; | 139 | goto out_err_free_ctx; |
140 | p = simple_get_bytes(p, end, &ctx->seed_init, sizeof(ctx->seed_init)); | 140 | /* The downcall format was designed before we completely understood |
141 | if (IS_ERR(p)) | 141 | * the uses of the context fields; so it includes some stuff we |
142 | goto out_err_free_ctx; | 142 | * just give some minimal sanity-checking, and some we ignore |
143 | p = simple_get_bytes(p, end, ctx->seed, sizeof(ctx->seed)); | 143 | * completely (like the next twenty bytes): */ |
144 | if (IS_ERR(p)) | 144 | if (unlikely(p + 20 > end || p + 20 < p)) |
145 | goto out_err_free_ctx; | 145 | goto out_err_free_ctx; |
146 | p += 20; | ||
146 | p = simple_get_bytes(p, end, &tmp, sizeof(tmp)); | 147 | p = simple_get_bytes(p, end, &tmp, sizeof(tmp)); |
147 | if (IS_ERR(p)) | 148 | if (IS_ERR(p)) |
148 | goto out_err_free_ctx; | 149 | goto out_err_free_ctx; |