1 files changed, 3 insertions, 3 deletions

diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
index d3fc92eaee89..1ca32c51d7cd 100644
--- a/drivers/video/fsl-diu-fb.c
+++ b/drivers/video/fsl-diu-fb.c
@@ -944,7 +944,7 @@ static u32 fsl_diu_get_pixel_format(unsigned int bits_per_pixel)
 #define PF_COMP_0_MASK          0x0000000F
 #define PF_COMP_0_SHIFT         0
 
-#define MAKE_PF(alpha, red, blue, green, size, c0, c1, c2, c3) \
+#define MAKE_PF(alpha, red, green, blue, size, c0, c1, c2, c3) \
         cpu_to_le32(PF_BYTE_F | (alpha << PF_ALPHA_C_SHIFT) | \
         (blue << PF_BLUE_C_SHIFT) | (green << PF_GREEN_C_SHIFT) | \
         (red << PF_RED_C_SHIFT) | (c3 << PF_COMP_3_SHIFT) | \
@@ -954,10 +954,10 @@ static u32 fsl_diu_get_pixel_format(unsigned int bits_per_pixel)
         switch (bits_per_pixel) {
         case 32:
                 /* 0x88883316 */
-                return MAKE_PF(3, 2, 0, 1, 3, 8, 8, 8, 8);
+                return MAKE_PF(3, 2, 1, 0, 3, 8, 8, 8, 8);
         case 24:
                 /* 0x88082219 */
-                return MAKE_PF(4, 0, 1, 2, 2, 0, 8, 8, 8);
+                return MAKE_PF(4, 0, 1, 2, 2, 8, 8, 8, 0);
         case 16:
                 /* 0x65053118 */
                 return MAKE_PF(4, 2, 1, 0, 1, 5, 6, 5, 0);