diff options
-rw-r--r-- | net/tipc/bearer.c | 6 | ||||
-rw-r--r-- | net/tipc/core.c | 3 | ||||
-rw-r--r-- | net/tipc/core.h | 2 | ||||
-rw-r--r-- | net/tipc/link.c | 4 |
4 files changed, 3 insertions, 12 deletions
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 09e71241265d..6b2faa57a394 100644 --- a/net/tipc/bearer.c +++ b/net/tipc/bearer.c | |||
@@ -60,7 +60,7 @@ static int media_name_valid(const char *name) | |||
60 | len = strlen(name); | 60 | len = strlen(name); |
61 | if ((len + 1) > TIPC_MAX_MEDIA_NAME) | 61 | if ((len + 1) > TIPC_MAX_MEDIA_NAME) |
62 | return 0; | 62 | return 0; |
63 | return strspn(name, tipc_alphabet) == len; | 63 | return 1; |
64 | } | 64 | } |
65 | 65 | ||
66 | /** | 66 | /** |
@@ -206,9 +206,7 @@ static int bearer_name_validate(const char *name, | |||
206 | 206 | ||
207 | /* validate component parts of bearer name */ | 207 | /* validate component parts of bearer name */ |
208 | if ((media_len <= 1) || (media_len > TIPC_MAX_MEDIA_NAME) || | 208 | if ((media_len <= 1) || (media_len > TIPC_MAX_MEDIA_NAME) || |
209 | (if_len <= 1) || (if_len > TIPC_MAX_IF_NAME) || | 209 | (if_len <= 1) || (if_len > TIPC_MAX_IF_NAME)) |
210 | (strspn(media_name, tipc_alphabet) != (media_len - 1)) || | ||
211 | (strspn(if_name, tipc_alphabet) != (if_len - 1))) | ||
212 | return 0; | 210 | return 0; |
213 | 211 | ||
214 | /* return bearer name components, if necessary */ | 212 | /* return bearer name components, if necessary */ |
diff --git a/net/tipc/core.c b/net/tipc/core.c index 6586eac6a50e..c261a5dca7c5 100644 --- a/net/tipc/core.c +++ b/net/tipc/core.c | |||
@@ -50,9 +50,6 @@ | |||
50 | /* global variables used by multiple sub-systems within TIPC */ | 50 | /* global variables used by multiple sub-systems within TIPC */ |
51 | int tipc_random; | 51 | int tipc_random; |
52 | 52 | ||
53 | const char tipc_alphabet[] = | ||
54 | "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789_."; | ||
55 | |||
56 | /* configurable TIPC parameters */ | 53 | /* configurable TIPC parameters */ |
57 | u32 tipc_own_addr; | 54 | u32 tipc_own_addr; |
58 | int tipc_max_ports; | 55 | int tipc_max_ports; |
diff --git a/net/tipc/core.h b/net/tipc/core.h index fd42e106c185..e4e46cd2d0e6 100644 --- a/net/tipc/core.h +++ b/net/tipc/core.h | |||
@@ -85,8 +85,6 @@ extern int tipc_remote_management; | |||
85 | * Other global variables | 85 | * Other global variables |
86 | */ | 86 | */ |
87 | extern int tipc_random; | 87 | extern int tipc_random; |
88 | extern const char tipc_alphabet[]; | ||
89 | |||
90 | 88 | ||
91 | /* | 89 | /* |
92 | * Routines available to privileged subsystems | 90 | * Routines available to privileged subsystems |
diff --git a/net/tipc/link.c b/net/tipc/link.c index 1c1e6151875e..a79c755cb417 100644 --- a/net/tipc/link.c +++ b/net/tipc/link.c | |||
@@ -210,9 +210,7 @@ static int link_name_validate(const char *name, | |||
210 | (z_local > 255) || (c_local > 4095) || (n_local > 4095) || | 210 | (z_local > 255) || (c_local > 4095) || (n_local > 4095) || |
211 | (z_peer > 255) || (c_peer > 4095) || (n_peer > 4095) || | 211 | (z_peer > 255) || (c_peer > 4095) || (n_peer > 4095) || |
212 | (if_local_len <= 1) || (if_local_len > TIPC_MAX_IF_NAME) || | 212 | (if_local_len <= 1) || (if_local_len > TIPC_MAX_IF_NAME) || |
213 | (if_peer_len <= 1) || (if_peer_len > TIPC_MAX_IF_NAME) || | 213 | (if_peer_len <= 1) || (if_peer_len > TIPC_MAX_IF_NAME)) |
214 | (strspn(if_local, tipc_alphabet) != (if_local_len - 1)) || | ||
215 | (strspn(if_peer, tipc_alphabet) != (if_peer_len - 1))) | ||
216 | return 0; | 214 | return 0; |
217 | 215 | ||
218 | /* return link name components, if necessary */ | 216 | /* return link name components, if necessary */ |