aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--include/linux/percpu_counter.h14
-rw-r--r--lib/percpu_counter.c18
-rw-r--r--lib/proportions.c6
-rw-r--r--mm/backing-dev.c2
4 files changed, 18 insertions, 22 deletions
diff --git a/include/linux/percpu_counter.h b/include/linux/percpu_counter.h
index 9007ccdfc112..96bdde36599f 100644
--- a/include/linux/percpu_counter.h
+++ b/include/linux/percpu_counter.h
@@ -30,8 +30,16 @@ struct percpu_counter {
30#define FBC_BATCH (NR_CPUS*4) 30#define FBC_BATCH (NR_CPUS*4)
31#endif 31#endif
32 32
33int percpu_counter_init(struct percpu_counter *fbc, s64 amount); 33int __percpu_counter_init(struct percpu_counter *fbc, s64 amount,
34int percpu_counter_init_irq(struct percpu_counter *fbc, s64 amount); 34 struct lock_class_key *key);
35
36#define percpu_counter_init(fbc, value) \
37 ({ \
38 static struct lock_class_key __key; \
39 \
40 __percpu_counter_init(fbc, value, &__key); \
41 })
42
35void percpu_counter_destroy(struct percpu_counter *fbc); 43void percpu_counter_destroy(struct percpu_counter *fbc);
36void percpu_counter_set(struct percpu_counter *fbc, s64 amount); 44void percpu_counter_set(struct percpu_counter *fbc, s64 amount);
37void __percpu_counter_add(struct percpu_counter *fbc, s64 amount, s32 batch); 45void __percpu_counter_add(struct percpu_counter *fbc, s64 amount, s32 batch);
@@ -85,8 +93,6 @@ static inline int percpu_counter_init(struct percpu_counter *fbc, s64 amount)
85 return 0; 93 return 0;
86} 94}
87 95
88#define percpu_counter_init_irq percpu_counter_init
89
90static inline void percpu_counter_destroy(struct percpu_counter *fbc) 96static inline void percpu_counter_destroy(struct percpu_counter *fbc)
91{ 97{
92} 98}
diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c
index a8663890a88c..c7fe2e4e8ed1 100644
--- a/lib/percpu_counter.c
+++ b/lib/percpu_counter.c
@@ -71,11 +71,11 @@ s64 __percpu_counter_sum(struct percpu_counter *fbc)
71} 71}
72EXPORT_SYMBOL(__percpu_counter_sum); 72EXPORT_SYMBOL(__percpu_counter_sum);
73 73
74static struct lock_class_key percpu_counter_irqsafe; 74int __percpu_counter_init(struct percpu_counter *fbc, s64 amount,
75 75 struct lock_class_key *key)
76int percpu_counter_init(struct percpu_counter *fbc, s64 amount)
77{ 76{
78 spin_lock_init(&fbc->lock); 77 spin_lock_init(&fbc->lock);
78 lockdep_set_class(&fbc->lock, key);
79 fbc->count = amount; 79 fbc->count = amount;
80 fbc->counters = alloc_percpu(s32); 80 fbc->counters = alloc_percpu(s32);
81 if (!fbc->counters) 81 if (!fbc->counters)
@@ -87,17 +87,7 @@ int percpu_counter_init(struct percpu_counter *fbc, s64 amount)
87#endif 87#endif
88 return 0; 88 return 0;
89} 89}
90EXPORT_SYMBOL(percpu_counter_init); 90EXPORT_SYMBOL(__percpu_counter_init);
91
92int percpu_counter_init_irq(struct percpu_counter *fbc, s64 amount)
93{
94 int err;
95
96 err = percpu_counter_init(fbc, amount);
97 if (!err)
98 lockdep_set_class(&fbc->lock, &percpu_counter_irqsafe);
99 return err;
100}
101 91
102void percpu_counter_destroy(struct percpu_counter *fbc) 92void percpu_counter_destroy(struct percpu_counter *fbc)
103{ 93{
diff --git a/lib/proportions.c b/lib/proportions.c
index 4f387a643d72..7367f2b727d0 100644
--- a/lib/proportions.c
+++ b/lib/proportions.c
@@ -83,11 +83,11 @@ int prop_descriptor_init(struct prop_descriptor *pd, int shift)
83 pd->index = 0; 83 pd->index = 0;
84 pd->pg[0].shift = shift; 84 pd->pg[0].shift = shift;
85 mutex_init(&pd->mutex); 85 mutex_init(&pd->mutex);
86 err = percpu_counter_init_irq(&pd->pg[0].events, 0); 86 err = percpu_counter_init(&pd->pg[0].events, 0);
87 if (err) 87 if (err)
88 goto out; 88 goto out;
89 89
90 err = percpu_counter_init_irq(&pd->pg[1].events, 0); 90 err = percpu_counter_init(&pd->pg[1].events, 0);
91 if (err) 91 if (err)
92 percpu_counter_destroy(&pd->pg[0].events); 92 percpu_counter_destroy(&pd->pg[0].events);
93 93
@@ -191,7 +191,7 @@ int prop_local_init_percpu(struct prop_local_percpu *pl)
191 spin_lock_init(&pl->lock); 191 spin_lock_init(&pl->lock);
192 pl->shift = 0; 192 pl->shift = 0;
193 pl->period = 0; 193 pl->period = 0;
194 return percpu_counter_init_irq(&pl->events, 0); 194 return percpu_counter_init(&pl->events, 0);
195} 195}
196 196
197void prop_local_destroy_percpu(struct prop_local_percpu *pl) 197void prop_local_destroy_percpu(struct prop_local_percpu *pl)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index f2e574dbc300..f3b125857827 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -220,7 +220,7 @@ int bdi_init(struct backing_dev_info *bdi)
220 bdi->max_prop_frac = PROP_FRAC_BASE; 220 bdi->max_prop_frac = PROP_FRAC_BASE;
221 221
222 for (i = 0; i < NR_BDI_STAT_ITEMS; i++) { 222 for (i = 0; i < NR_BDI_STAT_ITEMS; i++) {
223 err = percpu_counter_init_irq(&bdi->bdi_stat[i], 0); 223 err = percpu_counter_init(&bdi->bdi_stat[i], 0);
224 if (err) 224 if (err)
225 goto err; 225 goto err;
226 } 226 }