diff options
-rw-r--r-- | include/linux/swapops.h | 23 | ||||
-rw-r--r-- | mm/filemap.c | 49 | ||||
-rw-r--r-- | mm/swapfile.c | 20 |
3 files changed, 66 insertions, 26 deletions
diff --git a/include/linux/swapops.h b/include/linux/swapops.h index cd42e30b7c6e..2189d3ffc85d 100644 --- a/include/linux/swapops.h +++ b/include/linux/swapops.h | |||
@@ -1,3 +1,8 @@ | |||
1 | #ifndef _LINUX_SWAPOPS_H | ||
2 | #define _LINUX_SWAPOPS_H | ||
3 | |||
4 | #include <linux/radix-tree.h> | ||
5 | |||
1 | /* | 6 | /* |
2 | * swapcache pages are stored in the swapper_space radix tree. We want to | 7 | * swapcache pages are stored in the swapper_space radix tree. We want to |
3 | * get good packing density in that tree, so the index should be dense in | 8 | * get good packing density in that tree, so the index should be dense in |
@@ -76,6 +81,22 @@ static inline pte_t swp_entry_to_pte(swp_entry_t entry) | |||
76 | return __swp_entry_to_pte(arch_entry); | 81 | return __swp_entry_to_pte(arch_entry); |
77 | } | 82 | } |
78 | 83 | ||
84 | static inline swp_entry_t radix_to_swp_entry(void *arg) | ||
85 | { | ||
86 | swp_entry_t entry; | ||
87 | |||
88 | entry.val = (unsigned long)arg >> RADIX_TREE_EXCEPTIONAL_SHIFT; | ||
89 | return entry; | ||
90 | } | ||
91 | |||
92 | static inline void *swp_to_radix_entry(swp_entry_t entry) | ||
93 | { | ||
94 | unsigned long value; | ||
95 | |||
96 | value = entry.val << RADIX_TREE_EXCEPTIONAL_SHIFT; | ||
97 | return (void *)(value | RADIX_TREE_EXCEPTIONAL_ENTRY); | ||
98 | } | ||
99 | |||
79 | #ifdef CONFIG_MIGRATION | 100 | #ifdef CONFIG_MIGRATION |
80 | static inline swp_entry_t make_migration_entry(struct page *page, int write) | 101 | static inline swp_entry_t make_migration_entry(struct page *page, int write) |
81 | { | 102 | { |
@@ -169,3 +190,5 @@ static inline int non_swap_entry(swp_entry_t entry) | |||
169 | return 0; | 190 | return 0; |
170 | } | 191 | } |
171 | #endif | 192 | #endif |
193 | |||
194 | #endif /* _LINUX_SWAPOPS_H */ | ||
diff --git a/mm/filemap.c b/mm/filemap.c index b83aebfd0a00..76bfb6460f57 100644 --- a/mm/filemap.c +++ b/mm/filemap.c | |||
@@ -714,9 +714,12 @@ repeat: | |||
714 | page = radix_tree_deref_slot(pagep); | 714 | page = radix_tree_deref_slot(pagep); |
715 | if (unlikely(!page)) | 715 | if (unlikely(!page)) |
716 | goto out; | 716 | goto out; |
717 | if (radix_tree_deref_retry(page)) | 717 | if (radix_tree_exception(page)) { |
718 | if (radix_tree_exceptional_entry(page)) | ||
719 | goto out; | ||
720 | /* radix_tree_deref_retry(page) */ | ||
718 | goto repeat; | 721 | goto repeat; |
719 | 722 | } | |
720 | if (!page_cache_get_speculative(page)) | 723 | if (!page_cache_get_speculative(page)) |
721 | goto repeat; | 724 | goto repeat; |
722 | 725 | ||
@@ -753,7 +756,7 @@ struct page *find_lock_page(struct address_space *mapping, pgoff_t offset) | |||
753 | 756 | ||
754 | repeat: | 757 | repeat: |
755 | page = find_get_page(mapping, offset); | 758 | page = find_get_page(mapping, offset); |
756 | if (page) { | 759 | if (page && !radix_tree_exception(page)) { |
757 | lock_page(page); | 760 | lock_page(page); |
758 | /* Has the page been truncated? */ | 761 | /* Has the page been truncated? */ |
759 | if (unlikely(page->mapping != mapping)) { | 762 | if (unlikely(page->mapping != mapping)) { |
@@ -849,11 +852,14 @@ repeat: | |||
849 | if (unlikely(!page)) | 852 | if (unlikely(!page)) |
850 | continue; | 853 | continue; |
851 | 854 | ||
852 | /* | 855 | if (radix_tree_exception(page)) { |
853 | * This can only trigger when the entry at index 0 moves out | 856 | if (radix_tree_exceptional_entry(page)) |
854 | * of or back to the root: none yet gotten, safe to restart. | 857 | continue; |
855 | */ | 858 | /* |
856 | if (radix_tree_deref_retry(page)) { | 859 | * radix_tree_deref_retry(page): |
860 | * can only trigger when entry at index 0 moves out of | ||
861 | * or back to root: none yet gotten, safe to restart. | ||
862 | */ | ||
857 | WARN_ON(start | i); | 863 | WARN_ON(start | i); |
858 | goto restart; | 864 | goto restart; |
859 | } | 865 | } |
@@ -912,12 +918,16 @@ repeat: | |||
912 | if (unlikely(!page)) | 918 | if (unlikely(!page)) |
913 | continue; | 919 | continue; |
914 | 920 | ||
915 | /* | 921 | if (radix_tree_exception(page)) { |
916 | * This can only trigger when the entry at index 0 moves out | 922 | if (radix_tree_exceptional_entry(page)) |
917 | * of or back to the root: none yet gotten, safe to restart. | 923 | break; |
918 | */ | 924 | /* |
919 | if (radix_tree_deref_retry(page)) | 925 | * radix_tree_deref_retry(page): |
926 | * can only trigger when entry at index 0 moves out of | ||
927 | * or back to root: none yet gotten, safe to restart. | ||
928 | */ | ||
920 | goto restart; | 929 | goto restart; |
930 | } | ||
921 | 931 | ||
922 | if (!page_cache_get_speculative(page)) | 932 | if (!page_cache_get_speculative(page)) |
923 | goto repeat; | 933 | goto repeat; |
@@ -977,12 +987,15 @@ repeat: | |||
977 | if (unlikely(!page)) | 987 | if (unlikely(!page)) |
978 | continue; | 988 | continue; |
979 | 989 | ||
980 | /* | 990 | if (radix_tree_exception(page)) { |
981 | * This can only trigger when the entry at index 0 moves out | 991 | BUG_ON(radix_tree_exceptional_entry(page)); |
982 | * of or back to the root: none yet gotten, safe to restart. | 992 | /* |
983 | */ | 993 | * radix_tree_deref_retry(page): |
984 | if (radix_tree_deref_retry(page)) | 994 | * can only trigger when entry at index 0 moves out of |
995 | * or back to root: none yet gotten, safe to restart. | ||
996 | */ | ||
985 | goto restart; | 997 | goto restart; |
998 | } | ||
986 | 999 | ||
987 | if (!page_cache_get_speculative(page)) | 1000 | if (!page_cache_get_speculative(page)) |
988 | goto repeat; | 1001 | goto repeat; |
diff --git a/mm/swapfile.c b/mm/swapfile.c index 1b8c33907242..17bc224bce68 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c | |||
@@ -1924,20 +1924,24 @@ static unsigned long read_swap_header(struct swap_info_struct *p, | |||
1924 | 1924 | ||
1925 | /* | 1925 | /* |
1926 | * Find out how many pages are allowed for a single swap | 1926 | * Find out how many pages are allowed for a single swap |
1927 | * device. There are two limiting factors: 1) the number of | 1927 | * device. There are three limiting factors: 1) the number |
1928 | * bits for the swap offset in the swp_entry_t type and | 1928 | * of bits for the swap offset in the swp_entry_t type, and |
1929 | * 2) the number of bits in the a swap pte as defined by | 1929 | * 2) the number of bits in the swap pte as defined by the |
1930 | * the different architectures. In order to find the | 1930 | * the different architectures, and 3) the number of free bits |
1931 | * largest possible bit mask a swap entry with swap type 0 | 1931 | * in an exceptional radix_tree entry. In order to find the |
1932 | * largest possible bit mask, a swap entry with swap type 0 | ||
1932 | * and swap offset ~0UL is created, encoded to a swap pte, | 1933 | * and swap offset ~0UL is created, encoded to a swap pte, |
1933 | * decoded to a swp_entry_t again and finally the swap | 1934 | * decoded to a swp_entry_t again, and finally the swap |
1934 | * offset is extracted. This will mask all the bits from | 1935 | * offset is extracted. This will mask all the bits from |
1935 | * the initial ~0UL mask that can't be encoded in either | 1936 | * the initial ~0UL mask that can't be encoded in either |
1936 | * the swp_entry_t or the architecture definition of a | 1937 | * the swp_entry_t or the architecture definition of a |
1937 | * swap pte. | 1938 | * swap pte. Then the same is done for a radix_tree entry. |
1938 | */ | 1939 | */ |
1939 | maxpages = swp_offset(pte_to_swp_entry( | 1940 | maxpages = swp_offset(pte_to_swp_entry( |
1940 | swp_entry_to_pte(swp_entry(0, ~0UL)))) + 1; | 1941 | swp_entry_to_pte(swp_entry(0, ~0UL)))); |
1942 | maxpages = swp_offset(radix_to_swp_entry( | ||
1943 | swp_to_radix_entry(swp_entry(0, maxpages)))) + 1; | ||
1944 | |||
1941 | if (maxpages > swap_header->info.last_page) { | 1945 | if (maxpages > swap_header->info.last_page) { |
1942 | maxpages = swap_header->info.last_page + 1; | 1946 | maxpages = swap_header->info.last_page + 1; |
1943 | /* p->max is an unsigned int: don't overflow it */ | 1947 | /* p->max is an unsigned int: don't overflow it */ |