diff options
-rw-r--r-- | drivers/hid/hid-core.c | 16 | ||||
-rw-r--r-- | drivers/hid/usbhid/hid-core.c | 6 |
2 files changed, 16 insertions, 6 deletions
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index dd679a582c2c..ec917690c263 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c | |||
@@ -757,6 +757,7 @@ int hid_open_report(struct hid_device *device) | |||
757 | struct hid_item item; | 757 | struct hid_item item; |
758 | unsigned int size; | 758 | unsigned int size; |
759 | __u8 *start; | 759 | __u8 *start; |
760 | __u8 *buf; | ||
760 | __u8 *end; | 761 | __u8 *end; |
761 | int ret; | 762 | int ret; |
762 | static int (*dispatch_type[])(struct hid_parser *parser, | 763 | static int (*dispatch_type[])(struct hid_parser *parser, |
@@ -775,12 +776,21 @@ int hid_open_report(struct hid_device *device) | |||
775 | return -ENODEV; | 776 | return -ENODEV; |
776 | size = device->dev_rsize; | 777 | size = device->dev_rsize; |
777 | 778 | ||
779 | buf = kmemdup(start, size, GFP_KERNEL); | ||
780 | if (buf == NULL) | ||
781 | return -ENOMEM; | ||
782 | |||
778 | if (device->driver->report_fixup) | 783 | if (device->driver->report_fixup) |
779 | start = device->driver->report_fixup(device, start, &size); | 784 | start = device->driver->report_fixup(device, buf, &size); |
785 | else | ||
786 | start = buf; | ||
780 | 787 | ||
781 | device->rdesc = kmemdup(start, size, GFP_KERNEL); | 788 | start = kmemdup(start, size, GFP_KERNEL); |
782 | if (device->rdesc == NULL) | 789 | kfree(buf); |
790 | if (start == NULL) | ||
783 | return -ENOMEM; | 791 | return -ENOMEM; |
792 | |||
793 | device->rdesc = start; | ||
784 | device->rsize = size; | 794 | device->rsize = size; |
785 | 795 | ||
786 | parser = vzalloc(sizeof(struct hid_parser)); | 796 | parser = vzalloc(sizeof(struct hid_parser)); |
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index dedd8e4e5c6d..8e0c4bf94ebc 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c | |||
@@ -1415,20 +1415,20 @@ static int hid_post_reset(struct usb_interface *intf) | |||
1415 | * configuration descriptors passed, we already know that | 1415 | * configuration descriptors passed, we already know that |
1416 | * the size of the HID report descriptor has not changed. | 1416 | * the size of the HID report descriptor has not changed. |
1417 | */ | 1417 | */ |
1418 | rdesc = kmalloc(hid->rsize, GFP_KERNEL); | 1418 | rdesc = kmalloc(hid->dev_rsize, GFP_KERNEL); |
1419 | if (!rdesc) { | 1419 | if (!rdesc) { |
1420 | dbg_hid("couldn't allocate rdesc memory (post_reset)\n"); | 1420 | dbg_hid("couldn't allocate rdesc memory (post_reset)\n"); |
1421 | return 1; | 1421 | return 1; |
1422 | } | 1422 | } |
1423 | status = hid_get_class_descriptor(dev, | 1423 | status = hid_get_class_descriptor(dev, |
1424 | interface->desc.bInterfaceNumber, | 1424 | interface->desc.bInterfaceNumber, |
1425 | HID_DT_REPORT, rdesc, hid->rsize); | 1425 | HID_DT_REPORT, rdesc, hid->dev_rsize); |
1426 | if (status < 0) { | 1426 | if (status < 0) { |
1427 | dbg_hid("reading report descriptor failed (post_reset)\n"); | 1427 | dbg_hid("reading report descriptor failed (post_reset)\n"); |
1428 | kfree(rdesc); | 1428 | kfree(rdesc); |
1429 | return 1; | 1429 | return 1; |
1430 | } | 1430 | } |
1431 | status = memcmp(rdesc, hid->rdesc, hid->rsize); | 1431 | status = memcmp(rdesc, hid->dev_rdesc, hid->dev_rsize); |
1432 | kfree(rdesc); | 1432 | kfree(rdesc); |
1433 | if (status != 0) { | 1433 | if (status != 0) { |
1434 | dbg_hid("report descriptor changed\n"); | 1434 | dbg_hid("report descriptor changed\n"); |