aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--include/linux/ethtool.h7
-rw-r--r--net/core/ethtool.c6
2 files changed, 1 insertions, 12 deletions
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index 4194a2067a14..d659fdc77eb3 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -814,12 +814,6 @@ bool ethtool_invalid_flags(struct net_device *dev, u32 data, u32 supported);
814 * the indicator accordingly. Finally, it is called with the argument 814 * the indicator accordingly. Finally, it is called with the argument
815 * %ETHTOOL_ID_INACTIVE and must deactivate the indicator. Returns a 815 * %ETHTOOL_ID_INACTIVE and must deactivate the indicator. Returns a
816 * negative error code or zero. 816 * negative error code or zero.
817 * @phys_id: Deprecated in favour of @set_phys_id.
818 * Identify the physical device, e.g. by flashing an LED
819 * attached to it until interrupted by a signal or the given time
820 * (in seconds) elapses. If the given time is zero, use a default
821 * time limit. Returns a negative error code or zero. Being
822 * interrupted by a signal is not an error.
823 * @get_ethtool_stats: Return extended statistics about the device. 817 * @get_ethtool_stats: Return extended statistics about the device.
824 * This is only useful if the device maintains statistics not 818 * This is only useful if the device maintains statistics not
825 * included in &struct rtnl_link_stats64. 819 * included in &struct rtnl_link_stats64.
@@ -908,7 +902,6 @@ struct ethtool_ops {
908 void (*self_test)(struct net_device *, struct ethtool_test *, u64 *); 902 void (*self_test)(struct net_device *, struct ethtool_test *, u64 *);
909 void (*get_strings)(struct net_device *, u32 stringset, u8 *); 903 void (*get_strings)(struct net_device *, u32 stringset, u8 *);
910 int (*set_phys_id)(struct net_device *, enum ethtool_phys_id_state); 904 int (*set_phys_id)(struct net_device *, enum ethtool_phys_id_state);
911 int (*phys_id)(struct net_device *, u32);
912 void (*get_ethtool_stats)(struct net_device *, 905 void (*get_ethtool_stats)(struct net_device *,
913 struct ethtool_stats *, u64 *); 906 struct ethtool_stats *, u64 *);
914 int (*begin)(struct net_device *); 907 int (*begin)(struct net_device *);
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index d8b1a8d85a96..927819d92248 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -1655,7 +1655,7 @@ static int ethtool_phys_id(struct net_device *dev, void __user *useraddr)
1655 static bool busy; 1655 static bool busy;
1656 int rc; 1656 int rc;
1657 1657
1658 if (!dev->ethtool_ops->set_phys_id && !dev->ethtool_ops->phys_id) 1658 if (!dev->ethtool_ops->set_phys_id)
1659 return -EOPNOTSUPP; 1659 return -EOPNOTSUPP;
1660 1660
1661 if (busy) 1661 if (busy)
@@ -1664,10 +1664,6 @@ static int ethtool_phys_id(struct net_device *dev, void __user *useraddr)
1664 if (copy_from_user(&id, useraddr, sizeof(id))) 1664 if (copy_from_user(&id, useraddr, sizeof(id)))
1665 return -EFAULT; 1665 return -EFAULT;
1666 1666
1667 if (!dev->ethtool_ops->set_phys_id)
1668 /* Do it the old way */
1669 return dev->ethtool_ops->phys_id(dev, id.data);
1670
1671 rc = dev->ethtool_ops->set_phys_id(dev, ETHTOOL_ID_ACTIVE); 1667 rc = dev->ethtool_ops->set_phys_id(dev, ETHTOOL_ID_ACTIVE);
1672 if (rc < 0) 1668 if (rc < 0)
1673 return rc; 1669 return rc;