aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/hid/usbhid/hiddev.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index aa214170baf4..93dcb7e29102 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -875,16 +875,21 @@ int hiddev_connect(struct hid_device *hid, unsigned int force)
875 hiddev->hid = hid; 875 hiddev->hid = hid;
876 hiddev->exist = 1; 876 hiddev->exist = 1;
877 877
878 /* when lock_kernel() usage is fixed in usb_open(),
879 * we could also fix it here */
880 lock_kernel();
878 retval = usb_register_dev(usbhid->intf, &hiddev_class); 881 retval = usb_register_dev(usbhid->intf, &hiddev_class);
879 if (retval) { 882 if (retval) {
880 err_hid("Not able to get a minor for this device."); 883 err_hid("Not able to get a minor for this device.");
881 hid->hiddev = NULL; 884 hid->hiddev = NULL;
885 unlock_kernel();
882 kfree(hiddev); 886 kfree(hiddev);
883 return -1; 887 return -1;
884 } else { 888 } else {
885 hid->minor = usbhid->intf->minor; 889 hid->minor = usbhid->intf->minor;
886 hiddev_table[usbhid->intf->minor - HIDDEV_MINOR_BASE] = hiddev; 890 hiddev_table[usbhid->intf->minor - HIDDEV_MINOR_BASE] = hiddev;
887 } 891 }
892 unlock_kernel();
888 893
889 return 0; 894 return 0;
890} 895}