aboutsummaryrefslogtreecommitdiffstats
path: root/virt
diff options
context:
space:
mode:
authorMarcelo Tosatti <mtosatti@redhat.com>2008-12-10 15:23:26 -0500
committerAvi Kivity <avi@redhat.com>2009-02-14 19:47:35 -0500
commit85db06e514422ae429b5f85742d8111b70bd56f3 (patch)
tree55acee5d8e3c51f09f44ccfcdd631590819b949d /virt
parent7a0eb1960e8ddcb68ea631caf16815485af0e228 (diff)
KVM: mmu_notifiers release method
The destructor for huge pages uses the backing inode for adjusting hugetlbfs accounting. Hugepage mappings are destroyed by exit_mmap, after mmu_notifier_release, so there are no notifications through unmap_hugepage_range at this point. The hugetlbfs inode can be freed with pages backed by it referenced by the shadow. When the shadow releases its reference, the huge page destructor will access a now freed inode. Implement the release operation for kvm mmu notifiers to release page refs before the hugetlbfs inode is gone. Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com> Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'virt')
-rw-r--r--virt/kvm/kvm_main.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 3a5a08298aab..0b6f2f71271f 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -789,11 +789,19 @@ static int kvm_mmu_notifier_clear_flush_young(struct mmu_notifier *mn,
789 return young; 789 return young;
790} 790}
791 791
792static void kvm_mmu_notifier_release(struct mmu_notifier *mn,
793 struct mm_struct *mm)
794{
795 struct kvm *kvm = mmu_notifier_to_kvm(mn);
796 kvm_arch_flush_shadow(kvm);
797}
798
792static const struct mmu_notifier_ops kvm_mmu_notifier_ops = { 799static const struct mmu_notifier_ops kvm_mmu_notifier_ops = {
793 .invalidate_page = kvm_mmu_notifier_invalidate_page, 800 .invalidate_page = kvm_mmu_notifier_invalidate_page,
794 .invalidate_range_start = kvm_mmu_notifier_invalidate_range_start, 801 .invalidate_range_start = kvm_mmu_notifier_invalidate_range_start,
795 .invalidate_range_end = kvm_mmu_notifier_invalidate_range_end, 802 .invalidate_range_end = kvm_mmu_notifier_invalidate_range_end,
796 .clear_flush_young = kvm_mmu_notifier_clear_flush_young, 803 .clear_flush_young = kvm_mmu_notifier_clear_flush_young,
804 .release = kvm_mmu_notifier_release,
797}; 805};
798#endif /* CONFIG_MMU_NOTIFIER && KVM_ARCH_WANT_MMU_NOTIFIER */ 806#endif /* CONFIG_MMU_NOTIFIER && KVM_ARCH_WANT_MMU_NOTIFIER */
799 807