Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6

The SmartMedia FTL code depends on new kfifo bits from 2.6.33

4 files changed, 29 insertions, 10 deletions

diff --git a/virt/kvm/assigned-dev.c b/virt/kvm/assigned-dev.c
index fd9c097b760a..f73de631e3ee 100644
--- a/virt/kvm/assigned-dev.c
+++ b/virt/kvm/assigned-dev.c
@@ -508,8 +508,8 @@ static int kvm_vm_ioctl_assign_device(struct kvm *kvm,
         struct kvm_assigned_dev_kernel *match;
         struct pci_dev *dev;
 
-        down_read(&kvm->slots_lock);
         mutex_lock(&kvm->lock);
+        down_read(&kvm->slots_lock);
 
         match = kvm_find_assigned_dev(&kvm->arch.assigned_dev_head,
                                       assigned_dev->assigned_dev_id);
@@ -573,8 +573,8 @@ static int kvm_vm_ioctl_assign_device(struct kvm *kvm,
         }
 
 out:
-        mutex_unlock(&kvm->lock);
         up_read(&kvm->slots_lock);
+        mutex_unlock(&kvm->lock);
         return r;
 out_list_del:
         list_del(&match->list);
@@ -585,8 +585,8 @@ out_put:
         pci_dev_put(dev);
 out_free:
         kfree(match);
-        mutex_unlock(&kvm->lock);
         up_read(&kvm->slots_lock);
+        mutex_unlock(&kvm->lock);
         return r;
 }
 
diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
index 30f70fd511c4..a9d3fc6c681c 100644
--- a/virt/kvm/eventfd.c
+++ b/virt/kvm/eventfd.c
@@ -72,12 +72,13 @@ static void
 irqfd_shutdown(struct work_struct *work)
 {
         struct _irqfd *irqfd = container_of(work, struct _irqfd, shutdown);
+        u64 cnt;
 
         /*
          * Synchronize with the wait-queue and unhook ourselves to prevent
          * further events.
          */
-        remove_wait_queue(irqfd->wqh, &irqfd->wait);
+        eventfd_ctx_remove_wait_queue(irqfd->eventfd, &irqfd->wait, &cnt);
 
         /*
          * We know no new events will be scheduled at this point, so block
@@ -166,7 +167,7 @@ irqfd_ptable_queue_proc(struct file *file, wait_queue_head_t *wqh,
 static int
 kvm_irqfd_assign(struct kvm *kvm, int fd, int gsi)
 {
-        struct _irqfd *irqfd;
+        struct _irqfd *irqfd, *tmp;
         struct file *file = NULL;
         struct eventfd_ctx *eventfd = NULL;
         int ret;
@@ -203,9 +204,20 @@ kvm_irqfd_assign(struct kvm *kvm, int fd, int gsi)
         init_waitqueue_func_entry(&irqfd->wait, irqfd_wakeup);
         init_poll_funcptr(&irqfd->pt, irqfd_ptable_queue_proc);
 
+        spin_lock_irq(&kvm->irqfds.lock);
+
+        ret = 0;
+        list_for_each_entry(tmp, &kvm->irqfds.items, list) {
+                if (irqfd->eventfd != tmp->eventfd)
+                        continue;
+                /* This fd is used for another irq already. */
+                ret = -EBUSY;
+                spin_unlock_irq(&kvm->irqfds.lock);
+                goto fail;
+        }
+
         events = file->f_op->poll(file, &irqfd->pt);
 
-        spin_lock_irq(&kvm->irqfds.lock);
         list_add_tail(&irqfd->list, &kvm->irqfds.items);
         spin_unlock_irq(&kvm->irqfds.lock);
 
diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c
index 9b077342ab54..9fd5b3ebc517 100644
--- a/virt/kvm/irq_comm.c
+++ b/virt/kvm/irq_comm.c
@@ -302,6 +302,7 @@ static int setup_routing_entry(struct kvm_irq_routing_table *rt,
 {
         int r = -EINVAL;
         int delta;
+        unsigned max_pin;
         struct kvm_kernel_irq_routing_entry *ei;
         struct hlist_node *n;
 
@@ -322,12 +323,15 @@ static int setup_routing_entry(struct kvm_irq_routing_table *rt,
                 switch (ue->u.irqchip.irqchip) {
                 case KVM_IRQCHIP_PIC_MASTER:
                         e->set = kvm_set_pic_irq;
+                        max_pin = 16;
                         break;
                 case KVM_IRQCHIP_PIC_SLAVE:
                         e->set = kvm_set_pic_irq;
+                        max_pin = 16;
                         delta = 8;
                         break;
                 case KVM_IRQCHIP_IOAPIC:
+                        max_pin = KVM_IOAPIC_NUM_PINS;
                         e->set = kvm_set_ioapic_irq;
                         break;
                 default:
@@ -335,7 +339,7 @@ static int setup_routing_entry(struct kvm_irq_routing_table *rt,
                 }
                 e->irqchip.irqchip = ue->u.irqchip.irqchip;
                 e->irqchip.pin = ue->u.irqchip.pin + delta;
-                if (e->irqchip.pin >= KVM_IOAPIC_NUM_PINS)
+                if (e->irqchip.pin >= max_pin)
                         goto out;
                 rt->chip[ue->u.irqchip.irqchip][e->irqchip.pin] = ue->gsi;
                 break;
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index e1f2bf8d7b1e..a944be392d6e 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -64,7 +64,7 @@ MODULE_LICENSE("GPL");
 /*
  * Ordering of locks:
  *
- *              kvm->slots_lock --> kvm->lock --> kvm->irq_lock
+ *              kvm->lock --> kvm->slots_lock --> kvm->irq_lock
  */
 
 DEFINE_SPINLOCK(kvm_lock);
@@ -406,8 +406,11 @@ static struct kvm *kvm_create_vm(void)
 out:
         return kvm;
 
+#if defined(KVM_COALESCED_MMIO_PAGE_OFFSET) || \
+    (defined(CONFIG_MMU_NOTIFIER) && defined(KVM_ARCH_WANT_MMU_NOTIFIER))
 out_err:
         hardware_disable_all();
+#endif
 out_err_nodisable:
         kfree(kvm);
         return ERR_PTR(r);
@@ -1177,7 +1180,7 @@ static struct file_operations kvm_vcpu_fops = {
  */
 static int create_vcpu_fd(struct kvm_vcpu *vcpu)
 {
-        return anon_inode_getfd("kvm-vcpu", &kvm_vcpu_fops, vcpu, 0);
+        return anon_inode_getfd("kvm-vcpu", &kvm_vcpu_fops, vcpu, O_RDWR);
 }
 
 /*
@@ -1638,7 +1641,7 @@ static int kvm_dev_ioctl_create_vm(void)
         kvm = kvm_create_vm();
         if (IS_ERR(kvm))
                 return PTR_ERR(kvm);
-        fd = anon_inode_getfd("kvm-vm", &kvm_vm_fops, kvm, 0);
+        fd = anon_inode_getfd("kvm-vm", &kvm_vm_fops, kvm, O_RDWR);
         if (fd < 0)
                 kvm_put_kvm(kvm);