diff options
author | Christian Borntraeger <borntraeger@de.ibm.com> | 2009-06-23 11:24:06 -0400 |
---|---|---|
committer | Avi Kivity <avi@redhat.com> | 2009-09-10 01:33:01 -0400 |
commit | 3eea8437f61ca1f9192d146124425e759c3e5758 (patch) | |
tree | ae32ee0c2b33c0fc771a9ff3f7519ef2f6e8b9af /virt/kvm/kvm_main.c | |
parent | 4668f050787015805a7e8ea29cc4f81d8f07cedb (diff) |
KVM: s390: Fix memslot initialization for userspace_addr != 0
Since
commit 854b5338196b1175706e99d63be43a4f8d8ab607
Author: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
KVM: s390: streamline memslot handling
s390 uses the values of the memslot instead of doing everything in the arch
ioctl handler of the KVM_SET_USER_MEMORY_REGION. Unfortunately we missed to
set the userspace_addr of our memslot due to our s390 ifdef in
__kvm_set_memory_region.
Old s390 userspace launchers did not notice, since they started the guest at
userspace address 0.
Because of CONFIG_DEFAULT_MMAP_MIN_ADDR we now put the guest at 1M userspace,
which does not work. This patch makes sure that new.userspace_addr is set
on s390.
This fix should go in quickly. Nevertheless, looking at the code we should
clean up that ifdef in the long term. Any kernel janitors?
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'virt/kvm/kvm_main.c')
-rw-r--r-- | virt/kvm/kvm_main.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 04bdeddebdac..1da8072d61b1 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c | |||
@@ -1199,6 +1199,10 @@ int __kvm_set_memory_region(struct kvm *kvm, | |||
1199 | if (old.npages) | 1199 | if (old.npages) |
1200 | kvm_arch_flush_shadow(kvm); | 1200 | kvm_arch_flush_shadow(kvm); |
1201 | } | 1201 | } |
1202 | #else /* not defined CONFIG_S390 */ | ||
1203 | new.user_alloc = user_alloc; | ||
1204 | if (user_alloc) | ||
1205 | new.userspace_addr = mem->userspace_addr; | ||
1202 | #endif /* not defined CONFIG_S390 */ | 1206 | #endif /* not defined CONFIG_S390 */ |
1203 | 1207 | ||
1204 | if (!npages) | 1208 | if (!npages) |