perf_counter tools: Standardize color printing

The rule is:

 - high overhead: red
 -  mid overhead: green
 -  low overhead: normal (white/black)

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

3 files changed, 19 insertions, 12 deletions

diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 0e23fe98ec4e..3334a8bb1d51 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -1085,8 +1085,9 @@ parse_line(FILE *file, struct symbol *sym, uint64_t start, uint64_t len)
                         percent = 100.0 * hits / sym->hist_sum;
 
                 /*
-                 * We color high-overhead entries in red, low-overhead
-                 * entries in green - and keep the middle ground normal:
+                 * We color high-overhead entries in red, mid-overhead
+                 * entries in green - and keep the low overhead places
+                 * normal:
                  */
                 if (percent >= 5.0)
                         color = PERF_COLOR_RED;
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 61d871849b44..0b18cb99a858 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -693,13 +693,16 @@ hist_entry__fprintf(FILE *fp, struct hist_entry *self, uint64_t total_samples)
                 char *color = PERF_COLOR_NORMAL;
 
                 /*
-                 * We color high-overhead entries in red, low-overhead
-                 * entries in green - and keep the middle ground normal:
+                 * We color high-overhead entries in red, mid-overhead
+                 * entries in green - and keep the low overhead places
+                 * normal:
                  */
-                if (percent >= 5.0)
+                if (percent >= 5.0) {
                         color = PERF_COLOR_RED;
-                if (percent < 0.5)
-                        color = PERF_COLOR_GREEN;
+                } else {
+                        if (percent >= 0.5)
+                                color = PERF_COLOR_GREEN;
+                }
 
                 ret = color_fprintf(fp, color, "   %6.2f%%",
                                 (self->count * 100.0) / total_samples);
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index be1698f1189b..8ba24808a392 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -248,13 +248,16 @@ static void print_sym_table(void)
                                          sum_ksamples));
 
                 /*
-                 * We color high-overhead entries in red, low-overhead
-                 * entries in green - and keep the middle ground normal:
+                 * We color high-overhead entries in red, mid-overhead
+                 * entries in green - and keep the low overhead places
+                 * normal:
                  */
-                if (pcnt >= 5.0)
+                if (pcnt >= 5.0) {
                         color = PERF_COLOR_RED;
-                if (pcnt < 0.5)
-                        color = PERF_COLOR_GREEN;
+                } else {
+                        if (pcnt >= 0.5)
+                                color = PERF_COLOR_GREEN;
+                }
 
                 if (nr_counters == 1)
                         printf("%20.2f - ", syme->weight);