diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-12-10 08:44:37 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-12-10 14:51:07 -0500 |
commit | c7282f2efff9f115378b450b7aea51210fabb6ef (patch) | |
tree | 49af7eb10766d3a22a7805239f8a78179912c3e5 /tools | |
parent | e90debddf8f26094cd90162b9af2a8ed37ed57cb (diff) |
perf symbols: Rename [sl]name_alloc to match the members they refer to
So we now have:
dso->short_name
dso->short_name_len
dso->short_name_allocated
Ditto for the 'long variants. To more quickly grasp what they refer to.
Suggested-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-nu228f8vlp9w0lr7c0q77dqi@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/perf/util/dso.c | 4 | ||||
-rw-r--r-- | tools/perf/util/dso.h | 4 | ||||
-rw-r--r-- | tools/perf/util/machine.c | 4 | ||||
-rw-r--r-- | tools/perf/util/symbol.c | 6 |
4 files changed, 9 insertions, 9 deletions
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index a0c7c591f4b2..55c983586b05 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c | |||
@@ -465,9 +465,9 @@ void dso__delete(struct dso *dso) | |||
465 | int i; | 465 | int i; |
466 | for (i = 0; i < MAP__NR_TYPES; ++i) | 466 | for (i = 0; i < MAP__NR_TYPES; ++i) |
467 | symbols__delete(&dso->symbols[i]); | 467 | symbols__delete(&dso->symbols[i]); |
468 | if (dso->sname_alloc) | 468 | if (dso->short_name_allocated) |
469 | free((char *)dso->short_name); | 469 | free((char *)dso->short_name); |
470 | if (dso->lname_alloc) | 470 | if (dso->long_name_allocated) |
471 | free(dso->long_name); | 471 | free(dso->long_name); |
472 | dso_cache__free(&dso->cache); | 472 | dso_cache__free(&dso->cache); |
473 | dso__free_a2l(dso); | 473 | dso__free_a2l(dso); |
diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h index 384f2d97e38e..00a232d89607 100644 --- a/tools/perf/util/dso.h +++ b/tools/perf/util/dso.h | |||
@@ -89,8 +89,8 @@ struct dso { | |||
89 | u8 has_srcline:1; | 89 | u8 has_srcline:1; |
90 | u8 hit:1; | 90 | u8 hit:1; |
91 | u8 annotate_warned:1; | 91 | u8 annotate_warned:1; |
92 | u8 sname_alloc:1; | 92 | u8 short_name_allocated:1; |
93 | u8 lname_alloc:1; | 93 | u8 long_name_allocated:1; |
94 | u8 sorted_by_name; | 94 | u8 sorted_by_name; |
95 | u8 loaded; | 95 | u8 loaded; |
96 | u8 rel; | 96 | u8 rel; |
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index bac817ab2068..f66f309a091a 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c | |||
@@ -764,7 +764,7 @@ static int map_groups__set_modules_path_dir(struct map_groups *mg, | |||
764 | goto out; | 764 | goto out; |
765 | } | 765 | } |
766 | dso__set_long_name(map->dso, long_name); | 766 | dso__set_long_name(map->dso, long_name); |
767 | map->dso->lname_alloc = 1; | 767 | map->dso->long_name_allocated = 1; |
768 | dso__kernel_module_get_build_id(map->dso, ""); | 768 | dso__kernel_module_get_build_id(map->dso, ""); |
769 | } | 769 | } |
770 | } | 770 | } |
@@ -936,7 +936,7 @@ static int machine__process_kernel_mmap_event(struct machine *machine, | |||
936 | goto out_problem; | 936 | goto out_problem; |
937 | 937 | ||
938 | map->dso->short_name = name; | 938 | map->dso->short_name = name; |
939 | map->dso->sname_alloc = 1; | 939 | map->dso->short_name_allocated = 1; |
940 | map->end = map->start + event->mmap.len; | 940 | map->end = map->start + event->mmap.len; |
941 | } else if (is_kernel_mmap) { | 941 | } else if (is_kernel_mmap) { |
942 | const char *symbol_name = (event->mmap.filename + | 942 | const char *symbol_name = (event->mmap.filename + |
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index de87dbac50a0..265a149bc43f 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c | |||
@@ -1458,7 +1458,7 @@ int dso__load_vmlinux_path(struct dso *dso, struct map *map, | |||
1458 | if (filename != NULL) { | 1458 | if (filename != NULL) { |
1459 | err = dso__load_vmlinux(dso, map, filename, filter); | 1459 | err = dso__load_vmlinux(dso, map, filename, filter); |
1460 | if (err > 0) { | 1460 | if (err > 0) { |
1461 | dso->lname_alloc = 1; | 1461 | dso->long_name_allocated = 1; |
1462 | goto out; | 1462 | goto out; |
1463 | } | 1463 | } |
1464 | free(filename); | 1464 | free(filename); |
@@ -1468,7 +1468,7 @@ int dso__load_vmlinux_path(struct dso *dso, struct map *map, | |||
1468 | err = dso__load_vmlinux(dso, map, vmlinux_path[i], filter); | 1468 | err = dso__load_vmlinux(dso, map, vmlinux_path[i], filter); |
1469 | if (err > 0) { | 1469 | if (err > 0) { |
1470 | dso__set_long_name(dso, strdup(vmlinux_path[i])); | 1470 | dso__set_long_name(dso, strdup(vmlinux_path[i])); |
1471 | dso->lname_alloc = 1; | 1471 | dso->long_name_allocated = 1; |
1472 | break; | 1472 | break; |
1473 | } | 1473 | } |
1474 | } | 1474 | } |
@@ -1612,7 +1612,7 @@ static int dso__load_kernel_sym(struct dso *dso, struct map *map, | |||
1612 | if (err > 0) { | 1612 | if (err > 0) { |
1613 | dso__set_long_name(dso, | 1613 | dso__set_long_name(dso, |
1614 | strdup(symbol_conf.vmlinux_name)); | 1614 | strdup(symbol_conf.vmlinux_name)); |
1615 | dso->lname_alloc = 1; | 1615 | dso->long_name_allocated = 1; |
1616 | return err; | 1616 | return err; |
1617 | } | 1617 | } |
1618 | return err; | 1618 | return err; |