aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorRamkumar Ramachandra <artagnon@gmail.com>2013-10-01 04:36:44 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2013-10-11 11:17:35 -0400
commit3e7a081796146f97f166d77a655c0eb585065077 (patch)
treee68daf5bada3e0db9aa3b44f385cc00a6bde5237 /tools
parentc458fe62ca31496664c1211a7906d261220b18f9 (diff)
perf stat: Don't print bogus data on -e instructions
When only the instructions event is requested: $ perf stat -e instructions git s M builtin-stat.c Performance counter stats for 'git s': 917,453,420 instructions # 0.00 insns per cycle 0.213002926 seconds time elapsed The 0.00 insns per cycle comment in the output is totally bogus and misleading. It happens because update_shadow_stats() doesn't touch runtime_cycles_stats when only the instructions event is requested. So, omit printing the bogus data altogether. Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Acked-by: Ingo Molnar <mingo@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1380616604-4077-1-git-send-email-artagnon@gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/perf/builtin-stat.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index ce2266c5cd52..fb02b53b0e3d 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -930,11 +930,10 @@ static void abs_printout(int cpu, int nr, struct perf_evsel *evsel, double avg)
930 930
931 if (perf_evsel__match(evsel, HARDWARE, HW_INSTRUCTIONS)) { 931 if (perf_evsel__match(evsel, HARDWARE, HW_INSTRUCTIONS)) {
932 total = avg_stats(&runtime_cycles_stats[cpu]); 932 total = avg_stats(&runtime_cycles_stats[cpu]);
933 if (total) 933 if (total) {
934 ratio = avg / total; 934 ratio = avg / total;
935 935 fprintf(output, " # %5.2f insns per cycle ", ratio);
936 fprintf(output, " # %5.2f insns per cycle ", ratio); 936 }
937
938 total = avg_stats(&runtime_stalled_cycles_front_stats[cpu]); 937 total = avg_stats(&runtime_stalled_cycles_front_stats[cpu]);
939 total = max(total, avg_stats(&runtime_stalled_cycles_back_stats[cpu])); 938 total = max(total, avg_stats(&runtime_stalled_cycles_back_stats[cpu]));
940 939