diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-10-01 14:20:58 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-10-02 17:36:37 -0400 |
commit | 11c4e4a32b420db683cf58069c525e94797ce044 (patch) | |
tree | 09ae5367d2f8a21c07a12d65901cf17d2d551f00 /tools | |
parent | 6ee4149736e39deb7ed6d11c5de3101b5b8c2669 (diff) |
perf probe: Don't use globals where not needed to
Some variables were global but used in just one function, so move it to
where it belongs.
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-adql1rjwxlmahx9unvfi3wqo@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/perf/builtin-probe.c | 26 |
1 files changed, 12 insertions, 14 deletions
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c index 118aa8946573..de38a034b129 100644 --- a/tools/perf/builtin-probe.c +++ b/tools/perf/builtin-probe.c | |||
@@ -250,19 +250,20 @@ static int opt_set_filter(const struct option *opt __maybe_unused, | |||
250 | return 0; | 250 | return 0; |
251 | } | 251 | } |
252 | 252 | ||
253 | static const char * const probe_usage[] = { | 253 | int cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused) |
254 | "perf probe [<options>] 'PROBEDEF' ['PROBEDEF' ...]", | 254 | { |
255 | "perf probe [<options>] --add 'PROBEDEF' [--add 'PROBEDEF' ...]", | 255 | const char * const probe_usage[] = { |
256 | "perf probe [<options>] --del '[GROUP:]EVENT' ...", | 256 | "perf probe [<options>] 'PROBEDEF' ['PROBEDEF' ...]", |
257 | "perf probe --list", | 257 | "perf probe [<options>] --add 'PROBEDEF' [--add 'PROBEDEF' ...]", |
258 | "perf probe [<options>] --del '[GROUP:]EVENT' ...", | ||
259 | "perf probe --list", | ||
258 | #ifdef DWARF_SUPPORT | 260 | #ifdef DWARF_SUPPORT |
259 | "perf probe [<options>] --line 'LINEDESC'", | 261 | "perf probe [<options>] --line 'LINEDESC'", |
260 | "perf probe [<options>] --vars 'PROBEPOINT'", | 262 | "perf probe [<options>] --vars 'PROBEPOINT'", |
261 | #endif | 263 | #endif |
262 | NULL | 264 | NULL |
263 | }; | 265 | }; |
264 | 266 | const struct option options[] = { | |
265 | static const struct option options[] = { | ||
266 | OPT_INCR('v', "verbose", &verbose, | 267 | OPT_INCR('v', "verbose", &verbose, |
267 | "be more verbose (show parsed arguments, etc)"), | 268 | "be more verbose (show parsed arguments, etc)"), |
268 | OPT_BOOLEAN('l', "list", ¶ms.list_events, | 269 | OPT_BOOLEAN('l', "list", ¶ms.list_events, |
@@ -325,10 +326,7 @@ static const struct option options[] = { | |||
325 | OPT_CALLBACK('x', "exec", NULL, "executable|path", | 326 | OPT_CALLBACK('x', "exec", NULL, "executable|path", |
326 | "target executable name or path", opt_set_target), | 327 | "target executable name or path", opt_set_target), |
327 | OPT_END() | 328 | OPT_END() |
328 | }; | 329 | }; |
329 | |||
330 | int cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused) | ||
331 | { | ||
332 | int ret; | 330 | int ret; |
333 | 331 | ||
334 | argc = parse_options(argc, argv, options, probe_usage, | 332 | argc = parse_options(argc, argv, options, probe_usage, |