diff options
author | Borislav Petkov <bp@alien8.de> | 2010-05-31 17:18:18 -0400 |
---|---|---|
committer | Frederic Weisbecker <fweisbec@gmail.com> | 2010-05-31 18:57:14 -0400 |
commit | 2fb750e825b5347de0390315f4284f13709a9856 (patch) | |
tree | 83ee23e2e1de5460c399e7f527a27acf412022f5 /tools | |
parent | dd833d713ccc79e00176eb1b3a6c65638c44e27b (diff) |
perf-record: Check correct pid when forking
When forking the child to be traced, we should check the correct
return value from fork() and not a local variable which is otherwise
unused.
Signed-off-by: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Tom Zanussi <tzanussi@gmail.com>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <20100531211818.GA30175@liondog.tnic>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/perf/builtin-record.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 9bc89050e6f8..dc3435e18bde 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c | |||
@@ -503,7 +503,6 @@ static int __cmd_record(int argc, const char **argv) | |||
503 | { | 503 | { |
504 | int i, counter; | 504 | int i, counter; |
505 | struct stat st; | 505 | struct stat st; |
506 | pid_t pid = 0; | ||
507 | int flags; | 506 | int flags; |
508 | int err; | 507 | int err; |
509 | unsigned long waking = 0; | 508 | unsigned long waking = 0; |
@@ -572,7 +571,7 @@ static int __cmd_record(int argc, const char **argv) | |||
572 | 571 | ||
573 | if (forks) { | 572 | if (forks) { |
574 | child_pid = fork(); | 573 | child_pid = fork(); |
575 | if (pid < 0) { | 574 | if (child_pid < 0) { |
576 | perror("failed to fork"); | 575 | perror("failed to fork"); |
577 | exit(-1); | 576 | exit(-1); |
578 | } | 577 | } |