aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2013-01-24 20:34:33 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2013-01-25 10:49:29 -0500
commit2caa48a24061b1f8e8dab43ea3292a608a15e3c9 (patch)
treef0abc1e2d2b309ad06f21cb5203771f6faace6f7 /tools
parent8d9233f205e8855dc762665e28012354cd46af45 (diff)
perf header: Stop using die() calls when processing tracing data
The callers of this function (perf_event__process_tracing_data) already handles a negative value return as error, so just use pr_err() to log the problem and return -1 instead of panic'ing. Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-eeeljnecpi0zi5s7ux1mzdv9@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/perf/util/header.c18
1 files changed, 12 insertions, 6 deletions
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index fccd69dbbbb9..e17a8fe9c4d7 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -2921,16 +2921,22 @@ int perf_event__process_tracing_data(union perf_event *event,
2921 session->repipe); 2921 session->repipe);
2922 padding = PERF_ALIGN(size_read, sizeof(u64)) - size_read; 2922 padding = PERF_ALIGN(size_read, sizeof(u64)) - size_read;
2923 2923
2924 if (readn(session->fd, buf, padding) < 0) 2924 if (readn(session->fd, buf, padding) < 0) {
2925 die("reading input file"); 2925 pr_err("%s: reading input file", __func__);
2926 return -1;
2927 }
2926 if (session->repipe) { 2928 if (session->repipe) {
2927 int retw = write(STDOUT_FILENO, buf, padding); 2929 int retw = write(STDOUT_FILENO, buf, padding);
2928 if (retw <= 0 || retw != padding) 2930 if (retw <= 0 || retw != padding) {
2929 die("repiping tracing data padding"); 2931 pr_err("%s: repiping tracing data padding", __func__);
2932 return -1;
2933 }
2930 } 2934 }
2931 2935
2932 if (size_read + padding != size) 2936 if (size_read + padding != size) {
2933 die("tracing data size mismatch"); 2937 pr_err("%s: tracing data size mismatch", __func__);
2938 return -1;
2939 }
2934 2940
2935 perf_evlist__prepare_tracepoint_events(session->evlist, 2941 perf_evlist__prepare_tracepoint_events(session->evlist,
2936 session->pevent); 2942 session->pevent);