diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2009-11-02 12:46:06 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-11-02 12:46:06 -0500 |
| commit | bce8fc4cb796dc77ea71699ef88802879a177474 (patch) | |
| tree | 683ff9f2def12d390af0ae2dc2326b4d9f85a1cd /tools | |
| parent | a5e3013d6612d2ed4aefdcd7920ae01df3b63b3a (diff) | |
| parent | ec29b8d2af01912bb79adda8aeab4293539f29ac (diff) | |
Merge branch 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
* 'perf-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
perf tools: Remove -Wcast-align
perf tools: Fix compatibility with libelf 0.8 and autodetect
perf events: Don't generate events for the idle task when exclude_idle is set
perf events: Fix swevent hrtimer sampling by keeping track of remaining time when enabling/disabling swevent hrtimers
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/Makefile | 9 | ||||
| -rw-r--r-- | tools/perf/util/symbol.c | 6 | ||||
| -rw-r--r-- | tools/perf/util/symbol.h | 10 |
3 files changed, 19 insertions, 6 deletions
diff --git a/tools/perf/Makefile b/tools/perf/Makefile index 742a32eee8fc..7e190d522cd5 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile | |||
| @@ -177,8 +177,7 @@ endif | |||
| 177 | # Include saner warnings here, which can catch bugs: | 177 | # Include saner warnings here, which can catch bugs: |
| 178 | # | 178 | # |
| 179 | 179 | ||
| 180 | EXTRA_WARNINGS := -Wcast-align | 180 | EXTRA_WARNINGS := -Wformat |
| 181 | EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wformat | ||
| 182 | EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wformat-security | 181 | EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wformat-security |
| 183 | EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wformat-y2k | 182 | EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wformat-y2k |
| 184 | EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wshadow | 183 | EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wshadow |
| @@ -422,7 +421,11 @@ ifeq ($(uname_S),Darwin) | |||
| 422 | PTHREAD_LIBS = | 421 | PTHREAD_LIBS = |
| 423 | endif | 422 | endif |
| 424 | 423 | ||
| 425 | ifneq ($(shell sh -c "(echo '\#include <libelf.h>'; echo 'int main(void) { Elf * elf = elf_begin(0, ELF_C_READ_MMAP, 0); return (long)elf; }') | $(CC) -x c - $(ALL_CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -o /dev/null $(ALL_LDFLAGS) > /dev/null 2>&1 && echo y"), y) | 424 | ifeq ($(shell sh -c "(echo '\#include <libelf.h>'; echo 'int main(void) { Elf * elf = elf_begin(0, ELF_C_READ, 0); return (long)elf; }') | $(CC) -x c - $(ALL_CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -o /dev/null $(ALL_LDFLAGS) > /dev/null 2>&1 && echo y"), y) |
| 425 | ifneq ($(shell sh -c "(echo '\#include <libelf.h>'; echo 'int main(void) { Elf * elf = elf_begin(0, ELF_C_READ_MMAP, 0); return (long)elf; }') | $(CC) -x c - $(ALL_CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -o /dev/null $(ALL_LDFLAGS) > /dev/null 2>&1 && echo y"), y) | ||
| 426 | BASIC_CFLAGS += -DLIBELF_NO_MMAP | ||
| 427 | endif | ||
| 428 | else | ||
| 426 | msg := $(error No libelf.h/libelf found, please install libelf-dev/elfutils-libelf-devel and glibc-dev[el]); | 429 | msg := $(error No libelf.h/libelf found, please install libelf-dev/elfutils-libelf-devel and glibc-dev[el]); |
| 427 | endif | 430 | endif |
| 428 | 431 | ||
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 47ea0609a760..226f44a2357d 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c | |||
| @@ -413,7 +413,7 @@ static int dso__synthesize_plt_symbols(struct dso *self, int v) | |||
| 413 | if (fd < 0) | 413 | if (fd < 0) |
| 414 | goto out; | 414 | goto out; |
| 415 | 415 | ||
| 416 | elf = elf_begin(fd, ELF_C_READ_MMAP, NULL); | 416 | elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL); |
| 417 | if (elf == NULL) | 417 | if (elf == NULL) |
| 418 | goto out_close; | 418 | goto out_close; |
| 419 | 419 | ||
| @@ -533,7 +533,7 @@ static int dso__load_sym(struct dso *self, int fd, const char *name, | |||
| 533 | Elf *elf; | 533 | Elf *elf; |
| 534 | int nr = 0, kernel = !strcmp("[kernel]", self->name); | 534 | int nr = 0, kernel = !strcmp("[kernel]", self->name); |
| 535 | 535 | ||
| 536 | elf = elf_begin(fd, ELF_C_READ_MMAP, NULL); | 536 | elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL); |
| 537 | if (elf == NULL) { | 537 | if (elf == NULL) { |
| 538 | if (v) | 538 | if (v) |
| 539 | fprintf(stderr, "%s: cannot read %s ELF file.\n", | 539 | fprintf(stderr, "%s: cannot read %s ELF file.\n", |
| @@ -675,7 +675,7 @@ static char *dso__read_build_id(struct dso *self, int v) | |||
| 675 | if (fd < 0) | 675 | if (fd < 0) |
| 676 | goto out; | 676 | goto out; |
| 677 | 677 | ||
| 678 | elf = elf_begin(fd, ELF_C_READ_MMAP, NULL); | 678 | elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL); |
| 679 | if (elf == NULL) { | 679 | if (elf == NULL) { |
| 680 | if (v) | 680 | if (v) |
| 681 | fprintf(stderr, "%s: cannot read %s ELF file.\n", | 681 | fprintf(stderr, "%s: cannot read %s ELF file.\n", |
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 6e8490716408..829da9edba64 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h | |||
| @@ -27,6 +27,16 @@ static inline char *bfd_demangle(void __used *v, const char __used *c, | |||
| 27 | #endif | 27 | #endif |
| 28 | #endif | 28 | #endif |
| 29 | 29 | ||
| 30 | /* | ||
| 31 | * libelf 0.8.x and earlier do not support ELF_C_READ_MMAP; | ||
| 32 | * for newer versions we can use mmap to reduce memory usage: | ||
| 33 | */ | ||
| 34 | #ifdef LIBELF_NO_MMAP | ||
| 35 | # define PERF_ELF_C_READ_MMAP ELF_C_READ | ||
| 36 | #else | ||
| 37 | # define PERF_ELF_C_READ_MMAP ELF_C_READ_MMAP | ||
| 38 | #endif | ||
| 39 | |||
| 30 | #ifndef DMGL_PARAMS | 40 | #ifndef DMGL_PARAMS |
| 31 | #define DMGL_PARAMS (1 << 0) /* Include function args */ | 41 | #define DMGL_PARAMS (1 << 0) /* Include function args */ |
| 32 | #define DMGL_ANSI (1 << 1) /* Include const, volatile, etc */ | 42 | #define DMGL_ANSI (1 << 1) /* Include const, volatile, etc */ |
