aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2012-11-09 13:42:26 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2012-11-09 15:35:15 -0500
commite46466b8bd5918626250dc0d6cb6c2147a611087 (patch)
treed63153da5d22ab7387a0ba3b6c754925e5a8fc66 /tools
parent8a38cce4c900307e947eda774f844caf5b9a7083 (diff)
tools lib traceevent: No need to check for < 0 on an unsigned enum
gcc on f14 32-bit complains: tools/lib/traceevent/event-parse.c: In function ‘pevent_register_print_function’: tools/lib/traceevent/event-parse.c:5366:3: error: comparison of unsigned expression < 0 is always false This is because: enum pevent_func_arg_type type; this enum doesn't have any negative value, so gcc makes it an 'unsigned int'. Fix it by removing the < 0 test. Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Cc: Steven Rostedt <rostedt@goodmis.org> Link: http://lkml.kernel.org/n/tip-6vnd6ud6fbpn48zax4a5ru01@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/lib/traceevent/event-parse.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 6b647c17fff4..38d6595891a4 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -5363,7 +5363,7 @@ int pevent_register_print_function(struct pevent *pevent,
5363 if (type == PEVENT_FUNC_ARG_VOID) 5363 if (type == PEVENT_FUNC_ARG_VOID)
5364 break; 5364 break;
5365 5365
5366 if (type < 0 || type >= PEVENT_FUNC_ARG_MAX_TYPES) { 5366 if (type >= PEVENT_FUNC_ARG_MAX_TYPES) {
5367 do_warning("Invalid argument type %d", type); 5367 do_warning("Invalid argument type %d", type);
5368 ret = PEVENT_ERRNO__INVALID_ARG_TYPE; 5368 ret = PEVENT_ERRNO__INVALID_ARG_TYPE;
5369 goto out_free; 5369 goto out_free;