diff options
| author | David Ahern <dsahern@gmail.com> | 2012-07-20 19:25:48 -0400 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-07-25 10:29:46 -0400 |
| commit | 7c0f4a4113ba5de7898c246eeaeee4c23d94b887 (patch) | |
| tree | dacbffa32d90fe5810745854f525c3591d3c78c3 /tools | |
| parent | 5cd95c2db479aa7a66f6fa572dfa410c6314c78e (diff) | |
perf kvm: Guest userspace samples should not be lumped with host uspace
e.g., perf kvm --host --guest report -i perf.data --stdio -D
shows:
1 599127912065356 0x143b8 [0x48]: PERF_RECORD_SAMPLE(IP, 5): 5671/5676: 0x7fdf95a061c0 period: 1 addr: 0
... chain: nr:2
..... 0: ffffffffffffff80
..... 1: fffffffffffffe00
... thread: qemu-kvm:5671
...... dso: <not found>
(IP, 5) means sample in guest userspace. Those samples should not be lumped
into the VMM's host thread. i.e, the report output:
56.86% qemu-kvm [unknown] [u] 0x00007fdf95a061c0
With this patch the output emphasizes it is a guest userspace hit:
56.86% [guest/5671] [unknown] [u] 0x00007fdf95a061c0
Looking at 3 VMs (2 64-bit, 1 32-bit) with each running a CPU bound
process (openssl speed), perf report currently shows:
93.84% 117726 qemu-kvm [unknown] [u] 0x00007fd7dcaea8e5
which is wrong. With this patch you get:
31.50% 39258 [guest/18772] [unknown] [u] 0x00007fd7dcaea8e5
31.50% 39236 [guest/11230] [unknown] [u] 0x0000000000a57340
30.84% 39232 [guest/18395] [unknown] [u] 0x00007f66f641e107
Tested-by: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1342826756-64663-4-git-send-email-dsahern@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/session.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 8e485592ca20..90ee39dd8ab2 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c | |||
| @@ -918,7 +918,9 @@ static struct machine * | |||
| 918 | { | 918 | { |
| 919 | const u8 cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK; | 919 | const u8 cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK; |
| 920 | 920 | ||
| 921 | if (cpumode == PERF_RECORD_MISC_GUEST_KERNEL && perf_guest) { | 921 | if (perf_guest && |
| 922 | ((cpumode == PERF_RECORD_MISC_GUEST_KERNEL) || | ||
| 923 | (cpumode == PERF_RECORD_MISC_GUEST_USER))) { | ||
| 922 | u32 pid; | 924 | u32 pid; |
| 923 | 925 | ||
| 924 | if (event->header.type == PERF_RECORD_MMAP) | 926 | if (event->header.type == PERF_RECORD_MMAP) |