diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-03-12 19:05:10 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2010-03-13 02:23:37 -0500 |
commit | 567e54790e5c07152a93b6de4d0210af8b77da87 (patch) | |
tree | 075fdcbd2d2a868feda3911f6782f117c2dea7a2 /tools | |
parent | 0308635917273030db6121d67c41ef2279b30340 (diff) |
perf tools: Fix non-newt build
The use_browser needs to be in a file that is always built and
also we need a browser__show_help stub in that case.
Reported-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1268438710-32697-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/perf/perf.c | 2 | ||||
-rw-r--r-- | tools/perf/util/debug.h | 8 | ||||
-rw-r--r-- | tools/perf/util/newt.c | 2 |
3 files changed, 10 insertions, 2 deletions
diff --git a/tools/perf/perf.c b/tools/perf/perf.c index 9ff186b57cb7..0d4b9edfab12 100644 --- a/tools/perf/perf.c +++ b/tools/perf/perf.c | |||
@@ -16,6 +16,8 @@ | |||
16 | #include "util/string.h" | 16 | #include "util/string.h" |
17 | #include "util/debugfs.h" | 17 | #include "util/debugfs.h" |
18 | 18 | ||
19 | bool use_browser; | ||
20 | |||
19 | const char perf_usage_string[] = | 21 | const char perf_usage_string[] = |
20 | "perf [--version] [--help] COMMAND [ARGS]"; | 22 | "perf [--version] [--help] COMMAND [ARGS]"; |
21 | 23 | ||
diff --git a/tools/perf/util/debug.h b/tools/perf/util/debug.h index 03accb867996..0172edf3f153 100644 --- a/tools/perf/util/debug.h +++ b/tools/perf/util/debug.h | |||
@@ -9,6 +9,14 @@ extern int dump_trace; | |||
9 | 9 | ||
10 | int dump_printf(const char *fmt, ...) __attribute__((format(printf, 1, 2))); | 10 | int dump_printf(const char *fmt, ...) __attribute__((format(printf, 1, 2))); |
11 | void trace_event(event_t *event); | 11 | void trace_event(event_t *event); |
12 | |||
13 | #ifdef NO_NEWT_SUPPORT | ||
14 | static inline int browser__show_help(const char *format __used, va_list ap __used) | ||
15 | { | ||
16 | return 0; | ||
17 | } | ||
18 | #else | ||
12 | int browser__show_help(const char *format, va_list ap); | 19 | int browser__show_help(const char *format, va_list ap); |
20 | #endif | ||
13 | 21 | ||
14 | #endif /* __PERF_DEBUG_H */ | 22 | #endif /* __PERF_DEBUG_H */ |
diff --git a/tools/perf/util/newt.c b/tools/perf/util/newt.c index f6ec6f5c0fd9..2836394459d9 100644 --- a/tools/perf/util/newt.c +++ b/tools/perf/util/newt.c | |||
@@ -189,8 +189,6 @@ int browser__show_help(const char *format, va_list ap) | |||
189 | return ret; | 189 | return ret; |
190 | } | 190 | } |
191 | 191 | ||
192 | bool use_browser; | ||
193 | |||
194 | void setup_browser(void) | 192 | void setup_browser(void) |
195 | { | 193 | { |
196 | if (!isatty(1)) | 194 | if (!isatty(1)) |